Add support to clone existing offerings and update them by Pearl1594 · Pull Request #12357 · apache/cloudstack

Pearl1594 · 2025-12-31T16:20:44Z

Description

This PR adds APIs to clone existing offerings - service, system, network, VPC, backup and update certain parameters of the existing offering.

Doc PR: apache/cloudstack-documentation#630

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-12-31T16:27:13Z

Codecov Report

❌ Patch coverage is 49.82669% with 579 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.00%. Comparing base (da85858) to head (77ff9e5).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.48%	205 Missing and 2 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	70.46%	102 Missing and 64 partials ⚠️
.../command/admin/network/NetworkOfferingBaseCmd.java	29.64%	129 Missing and 11 partials ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java	51.11%	9 Missing and 13 partials ⚠️
...i/command/admin/backup/CloneBackupOfferingCmd.java	66.00%	17 Missing ⚠️
...i/command/admin/offering/CloneDiskOfferingCmd.java	0.00%	13 Missing ⚠️
...ack/api/command/admin/vpc/CloneVPCOfferingCmd.java	60.00%	10 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #12357 +/- ##
============================================
+ Coverage 17.93% 18.00% +0.07% - Complexity 16160 16349 +189 
============================================
Files 5939 5953 +14 Lines 533147 535395 +2248 Branches 65237 65775 +538 ============================================
+ Hits 95607 96403 +796 - Misses 426797 428105 +1308 - Partials 10743 10887 +144

Flag	Coverage Δ
uitests	`3.54% <ø> (-0.12%)`	⬇️
unittests	`19.16% <49.82%> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-19T12:10:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2026-01-21T08:09:58Z

could you make the new if and for blocks separte methods (with clear names please?

Copilot

Pull request overview

This PR introduces “clone offering” functionality across the CloudStack API and UI, enabling users to clone existing offerings (compute/service, disk, network, VPC, backup) while overriding selected parameters. It also refactors network/VPC service-capability param building into shared UI helpers and wires the new actions into the offerings UI.

Changes:

Added new API commands and server implementations for cloning multiple offering types (plus event types and service interfaces).
Added new UI clone views (compute/disk/backup shown here) and integrated clone actions into the offerings section config.
Refactored network/VPC service-capability parameter construction into a shared composable and extracted disk offering form into a reusable component.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
ui/src/views/offering/CloneDiskOffering.vue	New UI flow to clone disk offerings using the shared `DiskOfferingForm`.
ui/src/views/offering/CloneComputeOffering.vue	New UI flow to clone compute/service offerings (includes prefill + submit logic).
ui/src/views/offering/CloneBackupOffering.vue	New UI flow to clone backup offerings (zone/provider offering selection + async job polling).
ui/src/views/offering/AddVpcOffering.vue	Refactors VPC service capability param building into a shared helper.
ui/src/views/offering/AddNetworkOffering.vue	Refactors network service capability param building into a shared helper.
ui/src/views/offering/AddDiskOffering.vue	Refactors disk offering creation to use the new shared `DiskOfferingForm` component.
ui/src/config/section/offering.js	Adds new “Clone * Offering” actions in the UI offerings sections.
ui/src/composables/useServiceCapabilityParams.js	New shared helper(s) to build serviceCapability/serviceProvider param sets for network/VPC offerings.
ui/src/components/offering/DiskOfferingForm.vue	New reusable disk offering form component extracted from the previous view.
ui/src/components/CheckBoxSelectPair.vue	Adds support for setting a default select value.
ui/public/locales/en.json	Adds i18n strings for clone offering actions and messages.
server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java	Adds tests asserting cloned backup offering domain handling.
server/src/test/java/com/cloud/vpc/MockConfigurationManagerImpl.java	Updates test mock to support new clone APIs and new base cmd type for network offering creation.
server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java	Adds tests around reflection helpers and some clone-related scaffolding.
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java	Implements backup offering clone behavior and registers the command.
server/src/main/java/com/cloud/server/ManagementServerImpl.java	Registers new clone commands in management server command list.
server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java	Implements VPC offering clone logic, including service/provider/capability reconstruction.
api/src/test/java/org/apache/cloudstack/api/command/admin/vpc/CloneVpcOfferingCmdTest.java	Adds unit tests for the new clone VPC offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/offering/CloneServiceOfferingCmdTest.java	Adds unit tests for the new clone service offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/network/CloneNetworkOfferingCmdTest.java	Adds unit tests for the new clone network offering command.
api/src/test/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmdTest.java	Adds unit tests for the new clone backup offering command.
api/src/main/java/org/apache/cloudstack/backup/BackupManager.java	Adds `cloneBackupOffering` to the backup manager interface.
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java	Adjusts supported-services behavior for external providers (validation moved server-side).
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CloneVPCOfferingCmd.java	New API command for cloning VPC offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CloneServiceOfferingCmd.java	New API command for cloning service offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CloneDiskOfferingCmd.java	New API command for cloning disk offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java	New base command consolidating shared network-offering params/logic.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java	Refactors create network offering cmd to extend `NetworkOfferingBaseCmd`.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CloneNetworkOfferingCmd.java	New API command for cloning network offerings.
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/ImportBackupOfferingCmd.java	Makes `backupManager` protected and annotates domainIds param with `since`.
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/CloneBackupOfferingCmd.java	New API command for cloning backup offerings (domainIds resolver support).
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java	Adds `SOURCE_OFFERING_ID` constant.
api/src/main/java/com/cloud/network/vpc/VpcProvisioningService.java	Adds `cloneVPCOffering` to VPC provisioning service interface.
api/src/main/java/com/cloud/event/EventTypes.java	Adds new event types for offering/backup offering clone.
api/src/main/java/com/cloud/configuration/ConfigurationService.java	Adds clone methods and generalizes `createNetworkOffering` to accept the new base cmd.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T15:02:03Z

+export default {
+ name: 'CreateComputeOffering',
+ mixins: [mixinForm],
+ components: {


The component is registered with name 'CreateComputeOffering', but this view is for cloning. This breaks devtools/component identification and may affect caching/keep-alive behavior if other components rely on the name. Rename it to 'CloneComputeOffering' (or another clone-specific name).

Copilot · 2026-02-08T15:02:03Z

+ }
+
+ params.sourceofferingid = this.resource.id
+
+ postAPI('cloneServiceOffering', params).then(json => {
+ const message = this.isSystem


this.loading is never set to true before calling postAPI('cloneServiceOffering', ...), so the submit-guard (if (this.loading) return) does not prevent double submits and the UI spinner never activates. Set this.loading = true immediately before the API call (and keep the existing finally that resets it).

Copilot · 2026-02-08T15:02:04Z

+ }).then(json => {
+ this.diskOfferings = json.listdiskofferingsresponse.diskoffering || []
+ if (this.selectedDiskOfferingId === '') {
+ this.selectedDiskOfferingId = this.diskOfferings[0].id || ''
+ }


this.diskOfferings[0].id will throw if listDiskOfferings returns an empty list. Guard with a length check (or use optional chaining) before reading the first element.

Copilot · 2026-02-08T15:02:04Z

+ <a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />
+ </a-form-item>
+ <a-form-item name="disksizestrictness" ref="disksizestrictness">
+ <template #label>
+ <tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
+ </template>
+ <a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />


The switch uses both v-model:checked and an explicit :checked bound to a different data property (encryptdisk). This can desynchronize the UI from form.encryptdisk (especially when initialValues sets a non-default). Prefer binding only via v-model:checked and remove the separate :checked/@change state mirror.
Suggested change
<a-switchv-model:checked="form.encryptdisk":checked="encryptdisk" @change="val=> { encryptdisk=val }"/>
</a-form-item>
<a-form-item name="disksizestrictness" ref="disksizestrictness">
<template #label>
<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
</template>
<a-switchv-model:checked="form.disksizestrictness":checked="disksizestrictness" @change="val=> { disksizestrictness=val }"/>
<a-switchv-model:checked="form.encryptdisk" />
</a-form-item>
<a-form-item name="disksizestrictness" ref="disksizestrictness">
<template #label>
<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
</template>
<a-switchv-model:checked="form.disksizestrictness" />

Copilot · 2026-02-08T15:02:04Z

+ <a-switch v-model:checked="form.encryptdisk" :checked="encryptdisk" @change="val => { encryptdisk = val }" />
+ </a-form-item>
+ <a-form-item name="disksizestrictness" ref="disksizestrictness">
+ <template #label>
+ <tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
+ </template>
+ <a-switch v-model:checked="form.disksizestrictness" :checked="disksizestrictness" @change="val => { disksizestrictness = val }" />


Same issue as encrypt switch: v-model:checked plus explicit :checked backed by disksizestrictness can cause the displayed value to diverge from form.disksizestrictness / initialValues. Bind the switch to a single source of truth (the form model).
Suggested change
<a-switchv-model:checked="form.encryptdisk":checked="encryptdisk" @change="val=> { encryptdisk=val }"/>
</a-form-item>
<a-form-item name="disksizestrictness" ref="disksizestrictness">
<template #label>
<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
</template>
<a-switchv-model:checked="form.disksizestrictness":checked="disksizestrictness" @change="val=> { disksizestrictness=val }"/>
<a-switchv-model:checked="form.encryptdisk" />
</a-form-item>
<a-form-item name="disksizestrictness" ref="disksizestrictness">
<template #label>
<tooltip-label :title="$t('label.disksizestrictness')" :tooltip="apiParams.disksizestrictness.description" />
</template>
<a-switchv-model:checked="form.disksizestrictness" />

Pearl1594 · 2026-02-26T13:26:00Z

@blueorangutan package

blueorangutan · 2026-02-26T13:28:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-26T14:21:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16963

Pearl1594 · 2026-02-26T20:25:05Z

@blueorangutan test

blueorangutan · 2026-02-26T20:26:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-02-26T21:15:39Z

[SF] Trillian Build Failed (tid-15538)

kiranchavala · 2026-02-27T08:12:45Z

@blueorangutan test

blueorangutan · 2026-02-27T08:14:03Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sonarqubecloud · 2026-02-27T18:07:33Z

Quality Gate failed

Failed conditions
37.1% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

blueorangutan · 2026-02-27T23:40:25Z

[SF] Trillian test result (tid-15543)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52645 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12357-t15543-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_LoginApiDomain	`Error`	7.54	test_accounts.py
ContextSuite context=TestListIdsParams>:teardown	`Error`	1.14	test_list_ids_parameter.py
test_01_snapshot_root_disk	`Error`	5.87	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.59	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.59	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	`Error`	28.69	test_snapshots.py
test_01_snapshot_usage	`Error`	21.58	test_usage.py
test_01_vpn_usage	`Error`	1.09	test_usage.py

kiranchavala · 2026-03-04T06:34:04Z

@blueorangutan package

blueorangutan · 2026-03-04T06:36:04Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-04T07:31:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16997

kiranchavala · 2026-03-05T04:28:08Z

@blueorangutan test

blueorangutan · 2026-03-05T04:30:04Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

kiranchavala

LGTM Tested manually

Test Case Execution	Result
Test clone offering for compute offering	Pass
Test clone offering on system offerings	Pass
Test clone offering on disk offerings	Pass
Test clone offering on backup offering	Pass
Test clone offering on network offerings	Pass
Test clone offering on vpc offerings	Pass
Test copy of service ( compute offering ) from domainadmin user role	Pass
Test copy of service ( diskoffering ) from domainadmin user role	Pass

DaanHoogland · 2026-03-05T19:06:49Z

@Pearl1594 , is this ready for merge?

Pearl1594 · 2026-03-05T19:15:29Z

@DaanHoogland just waiting for test results and comments.. Probably would be ready by early next week.

blueorangutan · 2026-03-05T19:27:53Z

[SF] Trillian test result (tid-15561)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51052 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12357-t15561-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_LoginApiDomain	`Error`	7.43	test_accounts.py
ContextSuite context=TestListIdsParams>:teardown	`Error`	1.13	test_list_ids_parameter.py
test_01_snapshot_root_disk	`Error`	5.01	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.84	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.85	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	`Error`	27.69	test_snapshots.py
test_01_snapshot_usage	`Error`	22.73	test_usage.py
test_01_vpn_usage	`Error`	1.10	test_usage.py

harikrishna-patnala · 2026-03-10T06:43:30Z

@Pearl1594 there are some test failures and extra simulator test run failures than the main branch health check PR. Can you please check and confirm if they are unrelated or not.

Pearl1594 · 2026-03-10T11:07:37Z

@harikrishna-patnala the smoke test failures seem to be happening upstream on other PRs too: #12680 (comment)

I have initiated re-run of the ci tests, will keep an eye

Pearl1594 · 2026-03-11T15:38:45Z

@harikrishna-patnala the smoke test and ci test failures are unrelated to the PR as far as I've checked.

* Add support to clone existing offerings and update them * add support for vpc & backup offerings to be cloned * fix capability list and mapping of params * Add support to clone network and vpc offering with the right parameters * make fields non mandatory for clone offerings APIs * Add UI support for cloning Compute and System Service offerings * remove unnecessary changes * fix license and pre-ccommit issues * Add UI support to clone disk and network offering * vpc & backup offering clone api * add unit tests * fix pre-commit checks * increase test coverage * combine add/clone disk/compute offering forms * update license * fix unit tests * fix test failures * fix test failure - unnecessary stubbings * pre-commit check failure * add recently added domain id for bkp offering to be inherited in clone operation * extract common code wrt service capability in network & vpc offering in add/clone operations * add some checks to prevent networkmode change when provider is nsx/netris from the source networkmode * address copilot comments * address comments * combine check * use appropriate zoneId during clone bkp offering * add check * fix issue with test * remove unused imports * prevent creating a bkp offering of a bkp repo that already exists * extend clone disk and service offerings to domain admins

boring-cyborgBot added component:api component:management-server component:vpc labels Dec 31, 2025

boring-cyborgBot added component:backup component:networking labels Jan 6, 2026

Pearl1594 force-pushed the clone-edit-existing-offerings branch from 62368f3 to 3787aaaCompare January 6, 2026 22:39

DaanHoogland added this to the 4.23.0 milestone Jan 7, 2026

boring-cyborgBot added the component:UI label Jan 7, 2026

Pearl1594 force-pushed the clone-edit-existing-offerings branch 2 times, most recently from bb2e90d to 7fd4567Compare January 8, 2026 21:52

boring-cyborgBot added component:marvin Python Warning... Python code Ahead! labels Jan 9, 2026

github-actionsBot added the status:has-conflicts label Jan 19, 2026

DaanHoogland reviewed Jan 21, 2026
View reviewed changes

github-actionsBot removed the status:has-conflicts label Jan 21, 2026

Pearl1594 force-pushed the clone-edit-existing-offerings branch 3 times, most recently from 1f5796d to 10333dfCompare January 21, 2026 22:02

Pearl1594 requested a review from ustcweizhou February 2, 2026 13:26

Pearl1594 closed this Feb 2, 2026

Pearl1594 reopened this Feb 2, 2026

Pearl1594 closed this Feb 2, 2026

Pearl1594 reopened this Feb 2, 2026

weizhouapache requested review from Copilot and weizhouapache and removed request for ustcweizhou February 3, 2026 15:45

Copilotstarted reviewing on behalf of weizhouapache February 8, 2026 14:51 View session

CopilotAI reviewed Feb 8, 2026
View reviewed changes

extend clone disk and service offerings to domain admins
77ff9e5

kiranchavala approved these changes Mar 5, 2026
View reviewed changes

harikrishna-patnala marked this pull request as ready for review March 17, 2026 06:30

harikrishna-patnala merged commit 3bd5410 into mainMar 17, 2026
56 of 86 checks passed

harikrishna-patnala deleted the clone-edit-existing-offerings branch March 17, 2026 06:31

kiranchavala mentioned this pull request Jul 14, 2026
Unable to clone a network offering #13610
Closed

Uh oh!

Conversation

Pearl1594 commented Dec 31, 2025• edited by sureshanaparti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Dec 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Jan 19, 2026

Uh oh!

DaanHooglandJan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAIFeb 8, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CopilotAIFeb 8, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 8, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pearl1594 commented Feb 26, 2026

Uh oh!

blueorangutan commented Feb 26, 2026

Uh oh!

blueorangutan commented Feb 26, 2026

Uh oh!

Pearl1594 commented Feb 26, 2026

Uh oh!

blueorangutan commented Feb 26, 2026

Uh oh!

blueorangutan commented Feb 26, 2026

Uh oh!

kiranchavala commented Feb 27, 2026

Uh oh!

blueorangutan commented Feb 27, 2026

Uh oh!

sonarqubecloudBot commented Feb 27, 2026

Quality Gate failed

Uh oh!

blueorangutan commented Feb 27, 2026

Uh oh!

kiranchavala commented Mar 4, 2026

Uh oh!

blueorangutan commented Mar 4, 2026

Uh oh!

blueorangutan commented Mar 4, 2026

Uh oh!

kiranchavala commented Mar 5, 2026

Uh oh!

blueorangutan commented Mar 5, 2026

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Pearl1594 commented Dec 31, 2025•
edited by sureshanaparti
Loading

codecovBot commented Dec 31, 2025•
edited
Loading

Pearl1594 commented Mar 5, 2026•
edited
Loading