CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR enhances the existing CLVM implementation which was based on the deprecated CLVM technology which was based on corosync/pacemaker. With RHEL 7 having reached EOL, CLVM seems to be broken. CLVM supports RAW volumes on LVM , where as CLVM_NG support QCOW2 on LVM.

Further details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modernized+CLVM%3A+Enhancements+and+CLVM_NG+support

NOTE: On testing - it was identified that incremental snapshots for clvm-ng do not work as expected. As of now it's been removed from scope. So, CLVM and CLVM_NG would only support full snapshots.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (d3e1976) HEAD (df61d6f)
unittests 1 0

Additional details and impacted files

@@ Coverage Diff @@## main #12617 +/- ##
=============================================
- Coverage 17.90% 3.68% -14.23% 
=============================================
Files 5938 454 -5484 Lines 532864 38798 -494066 Branches 65192 7151 -58041 =============================================
- Hits 95392 1428 -93964 + Misses 426793 37183 -389610 + Partials 10679 187 -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 42.50310% with 1392 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.88%. Comparing base (6bc83a3) to head (04af974).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...oud/hypervisor/kvm/storage/ClvmStorageAdaptor.java	38.10%	421 Missing and 16 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	40.60%	109 Missing and 8 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	30.40%	102 Missing and 1 partial ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	13.20%	92 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	21.69%	81 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	28.57%	61 Missing and 4 partials ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java	38.63%	48 Missing and 6 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	16.39%	51 Missing ⚠️
...tack/storage/endpoint/DefaultEndPointSelector.java	56.63%	32 Missing and 17 partials ⚠️
...n/java/com/cloud/storage/clvm/ClvmPoolManager.java	77.10%	25 Missing and 24 partials ⚠️
... and 31 more

Additional details and impacted files

@@ Coverage Diff @@## main #12617 +/- ##
============================================
+ Coverage 18.75% 18.88% +0.12% - Complexity 17966 18223 +257 
============================================
Files 6160 6173 +13 Lines 552578 555086 +2508 Branches 67348 67754 +406 ============================================
+ Hits 103660 104850 +1190 - Misses 437512 438718 +1206 - Partials 11406 11518 +112

Flag	Coverage Δ
uitests	`3.53% <ø> (-0.01%)`	⬇️
unittests	`20.08% <42.50%> (+0.13%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

NuxRo

LGTM

…ioning factor isnt used for clvm pools - so set it to 1 and prevented display of provisioning type for clvm

Pearl1594 · 2026-06-12T15:58:17Z

@blueorangutan package

blueorangutan · 2026-06-12T16:00:13Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-12T16:45:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18241

Pearl1594 · 2026-06-12T17:10:24Z

@blueorangutan test

blueorangutan · 2026-06-12T17:12:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-06-13T08:07:42Z

[SF] Trillian test result (tid-16300)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50741 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16300-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594 · 2026-06-14T00:17:48Z

@blueorangutan package

blueorangutan · 2026-06-14T00:20:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-14T01:03:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18251

Pearl1594 · 2026-06-14T01:14:56Z

@blueorangutan test

blueorangutan · 2026-06-14T01:16:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-06-14T01:18:03Z

[SF] Trillian Build Failed (tid-16305)

Pearl1594 · 2026-06-14T04:12:37Z

@blueorangutan package

blueorangutan · 2026-06-14T04:14:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2026-06-14T04:39:38Z

Quality Gate failed

Failed conditions
1 Security Hotspot
32.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

blueorangutan · 2026-06-14T04:52:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18254

Pearl1594 · 2026-06-14T04:58:03Z

@blueorangutan test

blueorangutan · 2026-06-14T05:00:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-06-14T19:50:12Z

[SF] Trillian test result (tid-16306)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50471 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16306-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborgBot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes
9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4bCompare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …
96edadc
…of running vm

remove snap vol restriction for sunning vms
f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026
View reviewed changes

Comment thread...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6fCompare February 17, 2026 15:04

refactor clvm code
43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384Compare February 17, 2026 15:16

boring-cyborgBot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration
c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7edCompare February 17, 2026 22:54

add support for migrating lvm lock
4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly
190b201

made necessary changes to allow migration of lock and deletion of det…
8a7e48a
…ached volumes

NuxRo approved these changes Jun 12, 2026
View reviewed changes

allow storage browser to list lv in clvm, fix clvm shrink, overprovis…
419bf31
…ioning factor isnt used for clvm pools - so set it to 1 and prevented display of provisioning type for clvm

Pearl1594 force-pushed the clvm-enhancements branch from 124501d to 419bf31Compare June 12, 2026 15:35

github-actionsBot mentioned this pull request Jun 12, 2026
[repo-status] Daily Status Report — June 12, 2026 #13413
Closed

github-actionsBot mentioned this pull request Jun 13, 2026
[repo-status] Daily Status Report — June 13, 2026 #13416
Closed

no need to have locktransfercommand to execute in sequence
ae98107

increase lv cmd timeouts to consider cluster load
04af974

harikrishna-patnala marked this pull request as ready for review June 16, 2026 10:43

harikrishna-patnala merged commit ce9793c into mainJun 16, 2026
66 of 68 checks passed

harikrishna-patnala deleted the clvm-enhancements branch June 16, 2026 10:46

github-actionsBot mentioned this pull request Jun 16, 2026
[repo-status] Daily Status Report — June 16, 2026 #13435
Closed

Uh oh!

Conversation

Pearl1594 commented Feb 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Feb 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

Uh oh!

codecovBot commented Feb 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Jun 12, 2026

Uh oh!

blueorangutan commented Jun 12, 2026

Uh oh!

blueorangutan commented Jun 12, 2026

Uh oh!

Pearl1594 commented Jun 12, 2026

Uh oh!

blueorangutan commented Jun 12, 2026

Uh oh!

blueorangutan commented Jun 13, 2026

Uh oh!

Pearl1594 commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

Pearl1594 commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

Pearl1594 commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

sonarqubecloudBot commented Jun 14, 2026

Quality Gate failed

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

Pearl1594 commented Jun 14, 2026

Uh oh!

blueorangutan commented Jun 14, 2026

Uh oh!

Pearl1594 commented Feb 9, 2026•
edited
Loading

codecovBot commented Feb 9, 2026•
edited
Loading

codecovBot commented Feb 17, 2026•
edited
Loading