Fix NPE in NASBackupProvider when no running KVM host is available by jmsperu · Pull Request #12805 · apache/cloudstack

jmsperu · 2026-03-12T18:52:31Z

Rebased onto 4.22 as requested (previously #12680).

ResourceManager.findOneRandomRunningHostByHypervisor() can return null when no KVM host in the zone has status=Up (e.g. during management server startup, brief agent disconnections, or host state transitions).

NASBackupProvider.syncBackupStorageStats() and deleteBackup() call host.getId() without a null check, causing a NullPointerException that crashes the entire BackupSyncTask background job every sync interval.

This adds null checks in both methods:

syncBackupStorageStats: log a warning and return early
deleteBackup: throw CloudRuntimeException with a descriptive message

ResourceManager.findOneRandomRunningHostByHypervisor() can return null when no KVM host in the zone has status=Up (e.g. during management server startup, brief agent disconnections, or host state transitions). NASBackupProvider.syncBackupStorageStats() and deleteBackup() call host.getId() without a null check, causing a NullPointerException that crashes the entire BackupSyncTask background job every sync interval. This adds null checks in both methods: - syncBackupStorageStats: log a warning and return early - deleteBackup: throw CloudRuntimeException with a descriptive message

DaanHoogland · 2026-03-12T18:58:08Z

@blueorangutan package

blueorangutan · 2026-03-12T19:00:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-03-12T19:06:46Z

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (27bce46) to head (b3cb72f).
⚠️ Report is 12 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/NASBackupProvider.java	0.00%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.22 #12805 +/- ##
============================================
- Coverage 17.61% 17.60% -0.01% - Complexity 15662 15674 +12 
============================================
Files 5917 5917 Lines 531415 531606 +191 Branches 64973 64996 +23 ============================================
+ Hits 93588 93601 +13 - Misses 427271 427446 +175 - Partials 10556 10559 +3

Flag	Coverage Δ
uitests	`3.70% <ø> (-0.01%)`	⬇️
unittests	`18.67% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-03-12T19:21:11Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17121

DaanHoogland · 2026-03-12T20:31:32Z

@jmsperu , probably due to the rebase:

20:18:12 [ERROR] /jenkins/workspace/acs-centos8-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.22.1.0-SNAPSHOT/plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:[558,12] error: cannot find symbol
20:18:12 symbol: variable CollectionUtils
20:18:12 location: class NASBackupProvider

seems an import is missing.

jmsperu · 2026-03-18T19:22:28Z

Good catch @DaanHoogland, the CollectionUtils import was dropped during the rebase. Fixed now — should build cleanly.

DaanHoogland · 2026-03-19T10:57:49Z

@blueorangutan package

blueorangutan · 2026-03-19T11:00:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-19T12:47:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17198

DaanHoogland · 2026-03-19T15:38:11Z

@blueorangutan test

blueorangutan · 2026-03-19T15:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copilot

Pull request overview

Fixes a crash in the NAS backup provider’s background sync/deletion flows when no running KVM host is available in a zone (i.e., ResourceManager.findOneRandomRunningHostByHypervisor(...) returns null), preventing BackupSyncTask from dying due to NullPointerException.

Changes:

Add a null-host check in deleteBackup() and fail with a descriptive CloudRuntimeException.
Add early returns in syncBackupStorageStats() when there are no repositories and when no running KVM host can be found (with a warning log).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+ if (host == null) {
+ throw new CloudRuntimeException(String.format("Unable to find a running KVM host in zone %d to delete backup %s", backup.getZoneId(), backup.getUuid()));
+ }


 final Host host = resourceManager.findOneRandomRunningHostByHypervisor(Hypervisor.HypervisorType.KVM, zoneId);
+ if (host == null) {
+ logger.warn("Unable to find a running KVM host in zone {} to sync backup storage stats", zoneId);
+ return;
+ }


blueorangutan · 2026-03-20T12:06:11Z

[SF] Trillian test result (tid-15701)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 70450 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12805-t15701-kvm-ol8.zip
Smoke tests completed. 141 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	0.00	test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type	`Failure`	0.00	test_kubernetes_clusters.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
test_02_purge_expunged_api_vm_end_date	`Error`	3.21	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	2.02	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	2.13	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	1.50	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	361.51	test_purge_expunged_vms.py
test_CRUD_operations_userdata	`Error`	1523.56	test_register_userdata.py
test_deploy_vm_with_registered_userdata	`Error`	7.95	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	10.00	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	10.46	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	10.10	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	9.14	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	8.74	test_register_userdata.py
test_user_userdata_crud	`Error`	8.99	test_register_userdata.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.29	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py

jmsperu · 2026-03-20T15:51:35Z

Thanks @DaanHoogland for driving the packaging and smoke tests. All builds green and the 8 test failures are pre-existing (Kubernetes, userdata, private gw ACL) — unrelated to this change.

Is there anything else needed to get this into 4.22.1?

jmsperu · 2026-03-26T21:03:17Z

@DaanHoogland @abh1sar Gentle ping — builds and tests are green. Is this ready to merge into 4.22?

sureshanaparti · 2026-03-27T05:25:42Z

@blueorangutan package

blueorangutan · 2026-03-27T05:28:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

abh1sar

Code LGTM

abh1sar · 2026-03-27T05:41:51Z

@DaanHoogland @abh1sar Gentle ping — builds and tests are green. Is this ready to merge into 4.22?

@jmsperu Please address the comment about import ordering. We'll get this merged after that.

blueorangutan · 2026-03-27T06:32:54Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17264

rajujith

LGTM
Tested

sureshanaparti · 2026-03-27T14:40:57Z

@blueorangutan package

blueorangutan · 2026-03-27T14:42:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-27T15:38:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17267

boring-cyborg · 2026-03-27T16:02:16Z

Awesome work, congrats on your first merged pull request!

boring-cyborgBot added the component:backup label Mar 12, 2026

jmsperu mentioned this pull request Mar 12, 2026
Fix NPE in NASBackupProvider when no running KVM host is available #12680
Closed
1 task

Add missing CollectionUtils import after 4.22 rebase
1481586

DaanHoogland added this to the 4.22.1 milestone Mar 19, 2026

DaanHoogland requested review from abh1sar and Copilot March 19, 2026 15:37

CopilotAI reviewed Mar 19, 2026
View reviewed changes

DaanHoogland added this to Apache CloudStack 4.22.1 Mar 25, 2026

github-project-automationBot moved this to Todo in Apache CloudStack 4.22.1 Mar 25, 2026

DaanHoogland moved this from Todo to In Progress in Apache CloudStack 4.22.1 Mar 25, 2026

jmsperu mentioned this pull request Mar 26, 2026
[RFC] Incremental NAS Backup Support for KVM Hypervisor #12899
Closed

sureshanaparti requested a review from rajujith March 27, 2026 05:24

sureshanaparti added status:needs-review status:needs-testing labels Mar 27, 2026

abh1sar approved these changes Mar 27, 2026
View reviewed changes

rajujith approved these changes Mar 27, 2026
View reviewed changes

rajujith removed the status:needs-testing label Mar 27, 2026

Fix import ordering: move CollectionUtils to org.apache group
b3cb72f

sureshanaparti removed the status:needs-review label Mar 27, 2026

sureshanaparti merged commit 6ca6aa1 into apache:4.22Mar 27, 2026
24 of 26 checks passed

github-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.22.1 Mar 27, 2026

abh1sar mentioned this pull request Apr 7, 2026
NullPointerException in NASBackupProvider.syncBackupStorageStats when no KVM host is in "Up" state #12679
Closed

Uh oh!

Conversation

jmsperu commented Mar 12, 2026

Uh oh!

DaanHoogland commented Mar 12, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

codecovBot commented Mar 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

DaanHoogland commented Mar 12, 2026

Uh oh!

jmsperu commented Mar 18, 2026

Uh oh!

DaanHoogland commented Mar 19, 2026

Uh oh!

blueorangutan commented Mar 19, 2026

Uh oh!

blueorangutan commented Mar 19, 2026

Uh oh!

DaanHoogland commented Mar 19, 2026

Uh oh!

blueorangutan commented Mar 19, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

blueorangutan commented Mar 20, 2026

Uh oh!

jmsperu commented Mar 20, 2026

Uh oh!

jmsperu commented Mar 26, 2026

Uh oh!

sureshanaparti commented Mar 27, 2026

Uh oh!

blueorangutan commented Mar 27, 2026

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Mar 27, 2026

Uh oh!

blueorangutan commented Mar 27, 2026

Uh oh!

rajujith left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Mar 27, 2026

Uh oh!

blueorangutan commented Mar 27, 2026

Uh oh!

blueorangutan commented Mar 27, 2026

Uh oh!

Uh oh!

boring-cyborgBot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented Mar 12, 2026•
edited
Loading