Fix NPE with ApiKeyPair during listApis call (from cmk) by sureshanaparti · Pull Request #13149 · apache/cloudstack

sureshanaparti · 2026-05-12T11:09:17Z

Description

This PR fixes NPE issue with ApiKeyPair during listApis call (from cmk).

(localcloud) 🐱 > sync
[debug] ExecLine line:sync
[debug] ExecCmd args: sync
[debug] NewAPIRequest API request URL:http://10.0.33.254:8080/client/api?apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=listApis&expires=2026-05-12T10%3A52%3A21Z&listall=true&response=json&signatureversion=3
[debug] Using HTTP POST for the request: http://10.0.33.254:8080/client/api
⣷ 😸 discovering APIs, please wait...[debug] NewAPIRequest response status code:401
[debug] Login POST URL:http://10.0.33.254:8080/client/apimap[command:[login] domain:[/] password:[password] response:[json] username:[admin]]
[debug] Login POST response status code:200
[debug] Login response body:{"loginresponse":{"username":"admin","userid":"0058d371-493c-11f1-8b72-1e00f0000291","domainid":"a728ab4b-493b-11f1-8b72-1e00f0000291","timeout":1800,"account":"admin","firstname":"admin","lastname":"cloud","type":"1","timezone":"UTC","timezoneoffset":"0.0","registered":"false","sessionkey":"WjoANDlHyxTdO9Aa_LXOa4rei34","is2faenabled":"false","is2faverified":"true","issuerfor2fa":"CloudStack","managementserverid":"c5a6dd86-fead-4397-8cf5-55250df33c24"}}
[debug] Login sessionkey:WjoANDlHyxTdO9Aa_LXOa4rei34
[debug] Checking if 2FA is enabled and verified for the user map[account:admin domainid:a728ab4b-493b-11f1-8b72-1e00f0000291 firstname:admin is2faenabled:false is2faverified:true issuerfor2fa:CloudStack lastname:cloud managementserverid:c5a6dd86-fead-4397-8cf5-55250df33c24 registered:false sessionkey:WjoANDlHyxTdO9Aa_LXOa4rei34 timeout:1800 timezone:UTC timezoneoffset:0.0 type:1 userid:0058d371-493c-11f1-8b72-1e00f0000291 username:admin]
[debug] 2FA is not enabled for the user, skipping 2FA validation
[debug] NewAPIRequest API request URL:http://10.0.33.254:8080/client/api?apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=listApis&expires=2026-05-12T10%3A52%3A21Z&listall=true&response=json&sessionkey=WjoANDlHyxTdO9Aa_LXOa4rei34&signature=9kJbbP3gtVaU2N6XZzKPmYRDYFE%3D&signatureversion=3
[debug] Using HTTP POST for the request: http://10.0.33.254:8080/client/api
[debug] NewAPIRequest response body:{"listapisresponse":{"uuidList":[],"errorcode":530,"cserrorcode":9999,"errortext":"Cannot invoke \"org.apache.cloudstack.acl.apikeypair.ApiKeyPair.getAccountId()\" because \"apiKeyPair\" is null"}}
🙈 Error: (HTTP 530, error code 9999) Cannot invoke "org.apache.cloudstack.acl.apikeypair.ApiKeyPair.getAccountId()" because "apiKeyPair" is null
(localcloud) 🐱 >

2026-05-12 10:37:22,051 DEBUG [c.c.a.ApiServlet] (qtp253011924-24:[ctx-313ce9a0]) (logid:d4f7907a) ===START=== 10.0.33.254 -- POST apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q command=listApis expires=2026-05-12T10:52:21Z listall=true response=json sessionkey=WjoANDlHyxTdO9Aa_LXOa4rei34 signature=9kJbbP3gtVaU2N6XZzKPmYRDYFE= signatureversion=3 2026-05-12 10:37:22,054 DEBUG [c.c.a.ApiServer] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"00583461-493c-11f1-8b72-1e00f0000291"}]' is allowed to perform API calls: 0.0.0.0/0,::/0
2026-05-12 10:37:22,055 INFO [o.a.c.a.DynamicRoleBasedAPIAccessChecker] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) Account [Account [{"accountName":"admin","id":2,"uuid":"00583461-493c-11f1-8b72-1e00f0000291"}]] is Root Admin and there aren't any API key pair permissions involved, thus, all APIs are allowed.
2026-05-12 10:37:22,055 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2026-05-12 10:37:22,055 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) API rate limiting is disabled. We will not use ApiRateLimitService.
2026-05-12 10:37:22,056 WARN [c.c.a.d.ParamGenericValidationWorker] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) Received unknown parameters for command listApis. Unknown parameters : listall
2026-05-12 10:37:22,059 ERROR [c.c.a.ApiServer] (qtp253011924-24:[ctx-313ce9a0, ctx-e535ff0f]) (logid:d4f7907a) unhandled exception executing api command: [Ljava.lang.String;@1e71e72d java.lang.NullPointerException: Cannot invoke "org.apache.cloudstack.acl.apikeypair.ApiKeyPair.getAccountId()" because "apiKeyPair" is null
at com.cloud.user.AccountManagerImpl.getAllKeypairPermissions(AccountManagerImpl.java:3585)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at jdk.proxy3/jdk.proxy3.$Proxy104.getAllKeypairPermissions(Unknown Source)
at org.apache.cloudstack.discovery.ApiDiscoveryServiceImpl.listApisForKeyPair(ApiDiscoveryServiceImpl.java:357)
at org.apache.cloudstack.discovery.ApiDiscoveryServiceImpl.listApis(ApiDiscoveryServiceImpl.java:283)
at org.apache.cloudstack.api.command.user.discovery.ListApisCmd.execute(ListApisCmd.java:55)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:173)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:883)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:697)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:414)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:191)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-05-12T11:12:35Z

@KlausDornsbach can you review this.

sureshanaparti · 2026-05-12T11:13:19Z

@blueorangutan package

blueorangutan · 2026-05-12T11:14:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-05-12T11:18:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.46%. Comparing base (3c1f031) to head (5d8d7ef).
⚠️ Report is 173 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3c1f031) and HEAD (5d8d7ef). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (3c1f031) HEAD (5d8d7ef)
unittests 1 0

Additional details and impacted files

@@ Coverage Diff @@## main #13149 +/- ##
=============================================
- Coverage 18.08% 3.46% -14.63% 
=============================================
Files 6037 479 -5558 Lines 542611 41162 -501449 Branches 66433 7793 -58640 =============================================
- Hits 98136 1426 -96710 + Misses 433448 39543 -393905 + Partials 11027 193 -10834

Flag	Coverage Δ
uitests	`3.46% <ø> (-0.06%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-05-12T11:58:57Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17820

winterhazel · 2026-05-12T13:22:52Z

@KlausDornsbach can you review this.

@sureshanaparti, @KlausDornsbach is not active in the community anymore. I am asking @bernardodemarco to review this, as he was responsible for maintaning the keypairs PR.

bernardodemarco · 2026-05-12T13:24:44Z

@sureshanaparti, thanks for the PR! I'll try to review and test it during this week.

bernardodemarco

tested locally, LGTM

sureshanaparti · 2026-05-18T16:58:37Z

@blueorangutan test

sureshanaparti · 2026-05-18T17:06:08Z

@blueorangutan test

blueorangutan · 2026-05-18T17:08:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-19T17:13:07Z

[SF] Trillian test result (tid-16105)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 83766 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13149-t16105-kvm-ol8.zip
Smoke tests completed. 146 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_vm_backup_create_vm_from_backup	`Failure`	607.91	test_backup_recovery_nas.py
test_vm_backup_lifecycle	`Error`	0.09	test_backup_recovery_nas.py
ContextSuite context=TestSharedFSLifecycle>:setup	`Error`	0.00	test_sharedfs_lifecycle.py
test_10_attachAndDetach_iso	`Failure`	607.09	test_vm_life_cycle.py
test_01_create_vm_snapshots	`Failure`	606.86	test_vm_snapshots.py
test_02_revert_vm_snapshots	`Failure`	600.77	test_vm_snapshots.py
test_03_delete_vm_snapshots	`Failure`	0.02	test_vm_snapshots.py
test_01_create_volume	`Failure`	612.29	test_volumes.py
test_01_root_volume_encryption	`Failure`	709.39	test_volumes.py
test_02_data_volume_encryption	`Failure`	651.09	test_volumes.py
test_03_root_and_data_volume_encryption	`Failure`	664.59	test_volumes.py
test_02_attach_volume	`Failure`	1275.67	test_volumes.py
test_02_attach_volume	`Failure`	1275.68	test_volumes.py
test_03_download_attached_volume	`Failure`	666.82	test_volumes.py
test_04_delete_attached_volume	`Failure`	665.63	test_volumes.py
test_05_detach_volume	`Failure`	753.74	test_volumes.py
test_06_download_detached_volume	`Failure`	851.12	test_volumes.py
test_07_resize_fail	`Failure`	661.72	test_volumes.py
test_08_resize_volume	`Failure`	670.15	test_volumes.py
test_09_delete_detached_volume	`Failure`	670.09	test_volumes.py
test_10_list_volumes	`Failure`	660.42	test_volumes.py
test_11_attach_volume_with_unstarted_vm	`Failure`	761.83	test_volumes.py
test_12_resize_volume_with_only_size_parameter	`Failure`	667.04	test_volumes.py
test_13_migrate_volume_and_change_offering	`Failure`	802.31	test_volumes.py
test_14_delete_volume_delete_protection	`Failure`	664.04	test_volumes.py

github-actions · 2026-05-19T21:12:24Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

kiranchavala

@sureshanaparti

Getting the following error on ol8

(localcloud) 🐱 > sync
panic: interface conversion: interface {} is nil, not []interface {}
goroutine 1 [running]:
github.com/apache/cloudstack-cloudmonkey/config.(*Config).UpdateCache(0xc0000e0120?, 0xc0013b0390)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/config/cache.go:115 +0x1338
github.com/apache/cloudstack-cloudmonkey/cmd.init.4.func1(0xc0011ab740)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cmd/sync.go:35 +0xd0
github.com/apache/cloudstack-cloudmonkey/cli.ExecCmd({0xc001330d30, 0x1, 0x1}, 0x0)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/exec.go:64 +0x1bb
github.com/apache/cloudstack-cloudmonkey/cli.ExecLine({0xc00133d420, 0x4})
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/exec.go:51 +0x21b
github.com/apache/cloudstack-cloudmonkey/cli.ExecPrompt()
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/prompt.go:84 +0x26e
main.main()
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cmk.go:101 +0x7f1

sureshanaparti · 2026-05-20T09:16:55Z

@sureshanaparti

Getting the following error on ol8

(localcloud) 🐱 > sync
panic: interface conversion: interface {} is nil, not []interface {}
goroutine 1 [running]:
github.com/apache/cloudstack-cloudmonkey/config.(*Config).UpdateCache(0xc0000e0120?, 0xc0013b0390)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/config/cache.go:115 +0x1338
github.com/apache/cloudstack-cloudmonkey/cmd.init.4.func1(0xc0011ab740)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cmd/sync.go:35 +0xd0
github.com/apache/cloudstack-cloudmonkey/cli.ExecCmd({0xc001330d30, 0x1, 0x1}, 0x0)
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/exec.go:64 +0x1bb
github.com/apache/cloudstack-cloudmonkey/cli.ExecLine({0xc00133d420, 0x4})
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/exec.go:51 +0x21b
github.com/apache/cloudstack-cloudmonkey/cli.ExecPrompt()
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cli/prompt.go:84 +0x26e
main.main()
/home/shwstppr/lab/shapeblue/cloudstack-cloudmonkey/cmk.go:101 +0x7f1

@kiranchavala no user with that api key, re-check with valid key.

2026-05-20 08:35:12,286 DEBUG [c.c.a.ApiServer] (qtp253011924-21:[ctx-c42ab8fc, ctx-95d85cb5]) (logid:3f28955f) apiKey does not map to a valid user -- ignoring request, apiKey: LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q
mysql> SELECT user_id, api_key, created FROM cloud.api_keypair;
+---------+----------------------------------------------------------------------------------------+---------------------+
| user_id | api_key | created |
+---------+----------------------------------------------------------------------------------------+---------------------+
| 3 | DgNbW4qqDYY9dTTxOW0AV6qI2dDvXtwlbJZtfGSDjfP5zhwuDx6FwXAjT6ARMAmvYxfEIlbCAGpfU1Rx5en6kg | 2026-05-19 11:23:47 |
+---------+----------------------------------------------------------------------------------------+---------------------+
1 row in set (0.00 sec)

cmk also need a fix to address this error: (created issue: apache/cloudstack-cloudmonkey#211)

[debug] Using HTTP POST for the request: http://10.0.33.110:8080/client/api
[debug] NewAPIRequest response body:{"listapisresponse":{}}
panic: interface conversion: interface {} is nil, not []interface {}

sureshanaparti · 2026-05-20T09:55:23Z

@blueorangutan package

blueorangutan · 2026-05-20T09:56:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-20T10:45:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17930

DaanHoogland · 2026-05-21T12:44:25Z

@blueorangutan test

blueorangutan · 2026-05-21T12:46:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland

clgtm

winterhazel · 2026-06-19T11:57:50Z

@sureshanaparti could you have a look at #13149 (comment)?

@sureshanaparti ping. It would be nice to include this fix in 4.23

sureshanaparti · 2026-07-08T07:37:59Z

@blueorangutan package

Copilot

Pull request overview

This PR addresses a NullPointerException when listApis is called with an API key that does not resolve to an ApiKeyPair, by adding null-handling in API key pair lookup paths within AccountManagerImpl.

Changes:

Add null checks when resolving an accessing ApiKeyPair to prevent NPEs.
Handle missing ApiKeyPair results in permission-resolution logic and improve related logging.
Fix getUserByApiKey to avoid dereferencing a null key pair.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sureshanaparti · 2026-07-08T09:20:15Z

@blueorangutan package

blueorangutan · 2026-07-08T09:22:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

bernardodemarco · 2026-07-08T12:25:46Z

 ApiKeyPair accessingKeyPair = apiKeyPairService.findByApiKey(accessingApiKey);
- if (userId == accessingKeyPair.getUserId()) {
+ if (accessingKeyPair != null && userId == accessingKeyPair.getUserId()) {
 keyPair = apiKeyPairService.findByApiKey(accessingApiKey);


As for this suggestion, we could apply it in this PR, if you're willing to, @sureshanaparti. But it is nitpicking IMO

bernardodemarco · 2026-07-08T12:26:52Z

+ } catch (Exception e) {
+ logger.info("Error accessing API through session.", e);
 }


This Copilot suggestion does not make sense in the context of this method

+ if (apiKeyPair == null) {
+ logger.warn("Unable to find API key pair by API key.");
+ return new ArrayList<>();
+ }


bernardodemarco · 2026-07-08T12:27:28Z

 public List<RolePermissionEntity> getAllKeypairPermissions(String apiKey) {
 if (apiKey == null) {
 throw new InvalidParameterValueException("API key not present in the request's URL and, thus, unable to fetch API key rules.");
 }
 ApiKeyPair apiKeyPair = keyPairManager.findByApiKey(apiKey);


This does not need to be applied in this PR

blueorangutan · 2026-07-08T09:53:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18495

weizhouapache · 2026-07-08T10:59:00Z

 if (accessingApiKey != null) {
 ApiKeyPair accessingKeyPair = apiKeyPairService.findByApiKey(accessingApiKey);
- if (userId == accessingKeyPair.getUserId()) {
+ if (accessingKeyPair != null && userId == accessingKeyPair.getUserId()) {


It might be better to throw an exception here, if apikeypair is not found
similar to change with getAllKeypairPermissions method

Yes, it would be nice

Suggested change
if (accessingKeyPair!= null && userId == accessingKeyPair.getUserId()) {
if (accessingKeyPair== null) {
thrownewCloudRuntimeException(String.format("Unable to find pair of API key [%s].", accessingApiKey));
}
if (userId == accessingKeyPair.getUserId()) {
@sureshanaparti it makes more sense to throw an exception here. Although unlikely, the way this if is structured right now can result in the key of user A of account X leaking when the caller is using a key to access user B of account X if accessingKeyPair is null.

weizhouapache · 2026-07-08T10:59:18Z

 }
 ApiKeyPair apiKeyPair = keyPairManager.findByApiKey(apiKey);
+ if (apiKeyPair == null) {
+ logger.warn("Unable to find API key pair by API key.");


throw an exception ?

@sureshanaparti I would throw a CloudRuntimeException here as well. Even though this does not represent a security concern, returning an empty list here will allow the API call to finish "successfully", hiding an issue.

weizhouapache · 2026-07-08T11:12:23Z

@sureshanaparti
can you share the steps to reproduce the issue ? thanks

bernardodemarco · 2026-07-08T12:45:09Z

@winterhazel, before merging this, could you review it again, please?

weizhouapache · 2026-07-10T11:53:24Z

@winterhazel @bernardodemarco @sureshanaparti
is this a critical issue for 4.23 ?

winterhazel · 2026-07-10T18:29:31Z

@winterhazel @bernardodemarco @sureshanaparti is this a critical issue for 4.23 ?

@weizhouapache I don't think so, although it would be nice to fix it for 4.23. I was only able to reproduce it by configuring valid username + password credentials for a profile in CMK, alongside an invalid API key.

(test) 🐱 >set apikey WpsOEhOzpJHDlo-RM7yezDdj5I_0o10GsqwCa9SF8sW8VeGHXLUY0X2THwOHNR7mVWup02SpS6-7JdCJrGYtNw
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
(test) 🐱 >set secretkey GRiS1DJ7ToI1r8bJ5VDdzCAx_KSrnfcr3GZeMLEm0bNdTSSOe852_wHW74YdER_7mbShn09D-E5NoYxejQ6t_Q
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
(test) 🐱 > sync
Discovered 889 APIs
(test) 🐱 >set apikey WpsOEhOzpJHDlo-RM7yezDdj5I_0o10GsqwCa9SF8sW8VeGHXLUY0X2THwOHNR7mVWup02SpS6-7JdCJrGYtN
(test) 🐱 > sync
🙈 Error: failed to authenticate, please check the credentials
(test) 🐱 >set username admin
(test) 🐱 > sync
🙈 Error: failed to authenticate, please check the credentials
(test) 🐱 >set password password
(test) 🐱 > sync
🙈 Error: (HTTP 530, error code 9999) Cannot invoke "org.apache.cloudstack.acl.apikeypair.ApiKeyPair.getAccountId()" because "apiKeyPair" is null

Using either (1) only username + password, (2) only API key + secret key, (3) username + password + valid API key does not result in any exceptions.

weizhouapache · 2026-07-10T18:37:55Z

@winterhazel @bernardodemarco @sureshanaparti is this a critical issue for 4.23 ?
@weizhouapache I don't think so, although it would be nice to fix it for 4.23. I was only able to reproduce it by configuring valid username + password credentials for a profile in CMK, alongside an invalid API key.
(test) 🐱 >set apikey WpsOEhOzpJHDlo-RM7yezDdj5I_0o10GsqwCa9SF8sW8VeGHXLUY0X2THwOHNR7mVWup02SpS6-7JdCJrGYtNw
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
(test) 🐱 >set secretkey GRiS1DJ7ToI1r8bJ5VDdzCAx_KSrnfcr3GZeMLEm0bNdTSSOe852_wHW74YdER_7mbShn09D-E5NoYxejQ6t_Q
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
(test) 🐱 > sync
Discovered 889 APIs
(test) 🐱 >set apikey WpsOEhOzpJHDlo-RM7yezDdj5I_0o10GsqwCa9SF8sW8VeGHXLUY0X2THwOHNR7mVWup02SpS6-7JdCJrGYtN
(test) 🐱 > sync
🙈 Error: failed to authenticate, please check the credentials
(test) 🐱 >set username admin
(test) 🐱 > sync
🙈 Error: failed to authenticate, please check the credentials
(test) 🐱 >set password password
(test) 🐱 > sync
🙈 Error: (HTTP 530, error code 9999) Cannot invoke "org.apache.cloudstack.acl.apikeypair.ApiKeyPair.getAccountId()" because "apiKeyPair" is null
Using either (1) only username + password, (2) only API key + secret key, (3) username + password + valid API key does not result in any exceptions.

cool, thanks
I actually tried these 3 cases but was not able to reproduce the issue.

Since this is not a critical issue, 4.23 RC will not be blocked by it

DaanHoogland · 2026-07-20T09:03:03Z

@bernardodemarco , you are marked as requesting changes, can you check?

DaanHoogland · 2026-07-20T09:03:42Z

@weizhouapache should we merge for rc2? (assuming we get one)

bernardodemarco · 2026-07-20T11:17:41Z

@bernardodemarco , you are marked as requesting changes, can you check?

Hello, @DaanHoogland

Yes, @winterhazel and I have already reviewed the most recent changes of the PR. We are awaiting for updates to review again

winterhazel · 2026-07-20T12:25:30Z

@weizhouapache should we merge for rc2? (assuming we get one)

@DaanHoogland assuming that it is ready for merge before the creation of RC2, yes. It is not a blocker issue though.

@sureshanaparti are you able to work on the requested changes this week?

weizhouapache added this to the 4.23.0 milestone May 12, 2026

winterhazel requested a review from bernardodemarco May 12, 2026 13:23

bernardodemarco approved these changes May 14, 2026
View reviewed changes

sureshanaparti requested review from DaanHoogland and kiranchavala May 18, 2026 16:58

github-actionsBot added the status:has-conflicts label May 19, 2026

kiranchavala reviewed May 20, 2026
View reviewed changes

Fix NPE with ApiKeyPair during listApis call (from cmk)
aa6f16b

sureshanaparti force-pushed the api-keypair-npe-fix branch from 492b5d1 to aa6f16bCompare May 20, 2026 09:54

github-actionsBot removed the status:has-conflicts label May 20, 2026

DaanHoogland approved these changes May 21, 2026
View reviewed changes

winterhazel added the status:waiting-for-smoketest-results label May 22, 2026

winterhazel added status:waiting-for-author and removed status:ready-for-merge status:waiting-for-smoketest-results labels Jun 8, 2026

Return FALSE when no key pair for the api key
17fca41

CopilotAI review requested due to automatic review settings July 8, 2026 07:37

Copilotstarted reviewing on behalf of sureshanaparti July 8, 2026 07:37 View session

sureshanaparti removed the status:waiting-for-author label Jul 8, 2026

sureshanaparti requested a review from bernardodemarco July 8, 2026 07:38

CopilotAI reviewed Jul 8, 2026
View reviewed changes

Comment threadserver/src/main/java/com/cloud/user/AccountManagerImpl.java
Comment threadserver/src/main/java/com/cloud/user/AccountManagerImpl.java
Comment threadserver/src/main/java/com/cloud/user/AccountManagerImpl.java
Comment threadserver/src/main/java/com/cloud/user/AccountManagerImpl.java

addressed review comments
5d8d7ef

CopilotAI review requested due to automatic review settings July 8, 2026 09:19

Copilotstarted reviewing on behalf of sureshanaparti July 8, 2026 09:20 View session

CopilotAI reviewed Jul 8, 2026
View reviewed changes

weizhouapache reviewed Jul 8, 2026
View reviewed changes

bernardodemarco requested a review from winterhazel July 8, 2026 12:45

winterhazel added the status:waiting-for-author label Jul 20, 2026

-if (accessingKeyPair!= null && userId == accessingKeyPair.getUserId()) {
+if (accessingKeyPair== null) {
+thrownewCloudRuntimeException(String.format("Unable to find pair of API key [%s].", accessingApiKey));
+ }
+if (userId == accessingKeyPair.getUserId()) {

Uh oh!

Conversation

sureshanaparti commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented May 12, 2026

Uh oh!

sureshanaparti commented May 12, 2026

Uh oh!

blueorangutan commented May 12, 2026

Uh oh!

codecovBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented May 12, 2026

Uh oh!

winterhazel commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernardodemarco commented May 12, 2026

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented May 18, 2026

Uh oh!

sureshanaparti commented May 18, 2026

Uh oh!

blueorangutan commented May 18, 2026

Uh oh!

blueorangutan commented May 19, 2026

Uh oh!

github-actionsBot commented May 19, 2026

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented May 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sureshanaparti commented May 20, 2026

Uh oh!

blueorangutan commented May 20, 2026

Uh oh!

blueorangutan commented May 20, 2026

Uh oh!

DaanHoogland commented May 21, 2026

Uh oh!

blueorangutan commented May 21, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

winterhazel commented Jun 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sureshanaparti commented Jul 8, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jul 8, 2026

Uh oh!

blueorangutan commented Jul 8, 2026

Uh oh!

CopilotAI left a comment

sureshanaparti commented May 12, 2026•
edited
Loading

codecovBot commented May 12, 2026•
edited
Loading

winterhazel commented May 12, 2026•
edited
Loading

sureshanaparti commented May 20, 2026•
edited
Loading

winterhazel commented Jun 19, 2026•
edited
Loading

weizhouapacheJul 8, 2026•
edited
Loading

winterhazelJul 9, 2026•
edited
Loading

winterhazel commented Jul 10, 2026•
edited
Loading

bernardodemarco commented Jul 20, 2026•
edited
Loading