Fix local upload from browser failing due to ssvm cert not trusted by abh1sar · Pull Request #13204 · apache/cloudstack

abh1sar · 2026-05-21T04:00:27Z

Description

This PR fixes#12490

UI Pre-check
Before initiating upload, have the UI make a test request to the SSVM and guide users to accept the certificate if needed.

Fixed Template, ISO and Volume upload.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Screen.recording.mov

How did you try to break this feature and the system with this change?

codecov · 2026-05-21T04:08:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (a7c2a05) to head (3bbe87e).
⚠️ Report is 2 commits behind head on 4.20.

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #13204 +/- ##
============================================
- Coverage 16.27% 16.26% -0.01% + Complexity 13440 13434 -6 
============================================
Files 5665 5666 +1 Lines 500555 500628 +73 Branches 60789 60797 +8 ============================================
- Hits 81445 81419 -26 - Misses 410004 410102 +98 - Partials 9106 9107 +1

Flag	Coverage Δ
uitests	`4.14% <ø> (-0.01%)`	⬇️
unittests	`17.11% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds a UI-side pre-check for SSVM reachability/certificate trust before starting “upload from local” flows, so browser-blocked requests (e.g., due to an expired/untrusted SSVM TLS cert) can be surfaced with user guidance instead of failing silently.

Changes:

Introduces an SSVM “certificate not trusted” warning state with actions to open the SSVM origin and retry.
Adds a lightweight fetch() probe before initiating template/ISO/volume uploads to detect browser-level connection/TLS failures.
Adds new i18n strings for the warning and retry actions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
ui/src/views/storage/UploadLocalVolume.vue	Adds SSVM probe + warning UI and refactors upload to use an `uploading` state.
ui/src/views/image/RegisterOrUploadTemplate.vue	Adds SSVM probe + warning UI for local template uploads, with retry flow.
ui/src/views/image/RegisterOrUploadIso.vue	Adds SSVM probe + warning UI for local ISO uploads, with retry flow.
ui/public/locales/en.json	Adds UI strings for the SSVM warning and retry actions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vishesh92

clgtm. didn't test.
IMO, it would be better if we can extract the common code out.

vishesh92 · 2026-05-21T06:12:48Z

@abh1sar please check the copilot's comments and see if they are valid.

abh1sar · 2026-05-21T12:39:53Z

Have extracted the code out and answered review comments

abh1sar · 2026-05-21T12:40:04Z

@blueorangutan package

blueorangutan · 2026-05-21T12:42:05Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

ui/src/views/image/RegisterOrUploadIso.vue:530

The file count guard shows an error when fileList.length > 1 but does not return, so the upload proceeds anyway. Return early after the notification to avoid attempting a multi-file upload.

 const { fileList } = this
if (this.fileList.length > 1) {
this.$notification.error({
message: this.$t('message.upload.iso.failed'),
description: this.$t('message.error.upload.iso.description'),
duration: 0
})
}

blueorangutan · 2026-05-21T13:39:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17961

abh1sar · 2026-05-22T03:35:31Z

@blueorangutan package

blueorangutan · 2026-05-22T03:36:06Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-22T04:32:32Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17977

abh1sar · 2026-05-22T05:36:36Z

@blueorangutan package

blueorangutan · 2026-05-22T05:38:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-22T05:38:55Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17980

vishesh92 · 2026-05-22T06:20:19Z

@blueorangutan package

blueorangutan · 2026-05-22T06:22:05Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-22T07:19:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17981

blueorangutan · 2026-05-22T09:19:24Z

[SF] Trillian Build Failed (tid-16160)

vishesh92

Tested the PR. Works as expected. One minor issue is the spacing between the buttons.

abh1sar · 2026-05-26T01:34:46Z

Tested the PR. Works as expected. One minor issue is the spacing between the buttons.

Thanks @vishesh92. Fixed it now

weizhouapache

code lgtm

vishesh92 · 2026-05-26T06:35:16Z

@blueorangutan package

blueorangutan · 2026-05-26T06:36:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-26T07:39:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18027

vishesh92

lgtm. tested and works as expected.

Fix local upload from browser
700f4e0

abh1sar requested a review from vishesh92 May 21, 2026 04:02

vishesh92 requested a review from Copilot May 21, 2026 05:59

Copilotstarted reviewing on behalf of vishesh92 May 21, 2026 05:59 View session

CopilotAI reviewed May 21, 2026
View reviewed changes

vishesh92 approved these changes May 21, 2026
View reviewed changes

vishesh92 linked an issue May 21, 2026 that may be closed by this pull request
Local template/ISO upload fails silently due to expired SSL certificate on SSVM #12490
Open

vishesh92 added the status:needs-testing label May 21, 2026

Address review comments
6bfe68a

boring-cyborgBot added the component:UI label May 21, 2026

Address review comments
b72cb96

abh1sar added the ready-for-testing label May 21, 2026

abh1sar requested a review from Copilot May 21, 2026 12:42

Copilotstarted reviewing on behalf of abh1sar May 21, 2026 12:42 View session

CopilotAI reviewed May 21, 2026
View reviewed changes

Address review comments
aa35a07

vishesh92 reviewed May 25, 2026
View reviewed changes

Fix margin between buttons
3bbe87e

weizhouapache approved these changes May 26, 2026
View reviewed changes

vishesh92 approved these changes May 26, 2026
View reviewed changes

vishesh92 merged commit ff9ee24 into apache:4.20May 26, 2026
24 of 26 checks passed

vishesh92 deleted the ssvm-upload branch May 26, 2026 07:57

github-actionsBot mentioned this pull request Jun 1, 2026
[repo-status] Daily Status Report — June 1, 2026 #13317
Closed

Uh oh!

Conversation

abh1sar commented May 21, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented May 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented May 21, 2026

Uh oh!

abh1sar commented May 21, 2026

Uh oh!

abh1sar commented May 21, 2026

Uh oh!

blueorangutan commented May 21, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented May 21, 2026

Uh oh!

abh1sar commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

abh1sar commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

vishesh92 commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented May 26, 2026

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented May 26, 2026

Uh oh!

codecovBot commented May 21, 2026•
edited
Loading