Don't allow assign VM to backup offering for VM with encrypted volumes

[sureshanaparti]

Description

This PR does't allow assign VM to backup offering for VM with encrypted volumes.

Fixes#13197

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Deploy VM with compute / disk offering with encrypted set to true.
• Create a backup offering.
• Assign backup offering to the VM above.

When tried to create backup without a backup offering assigned, it fails with "VM has not backup offering configured, cannot create backup"

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (21b2025) to head (3e0894d).
⚠️ Report is 70 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.22 #13229 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01% + Complexity 15792 15790 -2 
============================================
Files 5922 5922 Lines 533165 533170 +5 Branches 65208 65210 +2 ============================================
- Hits 94242 94223 -19 - Misses 428276 428301 +25 + Partials 10647 10646 -1 

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.74% <80.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18012

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-16177)

[kiranchavala]

@blueorangutan test

[blueorangutan]

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16238)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50447 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13229-t16238-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[abh1sar]

Move this to NasBackupProvider.java in backupProvider.assignVMToBackupOffering.

We want to disable backup for encrypted volume for just nas backup provider.

[abh1sar]

@sureshanaparti ^

[Damans227]

Nit: assignVMToBackupOffering is expected to throw here, so the verify(vmInstanceDao, times(1)).findById(vmId) call right after it is unreachable, dead code.