Skip to content

docs: note MariaDB support in README - #13238

Merged
winterhazel merged 2 commits into
apache:mainfrom
robertsilen:docs/mariadb-readme
May 27, 2026
Merged

docs: note MariaDB support in README#13238
winterhazel merged 2 commits into
apache:mainfrom
robertsilen:docs/mariadb-readme

Conversation

@robertsilen

Copy link
Copy Markdown
Contributor

Summary

Documents that CloudStack uses a MySQL-compatible database. The Docker development setup in tools/docker/docker-compose.yml uses MariaDB (mariadb:10.0); the README only mentioned MySQL in the cryptographic software notice.

Documentation only; no code or deployment changes.

Test plan

  • README only

Document that CloudStack uses a MySQL-compatible database (MariaDB or
MySQL) and point to the Docker dev compose file that uses MariaDB.
Co-authored-by: Cursor <cursoragent@cursor.com>
@boring-cyborg

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@bernardodemarcobernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertsilen, thanks for the PR!

@robertsilen, do you think it is required to mention that The Docker development setup in tools/docker/docker-compose.yml uses MariaDB? I think that only mentioning that both MariaDB and MySQL are supported would be enough here

@winterhazel

Copy link
Copy Markdown
Member

@robertsilen, thanks for the PR!

@robertsilen, do you think it is required to mention that The Docker development setup in tools/docker/docker-compose.yml uses MariaDB? I think that only mentioning that both MariaDB and MySQL are supported would be enough here

+1

I think that something like this would be better:

* CloudStack requires a MySQL-compatible database (MariaDB or MySQL), and uses native database encryption functionality.

Drop the Docker compose reference; state MySQL-compatible (MariaDB or
MySQL) support only.
Co-authored-by: Cursor <cursoragent@cursor.com>
@robertsilen

Copy link
Copy Markdown
ContributorAuthor

@bernardodemarco@winterhazel Thanks for the review — agreed. I've dropped the Docker compose reference and simplified the line to:

CloudStack requires a MySQL-compatible database (MariaDB or MySQL), and uses native database encryption functionality.

Pushed to the branch.

@winterhazelwinterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecovBot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.11%. Comparing base (a0aafe2) to head (4675461).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #13238 +/- ##
============================================
+ Coverage 18.10% 18.11% +0.01% - Complexity 16746 16758 +12 
============================================
Files 6037 6037 Lines 542933 542783 -150 Branches 66487 66454 -33 ============================================
+ Hits 98283 98322 +39 + Misses 433602 433416 -186 + Partials 11048 11045 -3 
FlagCoverage Δ
uitests3.51% <ø> (ø)
unittests19.28% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@winterhazel
winterhazel merged commit e324551 into apache:mainMay 27, 2026
27 checks passed
@boring-cyborg

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@robertsilen@winterhazel@bernardodemarco@DaanHoogland