improved errorlog message by adding null check

[saurabhkushwaha438]

Implemented defensive null checks to prevent secondary NullPointerExceptions from masking the original VM import failure reason during VMware-to-KVM migration. for issue #13007

Changes made:

1. UnmanagedVMsManagerImpl.java

   • Added a null guard before invoking updateImportVMTaskErrorState(...) inside the CloudRuntimeException catch block.

2. ImportVmTasksManagerImpl.java

   • Added an early return in updateImportVMTaskErrorState(...) when the provided task object is null.

These changes ensure that the original import/conversion failure (for example missing virt-v2v or nbdkit-vddk on the target KVM host) is preserved and propagated correctly to the UI instead of being hidden by a secondary NPE during task error handling.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.77%. Comparing base (3f6866d) to head (4c5cbb9).
⚠️ Report is 61 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/vm/ImportVmTasksManagerImpl.java	0.00%	21 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #13263 +/- ##
============================================
+ Coverage 18.11% 18.77% +0.66% - Complexity 16757 17989 +1232 
============================================
Files 6037 6163 +126 Lines 542783 553008 +10225 Branches 66454 67387 +933 ============================================
+ Hits 98301 103837 +5536 - Misses 433438 437747 +4309 - Partials 11044 11424 +380 

Flag	Coverage Δ
uitests	3.53% <ø> (+0.01%)	⬆️
unittests	19.97% <0.00%> (+0.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR prevents secondary NullPointerExceptions from masking the original VM import/conversion failure during VMware-to-KVM migration, so the UI/API can surface the real error (e.g., missing virt-v2v / nbdkit-vddk) as described in issue #13007.

Changes:

• Add a null guard before calling updateImportVMTaskErrorState(...) from the VM import failure handler.
• Add an early return in updateImportVMTaskErrorState(...) when the provided task is null.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	Avoids triggering a secondary NPE while handling a CloudRuntimeException during import.
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java	Makes task error-state updates resilient to null task objects.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

[saurabhkushwaha438]

@nvazquez , @DaanHoogland could you approve workflow and review pull request

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[saurabhkushwaha438]

Hi @nvazquez , I've resolved the merge conflicts and updated this PR with the latest main. The CI has been rerun. I'd appreciate a review whenever you have time. Thank you!