Add ability to download templates in Swift

[syed]

This PR adds the ability to download templates when using Swift as a secondary storage. Uses the "temp_url" feature of Swift so that tempates can be downloaded without authenticaiton.

[DaanHoogland]

looks good @syed Can you add test data/description

[pdube]

Why return empty here, and null later?

[syed]

Fixed. Throwing exception instead

[syed]

JIRA: CLOUDSTACK-9248

Tested this on our local setup. Created a template and generated the download link. Verified the download and it is the same as the template.

[wido]

Looks good at first, but I would like to see some UnitTests around methods. I'll comment on those inline.

[wido]

Could you write a UnitTest for this?

[syed]

I don't think I can write a unit test for this as it relies on an external script to work to give the correct output. I could mock the output but that would defeat the purpose of the unit test.

[syed]

Added unit tests

[wido]

With the tests this looks good to me. I have no way of verifying the Swift working itself, but based on the code and tests: LGTM

[pdube]

LGTM Tested with a XenServer host and Swift as secondary storage. Got the link and downloaded the template

[syed]

Can we get this merged?

@DaanHoogland

[bvbharatk]

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

ACS CI BVT Run

Sumarry:
Build Number 125
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=1
Skipped=4

Failed tests:

• integration.smoke.test_volumes.TestCreateVolume
  • test_01_create_volume Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

Passed test suits:
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering

[syed]

@bvbharatk it looks to be a problem with the test. Volume creation should work irrespective of my changes.

[swill]

@syed can you squash the commits. This is best applied as a single commit. Thx.

[syed]

Sure @swill . I've sqashed them