Skip to content

Stop role from auto-changing if user manually selected a role during account creation - #13320

Merged
winterhazel merged 1 commit into
apache:mainfrom
scclouds:adjust-add-account-form-refresh
Jun 3, 2026
Merged

Stop role from auto-changing if user manually selected a role during account creation#13320
winterhazel merged 1 commit into
apache:mainfrom
scclouds:adjust-add-account-form-refresh

Conversation

@gp-santos

Copy link
Copy Markdown
Collaborator

Description

This PR changes the behavior of the Add Account form to not fill the default role if the user has manually selected a role before changing the domain.

Fixes: #13191

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecovBot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.11%. Comparing base (7308dad) to head (21d720f).

Additional details and impacted files
@@ Coverage Diff @@## main #13320 +/- ##
=========================================
Coverage 18.10% 18.11% - Complexity 16752 16753 +1 
=========================================
Files 6037 6037 Lines 542796 542798 +2 Branches 66456 66457 +1 =========================================
+ Hits 98291 98301 +10 + Misses 433460 433449 -11 - Partials 11045 11048 +3 
FlagCoverage Δ
uitests3.51% <ø> (-0.01%)⬇️
unittests19.27% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13320 (QA-JID-945)

@Pearl1594Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Verified behaviour.

@winterhazelwinterhazel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also verified in QA.

@winterhazel
winterhazel merged commit be51948 into apache:mainJun 3, 2026
26 of 27 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role changes after selecting domain in create account form

4 participants

@gp-santos@Pearl1594@blueorangutan@winterhazel