Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM templates - #1342
Conversation
DaanHoogland
commented
Jan 15, 2016
the jenkins failure is due to an old and unrelated licensing issue. |
DaanHoogland
commented
Jan 16, 2016
LGTM based on code and function- manual test (see screen print) @wilderrodrigues@remibergsma You guys have any use for this too? (hint intended) |
remibergsma
commented
Jan 16, 2016
@ustcweizhou@DaanHoogland Will test this soon. Can you please add that the size that one needs to specify is in GB? Didn't look so I had to look that up ;-) |
remibergsma
commented
Jan 16, 2016
LGTM, the UI shows fine and the value is passed to the API as shown in screenshot. See comment above, please add "GB" after the field.
|
There was a problem hiding this comment.
Should become if(custom){//logic} to avoid empty condition
cb98a11 to
69b8bacCompareyadvr
commented
Jan 27, 2016
LGTM |
yadvr
commented
Jan 27, 2016
@ustcweizhou please add the "GB" label after the string, then we can merge this. Thanks. |
…M templates This commit includes three changes: (1) Revert commit 13bf1ec to show the 'root disk size' field (2) Set the default value from '1' to empty. This also changes the default value of customized service offerings from '1' to empty. (3) show 'root disk size' field only when users choose a KVM template, as cloudstack supports deployvm with rootdisksize on KVM only.
69b8bac to
3822be5Compareustcweizhou
commented
Jan 27, 2016
add (GB) to the label. Please test it. |
yadvr
commented
Jan 28, 2016
cc @remibergsma requires merging on 4.6 and consequent fwd merges |
CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM templatesThis commit includes three changes: (1) Revert commit 13bf1ec to show the 'root disk size' field (2) Set the default value from '1' to empty. This also changes the default value of customized service offerings from '1' to empty. (3) show 'root disk size' field only when users choose a KVM template, as cloudstack supports deployvm with rootdisksize on KVM only. * pr/1342: CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM templates Signed-off-by: Remi Bergsma <github@remi.nl>
This commit includes three changes:
(1) Revert commit 13bf1ec to show the 'root disk size' field
(2) Set the default value from '1' to empty. This also changes the default value of customized service offerings from '1' to empty.
(3) show 'root disk size' field only when users choose a KVM template, as cloudstack supports deployvm with rootdisksize on KVM only.