Allow selecting network for VNF nics if template nics > 0 and is a non deploy-as-is template by Pearl1594 · Pull Request #13423 · apache/cloudstack

Pearl1594 · 2026-06-15T17:29:49Z

Description

This PR fixes an issue where we can't select the network for VNF nic mapping if there are template nics and it's a non deploy-as-is VNF template

introduced by: #12499

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…n-deploy as is template

nvazquez

Code LGTM thanks @Pearl1594

codecov · 2026-06-15T17:37:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (21b2025) to head (fead05b).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files

@@ Coverage Diff @@## 4.22 #13423 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01% 
Complexity 15792 15792 ============================================
Files 5922 5922 Lines 533165 533180 +15 Branches 65208 65218 +10 ============================================
+ Hits 94242 94244 +2 - Misses 428276 428290 +14 + Partials 10647 10646 -1

Flag	Coverage Δ
uitests	`3.69% <ø> (-0.01%)`	⬇️
unittests	`18.75% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2026-06-15T20:14:30Z

@Pearl1594
How to reproduce this ?

if there are template nics and it's a non deploy-as-is VNF template

weizhouapache · 2026-06-16T07:59:47Z

thanks @Pearl1594 for the info

I can reproduce the issue.

the fix could be as simple as

diff --git a/ui/src/views/compute/wizard/VnfNicsSelection.vue b/ui/src/views/compute/wizard/VnfNicsSelection.vue
index 40bdc1c676a..538c9553eb4 100644
--- a/ui/src/views/compute/wizard/VnfNicsSelection.vue
+++ b/ui/src/views/compute/wizard/VnfNicsSelection.vue
@@ -50,7 +50,7 @@
<template #network="{ record }">
<a-form-item style="display: block" :name="'nic-' + record.deviceid">
<a-select
- disabled="templateNics && templateNics.length > 0"
+ :disabled="templateNics && templateNics.length > 0"
@change="updateNicNetworkValue($event, record.deviceid)"
optionFilterProp="label"
:filterOption="(input, option) => {

🤦

Pearl1594 · 2026-06-16T16:32:41Z

thanks @Pearl1594 for the info

I can reproduce the issue.

the fix could be as simple as

diff --git a/ui/src/views/compute/wizard/VnfNicsSelection.vue b/ui/src/views/compute/wizard/VnfNicsSelection.vue
index 40bdc1c676a..538c9553eb4 100644
--- a/ui/src/views/compute/wizard/VnfNicsSelection.vue
+++ b/ui/src/views/compute/wizard/VnfNicsSelection.vue
@@ -50,7 +50,7 @@
<template #network="{ record }">
<a-form-item style="display: block" :name="'nic-' + record.deviceid">
<a-select
- disabled="templateNics && templateNics.length > 0"
+ :disabled="templateNics && templateNics.length > 0"
@change="updateNicNetworkValue($event, record.deviceid)"
optionFilterProp="label"
:filterOption="(input, option) => {

🤦

Oh yeah

sonarqubecloud · 2026-06-16T17:14:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

weizhouapache

lgtm

verified OK

nvazquez · 2026-06-17T02:09:48Z

@blueorangutan ui

blueorangutan · 2026-06-17T02:11:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-06-17T02:29:06Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13423 (QA-JID-952)

…as-is template (#13423) * Allow selecting network for VNF nics if template nics > 0 and is a non-deploy as is template * delpoy as is param not required --------- Co-authored-by: Pearl Dsilva <pearl1954@gmail.com>

kiranchavala

LGTM

before fix

After fix

Allow selecting network for VNF nics if template nics > 0 and is a no…
25f48a2
…n-deploy as is template

Pearl1594 requested a review from weizhouapache June 15, 2026 17:29

boring-cyborgBot added the component:UI label Jun 15, 2026

Pearl1594 changed the base branch from main to 4.22June 15, 2026 17:30

Pearl1594 requested a review from nvazquez June 15, 2026 17:30

Pearl1594 added this to the 4.22.2 milestone Jun 15, 2026

nvazquez approved these changes Jun 15, 2026
View reviewed changes

github-actionsBot mentioned this pull request Jun 15, 2026
[repo-status] Daily Status Report — June 15, 2026 #13425
Closed

delpoy as is param not required
fead05b

weizhouapache approved these changes Jun 16, 2026
View reviewed changes

github-actionsBot mentioned this pull request Jun 16, 2026
[repo-status] Daily Status Report — June 16, 2026 #13435
Closed

nvazquez marked this pull request as ready for review June 17, 2026 02:09

harikrishna-patnala mentioned this pull request Jun 17, 2026
[4.22.1.0-shapeblue1] Allow selecting network for VNF nics if template nics > 0 and is a non deploy-as-is template shapeblue/cloudstack#142
Merged
14 tasks

weizhouapache merged commit e689c02 into 4.22Jun 18, 2026
49 of 50 checks passed

DaanHoogland deleted the fix-vnf-net-select-non-deployasis branch June 18, 2026 11:04

This was referenced Jun 27, 2026
UI: Fix VNF NIC mapping network select always disabled #13359
Closed
i am unable to do VNF nic Mappings #13504
Closed

kiranchavala reviewed Jul 6, 2026
View reviewed changes

sudo87 mentioned this pull request Aug 5, 2026
[BUG] UI: VNF NIC Mapping - Network select dropdown always disabled #13358
Closed

DaanHoogland linked an issue Aug 5, 2026 that may be closed by this pull request
[BUG] UI: VNF NIC Mapping - Network select dropdown always disabled #13358
Closed

Navigation Menu

Uh oh!

Allow selecting network for VNF nics if template nics > 0 and is a non deploy-as-is template - #13423

Allow selecting network for VNF nics if template nics > 0 and is a non deploy-as-is template#13423
weizhouapache merged 2 commits into
4.22from
fix-vnf-net-select-non-deployasis

Pearl1594 commented Jun 15, 2026

Uh oh!

nvazquez left a comment

Uh oh!

codecovBot commented Jun 15, 2026•
edited
Loading

Uh oh!

weizhouapache commented Jun 15, 2026

Uh oh!

weizhouapache commented Jun 16, 2026

Uh oh!

Pearl1594 commented Jun 16, 2026

Uh oh!

sonarqubecloudBot commented Jun 16, 2026

Uh oh!

weizhouapache left a comment

Uh oh!

nvazquez commented Jun 17, 2026

Uh oh!

blueorangutan commented Jun 17, 2026

Uh oh!

blueorangutan commented Jun 17, 2026

Uh oh!

Uh oh!

kiranchavala left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Pearl1594 commented Jun 15, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Jun 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Jun 15, 2026

Uh oh!

weizhouapache commented Jun 16, 2026

Uh oh!

Pearl1594 commented Jun 16, 2026

Uh oh!

sonarqubecloudBot commented Jun 16, 2026

Quality Gate passed

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jun 17, 2026

Uh oh!

blueorangutan commented Jun 17, 2026

Uh oh!

blueorangutan commented Jun 17, 2026

Uh oh!

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecovBot commented Jun 15, 2026•
edited
Loading