Add KMSWrappedKeyDao as a dependency for the Usage server by winterhazel · Pull Request #13535 · apache/cloudstack

winterhazel · 2026-07-02T20:16:24Z

Description

PR #12711 injected KMSWrappedKeyDao in com.cloud.storage.dao.VolumeDao, which is used by the Usage server. However, KMSWrappedKeyDao was not added as dependency for the Usage server. Due to this, the Usage server fails to start in the latest commit.

Logs

2026-07-05 21:21:42,389 ERROR [utils.component.ComponentContext] (main:[]) (logid:) Could not load bean due to: [Error creating bean with name 'volumeDaoImpl': Unsatisfied dependency expressed through field 'kmsWrappedKeyDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.kms.dao.KMSWrappedKeyDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}]. The service will be stopped. Please investigate the cause of the error or contact your support team. org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'volumeDaoImpl': Unsatisfied dependency expressed through field 'kmsWrappedKeyDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.kms.dao.KMSWrappedKeyDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:660)
at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:640)
at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:119)
at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1431)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.configureBean(AbstractAutowireCapableBeanFactory.java:364)
at com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:80)
at com.cloud.usage.UsageServer.start(UsageServer.java:55)
at com.cloud.usage.UsageServer.main(UsageServer.java:42)
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.cloudstack.kms.dao.KMSWrappedKeyDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoMatchingBeanFound(DefaultListableBeanFactory.java:1801)
at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1357)
at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1311)
at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:657)
... 8 more

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

I built packages for this patch, installed them, and validated that the Usage server started successfully.

Logs

2026-07-05 21:49:01,539 INFO [cloud.usage.UsageManagerImpl_EnhancerByCloudStack_c4597d1] (main:[]) (logid:) Starting Usage Manager
2026-07-05 21:49:01,618 INFO [utils.component.ComponentContext] (main:[]) (logid:) Starting org.apache.cloudstack.quota.QuotaStatementImpl_EnhancerByCloudStack_9ed9c05c
2026-07-05 21:49:01,619 INFO [cloudstack.quota.QuotaStatementImpl_EnhancerByCloudStack_9ed9c05c] (main:[]) (logid:) Starting Statement Manager
2026-07-05 21:49:01,619 INFO [utils.component.ComponentContext] (main:[]) (logid:) Starting org.apache.cloudstack.quota.QuotaAlertManagerImpl_EnhancerByCloudStack_39561c98
2026-07-05 21:49:01,619 INFO [cloudstack.quota.QuotaAlertManagerImpl_EnhancerByCloudStack_39561c98] (main:[]) (logid:) Starting Alert Manager
2026-07-05 21:49:01,619 INFO [utils.component.ComponentContext] (main:[]) (logid:) Starting org.apache.cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_7bfd14ca
2026-07-05 21:49:01,620 INFO [cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_7bfd14ca] (main:[]) (logid:) Starting Quota Manager
2026-07-05 21:49:01,620 INFO [utils.component.ComponentContext] (main:[]) (logid:) Starting com.cloud.usage.UsageAlertManagerImpl_EnhancerByCloudStack_2cd965f1
2026-07-05 21:49:01,621 INFO [cloud.usage.UsageServer] (main:[]) (logid:) UsageServer ready...

winterhazel · 2026-07-02T20:16:41Z

@blueorangutan package

blueorangutan · 2026-07-02T20:18:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-07-02T20:25:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.93%. Comparing base (7e84850) to head (a2c1c0b).

Additional details and impacted files

@@ Coverage Diff @@## main #13535 +/- ##
=========================================
Coverage 18.93% 18.93% + Complexity 18476 18474 -2 
=========================================
Files 6221 6221 Lines 560073 560073 Branches 68286 68286 =========================================
+ Hits 106068 106070 +2 + Misses 442379 442375 -4 - Partials 11626 11628 +2

Flag	Coverage Δ
uitests	`3.50% <ø> (ø)`
unittests	`20.14% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-07-02T21:40:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18448

shwstppr

code lgtm

DaanHoogland · 2026-07-03T14:43:17Z

@blueorangutan test

blueorangutan · 2026-07-03T14:44:10Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland

clgtm, not sure if smoke test suffice to prove the validity of this fix though. Needs assessment.

blueorangutan · 2026-07-04T05:20:58Z

[SF] Trillian test result (tid-16477)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49677 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13535-t16477-kvm-ol8.zip
Smoke tests completed. 152 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2026-07-07T15:24:25Z

@vishesh92
could you please review and verify it ? thanks!

weizhouapache · 2026-07-08T09:03:08Z

issue is reproducible. verified OK

thanks @winterhazel for the fix

merging

Add KMSWrappedKeyDao as a dependency for the Usage server
a2c1c0b

winterhazel requested a review from vishesh92 July 2, 2026 20:16

winterhazel added component:usage-server Severity:BLOCKER labels Jul 2, 2026

winterhazel added this to the 4.23.0 milestone Jul 2, 2026

shwstppr approved these changes Jul 3, 2026
View reviewed changes

DaanHoogland approved these changes Jul 3, 2026
View reviewed changes

weizhouapache merged commit 600201a into apache:mainJul 8, 2026
25 of 27 checks passed

Navigation Menu

Uh oh!

Add KMSWrappedKeyDao as a dependency for the Usage server - #13535

Add KMSWrappedKeyDao as a dependency for the Usage server#13535
weizhouapache merged 1 commit into
apache:mainfrom
winterhazel:fix-usage-server

winterhazel commented Jul 2, 2026

Uh oh!

winterhazel commented Jul 2, 2026

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

codecovBot commented Jul 2, 2026•
edited
Loading

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

shwstppr left a comment

Uh oh!

DaanHoogland commented Jul 3, 2026

Uh oh!

blueorangutan commented Jul 3, 2026

Uh oh!

DaanHoogland left a comment

Uh oh!

blueorangutan commented Jul 4, 2026

Uh oh!

weizhouapache commented Jul 7, 2026

Uh oh!

weizhouapache commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

winterhazel commented Jul 2, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

winterhazel commented Jul 2, 2026

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

codecovBot commented Jul 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 3, 2026

Uh oh!

blueorangutan commented Jul 3, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 4, 2026

Uh oh!

weizhouapache commented Jul 7, 2026

Uh oh!

weizhouapache commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Jul 2, 2026•
edited
Loading