Uh oh!
There was an error while loading. Please reload this page.
Refactor system VM default network creation - #1359
Closed
ProjectMoon wants to merge 2 commits into
Closed
Conversation
added 2 commits
January 22, 2016 10:08
It is now in a separate method for more readability and flexibility.
It's now in a separate method to increase readability and flexibility.
wilderrodrigues
commented
Jan 22, 2016
Contributor
Hi @ProjectMoon Could you please create you PR against Master. If that's a refactor does not really make sense to create the PR against 4.6 because we are already releasing 4.7.1 and 4.8.0. Cheers, |
ProjectMoon
commented
Jan 22, 2016
Author
OK. So just to be sure: it's oldest supported maintenance release for bug fixes and then master for any new features/refactoring? |
remibergsma
commented
Jan 22, 2016
Contributor
@ProjectMoon Indeed! :-) |
asfgit pushed a commit
that referenced
this pull request
May 26, 2016
…k-creation Refactor system VM default network creationTwo small commits which moves the retrieval of the default network for the console proxy and the SSVM into a separate protected method. It's a small change that makes the code more readable/maintainable and also makes the class more suitable for overriding should one want to do this. It's forward-ported from our 4.2 branch. No new tests since this should not change any functionality, and thus should be covered by the existing unit tests. Now on the master branch (#1359 was on the wrong branch). * pr/1360: Refactor ssvm default network retrieval. Refactor console proxy default network retrieval. Signed-off-by: Will Stevens <williamstevens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small commits which moves the retrieval of the default network for the console proxy and the SSVM into a separate protected method. It's a small change that makes the code more readable/maintainable and also makes the class more suitable for overriding should one want to do this. It's forward-ported from our 4.2 branch.
No new tests since this should not change any functionality, and thus should be covered by the existing unit tests.