Skip to content

debian/ubuntu: ignore pycompile errors - #13602

Merged
weizhouapache merged 3 commits into
apache:mainfrom
weizhouapache:4.23-ignore-pycompile-errors
Jul 14, 2026
Merged

debian/ubuntu: ignore pycompile errors#13602
weizhouapache merged 3 commits into
apache:mainfrom
weizhouapache:4.23-ignore-pycompile-errors

Conversation

@weizhouapache

@weizhouapacheweizhouapache commented Jul 13, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes the installation failures on ubuntu 22.04, as some new scripts are not python2-compatible.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

CopilotAI review requested due to automatic review settings July 13, 2026 19:56
@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Debian cloudstack-common post-install script to tolerate pycompile failures during package configuration, avoiding installation aborts when byte-compilation encounters issues.

Changes:

  • Make pycompile -p cloudstack-common non-fatal by appending || true.
  • Make pycompile -p cloudstack-common /usr/share/cloudstack-common non-fatal by appending || true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threaddebian/cloudstack-common.postinst Outdated
Comment threaddebian/cloudstack-common.postinst Outdated
@codecov

codecovBot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.50%. Comparing base (d2a3bd1) to head (b9502ae).

Additional details and impacted files
@@ Coverage Diff @@## main #13602 +/- ##
============================================
- Coverage 19.50% 19.50% -0.01% + Complexity 19441 19438 -3 
============================================
Files 6303 6303 Lines 569288 569288 Branches 69792 69792 ============================================
- Hits 111029 111018 -11 - Misses 446108 446119 +11 
Partials 12151 12151 
FlagCoverage Δ
uitests3.41% <ø> (ø)
unittests20.77% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18555

@weizhouapache
weizhouapache marked this pull request as ready for review July 13, 2026 22:43
@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test matrix

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16555)

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test ubuntu22 kvm-ubuntu22

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings July 14, 2026 07:24

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment threaddebian/cloudstack-common.postinst Outdated
Comment threaddebian/cloudstack-common.postinst Outdated
CopilotAI review requested due to automatic review settings July 14, 2026 07:34

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threaddebian/cloudstack-common.postinst Outdated
@weizhouapache
weizhouapacheforce-pushed the 4.23-ignore-pycompile-errors branch from ce378d2 to b07c722CompareJuly 14, 2026 07:49
CopilotAI review requested due to automatic review settings July 14, 2026 07:49

@vishesh92vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threaddebian/cloudstack-common.postinst Outdated
CopilotAI review requested due to automatic review settings July 14, 2026 07:56
@weizhouapache
weizhouapacheforce-pushed the 4.23-ignore-pycompile-errors branch from b07c722 to b9502aeCompareJuly 14, 2026 07:56

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18560

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test ubuntu22 kvm-ubuntu22

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

@sureshanapartisureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Assuming Ubuntu 20.04 and earlier versions have reached EoL and not support with CS 4.23 versions.

@weizhouapacheweizhouapache changed the title debian: ignore pycompile errorsdebian/ubuntu: ignore pycompile errorsJul 14, 2026
@weizhouapache

Copy link
Copy Markdown
MemberAuthor

merging this, I will run smoke tests with other PRs (see #12198)

thanks @vishesh92 providing the fix, and @harikrishna-patnala@sureshanaparti for the review

@weizhouapache
weizhouapache merged commit 3328004 into apache:mainJul 14, 2026
18 of 27 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache@blueorangutan@harikrishna-patnala@vishesh92@sureshanaparti