server: fix clone network offerings with detail internetProtocol=IPv4 by weizhouapache · Pull Request #13615 · apache/cloudstack

weizhouapache · 2026-07-14T14:17:25Z

Description

This PR fixes#13610

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2026-07-14T14:18:01Z

@blueorangutan package

blueorangutan · 2026-07-14T14:20:06Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

This PR fixes cloning of network offerings when the source offering contains details like internetProtocol=IPv4, which previously could trigger a ClassCastException in NetworkOfferingBaseCmd.getDetails() due to an unexpected details-map structure during clone.

Changes:

Stop injecting source offering details into the API details parameter structure during clone; instead, carry them via a dedicated internal sourceDetailsMap.
Update NetworkOfferingBaseCmd.getDetails() to fall back to sourceDetailsMap when no API details were provided.
Exclude internetProtocol, domainid, and zoneid from the cloned details map (these are handled via dedicated command fields / parameters).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java	Adjusts clone parameter population to avoid mis-shaping `details` and filters out special-case detail keys.
api/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java	Adds an internal fallback details map and changes `getDetails()` to return it when API `details` are absent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-07-14T14:26:00Z

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.64%. Comparing base (028e1ef) to head (297185e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../cloud/configuration/ConfigurationManagerImpl.java	25.00%	3 Missing ⚠️
.../command/admin/network/NetworkOfferingBaseCmd.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #13615 +/- ##
=========================================
Coverage 19.64% 19.64% Complexity 19793 19793 =========================================
Files 6368 6368 Lines 575100 575102 +2 Branches 70370 70371 +1 =========================================
+ Hits 113002 113006 +4 
Misses 449815 449815 + Partials 12283 12281 -2

Flag	Coverage Δ
uitests	`3.41% <ø> (ø)`
unittests	`20.92% <20.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594

code lgtm

weizhouapache · 2026-07-14T14:44:22Z

@blueorangutan package

blueorangutan · 2026-07-14T14:46:05Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

 public Map<String, String> getDetails() {
 if (details == null || details.isEmpty()) {
- return null;
+ return sourceDetailsMap;
 }


blueorangutan · 2026-07-14T15:21:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18569

blueorangutan · 2026-07-14T15:29:50Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18571

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

 public Map<String, String> getDetails() {
 if (details == null || details.isEmpty()) {
- return null;
+ return sourceDetailsMap;
 }


kiranchavala

LGTM

Tested manually

Able to clone the network offering and vpc offerings

weizhouapache · 2026-07-15T06:38:27Z

@blueorangutan package

blueorangutan · 2026-07-15T06:40:05Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-07-15T07:26:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18580

weizhouapache · 2026-07-15T08:51:24Z

@blueorangutan test

blueorangutan · 2026-07-15T08:52:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-07-16T00:45:58Z

[SF] Trillian test result (tid-16572)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53998 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13615-t16572-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

winterhazel · 2026-07-20T15:34:42Z

Merging based on manual testing by @kiranchavala and approvals

CopilotAI review requested due to automatic review settings July 14, 2026 14:17

boring-cyborgBot added the component:api label Jul 14, 2026

weizhouapache added this to the 4.23.0 milestone Jul 14, 2026

weizhouapache requested review from Pearl1594 and kiranchavala July 14, 2026 14:17

Copilotstarted reviewing on behalf of weizhouapache July 14, 2026 14:17 View session

CopilotAI reviewed Jul 14, 2026
View reviewed changes

Comment threadserver/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java Outdated
Comment threadserver/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

Pearl1594 approved these changes Jul 14, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings July 14, 2026 14:43

Copilotstarted reviewing on behalf of weizhouapache July 14, 2026 14:44 View session

CopilotAI reviewed Jul 14, 2026
View reviewed changes

Comment threadapi/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java
Comment on lines 433 to 436
public Map<String, String> getDetails() {
if (details == null || details.isEmpty()) {
return null;
return sourceDetailsMap;
}

weizhouapacheand others added 2 commits July 14, 2026 17:54

server: fix clone network offerings with detail internetProtocol=IPv4
34b80e7

use HashSet instead of List
297185e
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 14, 2026 15:54

weizhouapache force-pushed the 4.23-fix-clone-network-offering branch from dbdf6a8 to 297185eCompare July 14, 2026 15:54

Copilotstarted reviewing on behalf of weizhouapache July 14, 2026 15:55 View session

CopilotAI reviewed Jul 14, 2026
View reviewed changes

Comment threadapi/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java
Comment on lines 433 to 436
public Map<String, String> getDetails() {
if (details == null || details.isEmpty()) {
return null;
return sourceDetailsMap;
}

kiranchavala approved these changes Jul 15, 2026
View reviewed changes

weizhouapache marked this pull request as ready for review July 17, 2026 13:20

DaanHoogland added the status:ready-for-merge label Jul 20, 2026

winterhazel merged commit 7900b27 into apache:mainJul 20, 2026
26 of 27 checks passed

winterhazel removed the status:ready-for-merge label Jul 20, 2026

DaanHoogland deleted the 4.23-fix-clone-network-offering branch July 20, 2026 17:31

Uh oh!

Conversation

weizhouapache commented Jul 14, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Jul 14, 2026

Uh oh!

blueorangutan commented Jul 14, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Jul 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 14, 2026

Uh oh!

blueorangutan commented Jul 14, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

blueorangutan commented Jul 14, 2026

Uh oh!

blueorangutan commented Jul 14, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 15, 2026

Uh oh!

weizhouapache commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 16, 2026

Uh oh!

winterhazel commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented Jul 14, 2026•
edited
Loading