Skip to content

UI: fix blank page when list Other OSes in VNF appliance deployment - #13620

Merged
winterhazel merged 1 commit into
apache:4.22from
weizhouapache:4.22-ui-fix-vnf
Jul 22, 2026
Merged

UI: fix blank page when list Other OSes in VNF appliance deployment#13620
winterhazel merged 1 commit into
apache:4.22from
weizhouapache:4.22-ui-fix-vnf

Conversation

@weizhouapache

@weizhouapacheweizhouapache commented Jul 15, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes#13621

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapacheweizhouapache added this to the 4.22.2 milestone Jul 15, 2026
@codecov

codecovBot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.69%. Comparing base (17e5947) to head (6d5ad2e).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files
@@ Coverage Diff @@## 4.22 #13620 +/- ##
============================================
- Coverage 17.69% 17.69% -0.01% - Complexity 15829 15832 +3 
============================================
Files 5925 5925 Lines 533534 533534 Branches 65267 65273 +6 ============================================
- Hits 94412 94398 -14 - Misses 428444 428457 +13 - Partials 10678 10679 +1 
FlagCoverage Δ
uitests3.69% <ø> (ø)
unittests18.77% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13620 (QA-JID-960)

@weizhouapache
weizhouapache marked this pull request as ready for review July 17, 2026 13:07

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan package

@kiranchavala

kiranchavala commented Jul 21, 2026

Copy link
Copy Markdown
Member

cc @weizhouapache@winterhazel

Consider this UI improvement for the 4.23 release

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18630

@kiranchavalakiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested manually , Able to list multiple VNF template when deploying a vnf appliance

ImageImage

@winterhazel

Copy link
Copy Markdown
Member

cc @weizhouapache@winterhazel

Consider this UI improvement for the 4.23 release

@kiranchavala ok. This is a very simple and isolated fix, so I will include it in 4.23 RC2.

@winterhazel

Copy link
Copy Markdown
Member

@kiranchavala does this bug also happen in 4.20.3? I saw that the changed code also exists in branch 4.20.

@winterhazel

Copy link
Copy Markdown
Member

@kiranchavala does this bug also happen in 4.20.3? I saw that the changed code also exists in branch 4.20.

I checked that 4.20 does not have the OS filter, so this bug is not present in 4.20.3.

Merging this to 4.22 and then forward-merging to main.

@winterhazel
winterhazel merged commit 0339f31 into apache:4.22Jul 22, 2026
26 checks passed
winterhazel added a commit that referenced this pull request Jul 22, 2026
* 4.22:
UI: fix blank page when list Other OSes in VNF appliance deployment (#13620)
ConfigureStorageAccessCmd: Allow storage access configuration on empt… (#578) (#13551)
@DaanHoogland
DaanHoogland deleted the 4.22-ui-fix-vnf branch July 22, 2026 15:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Vnf appliance deploy page doesn't show all the vnf templates registered in cloudstack

6 participants

@weizhouapache@blueorangutan@kiranchavala@winterhazel@DaanHoogland@vladimirpetrov