nasbackup: fix backup stopped vm on Ubuntu 26.04 by weizhouapache · Pull Request #13643 · apache/cloudstack

weizhouapache · 2026-07-17T12:55:33Z

backing up stopped vm failed on Ubuntu 26.04 failed with error

2026-07-17 09:47:56,636 DEBUG [resource.wrapper.LibvirtTakeBackupCommandWrapper] (AgentRequest-Handler-4:[]) (logid:fd553fbe) Wei Parsing backup size line: Jul
2026-07-17 09:47:56,636 WARN [cloud.agent.Agent] (AgentRequest-Handler-4:[]) (logid:fd553fbe) Caught: java.lang.NumberFormatException: For input string: "Jul"
at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
at java.base/java.lang.Long.parseLong(Long.java:711)
at java.base/java.lang.Long.parseLong(Long.java:836)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.parseBackupSize(LibvirtTakeBackupCommandWrapper.java:230)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.execute(LibvirtTakeBackupCommandWrapper.java:111)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.execute(LibvirtTakeBackupCommandWrapper.java:42)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:2407)

it is due to different format of "ls -l" command:

kvm1:~# ls -l /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/
total 1475240
-rw-r--r--+1 root root 1510539264 Jul 17 10:07 root.49d59058-90ce-4fba-bee6-da6d626065dd.qcow2
kvm1:~# ls -l --numeric-uid-gid /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/ | awk '{print $5}'
Jul
kvm1:~# find /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/ -type f -exec stat -c '%s' {} +
1510539264

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

backing up stopped vm failed on Ubuntu 26.04 failed with error ``` 2026-07-17 09:47:56,636 DEBUG [resource.wrapper.LibvirtTakeBackupCommandWrapper] (AgentRequest-Handler-4:[]) (logid:fd553fbe) Wei Parsing backup size line: Jul 2026-07-17 09:47:56,636 WARN [cloud.agent.Agent] (AgentRequest-Handler-4:[]) (logid:fd553fbe) Caught: java.lang.NumberFormatException: For input string: "Jul" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) at java.base/java.lang.Long.parseLong(Long.java:711) at java.base/java.lang.Long.parseLong(Long.java:836) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.parseBackupSize(LibvirtTakeBackupCommandWrapper.java:230) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.execute(LibvirtTakeBackupCommandWrapper.java:111) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtTakeBackupCommandWrapper.execute(LibvirtTakeBackupCommandWrapper.java:42) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:2407) ``` it is due to different format of "ls -l" command: ``` kvm1:~# ls -l /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/ total 1475240 -rw-r--r--+1 root root 1510539264 Jul 17 10:07 root.49d59058-90ce-4fba-bee6-da6d626065dd.qcow2 kvm1:~# ls -l --numeric-uid-gid /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/ | awk '{print $5}' Jul kvm1:~# find /tmp/csbackup.2CsWP/i-2-582-VM/2026.07.17.09.47.45/ -type f -exec stat -c '%s' {} + 1510539264 ```

weizhouapache · 2026-07-17T12:56:13Z

@blueorangutan package

blueorangutan · 2026-07-17T12:58:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Fixes NAS backup of stopped KVM VMs on Ubuntu 26.04 by avoiding ls -l output parsing (which can shift fields) when reporting backup size back to the management server.

Changes:

Replace ls -l --numeric-uid-gid ... | awk '{print $5}' with find ... -exec stat -c '%s' ... to emit byte sizes reliably for the produced backup files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-07-17T13:03:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (7c2b919).

Additional details and impacted files

@@ Coverage Diff @@## main #13643 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01% + Complexity 19792 19785 -7 
============================================
Files 6368 6368 Lines 575107 575107 Branches 70370 70370 ============================================
- Hits 113016 112986 -30 - Misses 449808 449836 +28 - Partials 12283 12285 +2

Flag	Coverage Δ
uitests	`3.41% <ø> (ø)`
unittests	`20.92% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-07-17T13:41:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18604

weizhouapache · 2026-07-17T13:52:14Z

@blueorangutan test ubuntu26 kvm-ubuntu26

blueorangutan · 2026-07-17T13:54:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + kvm-ubuntu26) has been kicked to run smoke tests

weizhouapache · 2026-07-17T14:17:36Z

@blueorangutan test ubuntu24 kvm-ubuntu24

blueorangutan · 2026-07-17T14:18:05Z

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests

winterhazel

~~Assuming that the file output order does not matter, it looks good (did not test).~~

fabricio@pc:~/github/cloudstack$ ls -l --numeric-uid-gid $dest| awk '{print $5}'
4978
9819
13674
205830
4954
fabricio@pc:~/github/cloudstack$ find "$dest" -type f -exec stat -c '%s' {} +
4954
9819
4978
205830
13674

Edit: I had a look at the code that parses this output. It seems to assume that the volume's size will be on the last line when backing up a single volume?

privatelongparseBackupSize(Stringstdout, List<String> diskPaths) {
longbackupSize = 0L;
if (CollectionUtils.isNullOrEmpty(diskPaths)) {
List<String> outputLines = Arrays.asList(stdout.split("\n"));
if (!outputLines.isEmpty()) {
backupSize = Long.parseLong(outputLines.get(outputLines.size() - 1).trim());
}
} else {
for (Stringline : stdout.split("\n")) {
backupSize = backupSize + Long.parseLong(line.split(" ")[0].trim());
}
}
returnbackupSize;
}

@weizhouapache could you check if this output order change may cause a regression?

weizhouapache · 2026-07-17T15:53:29Z

~~Assuming that the file output order does not matter, it looks good (did not test).~~

fabricio@pc:~/github/cloudstack$ ls -l --numeric-uid-gid $dest| awk '{print $5}'
4978
9819
13674
205830
4954
fabricio@pc:~/github/cloudstack$ find "$dest" -type f -exec stat -c '%s' {} +
4954
9819
4978
205830
13674

Edit: I had a look at the code that parses this output. It seems to assume that the volume's size will be on the last line when backing up a single volume?

privatelongparseBackupSize(Stringstdout, List<String> diskPaths) {
longbackupSize = 0L;
if (CollectionUtils.isNullOrEmpty(diskPaths)) {
List<String> outputLines = Arrays.asList(stdout.split("\n"));
if (!outputLines.isEmpty()) {
backupSize = Long.parseLong(outputLines.get(outputLines.size() - 1).trim());
}
} else {
for (Stringline : stdout.split("\n")) {
backupSize = backupSize + Long.parseLong(line.split(" ")[0].trim());
}
}
returnbackupSize;
}

@weizhouapache could you check if this output order change may cause a regression?

Thanks @winterhazel for checking
In my testing, the directory has only 1 qcow2 file. I will double check when possible (I will on leave next week)

blueorangutan · 2026-07-18T06:01:36Z

[SF] Trillian test result (tid-8)
Environment: kvm-ubuntu26 (x2), zone: Advanced Networking with Mgmt server u26
Total time taken: 55415 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13643-n8-kvm-ubuntu26.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2026-07-18T07:14:51Z

[SF] Trillian test result (tid-16585)
Environment: kvm-ubuntu24 (x2), zone: Advanced Networking with Mgmt server u24
Total time taken: 58370 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13643-t16585-kvm-ubuntu24.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

winterhazel · 2026-07-20T12:33:33Z

@abh1sar could you also have a look at this change, specially at the comment in #13643 (review)? I am not that familiar with how the NAS plugin works, so I would appreciate some other eyes here :)

abh1sar · 2026-07-20T17:17:38Z

@abh1sar could you also have a look at this change, specially at the comment in #13643 (review)? I am not that familiar with how the NAS plugin works, so I would appreciate some other eyes here :)

Sure, I'll review and test tomorrow.

abh1sar · 2026-07-21T14:00:18Z

~~Assuming that the file output order does not matter, it looks good (did not test).~~

fabricio@pc:~/github/cloudstack$ ls -l --numeric-uid-gid $dest| awk '{print $5}'
4978
9819
13674
205830
4954
fabricio@pc:~/github/cloudstack$ find "$dest" -type f -exec stat -c '%s' {} +
4954
9819
4978
205830
13674

Edit: I had a look at the code that parses this output. It seems to assume that the volume's size will be on the last line when backing up a single volume?

privatelongparseBackupSize(Stringstdout, List<String> diskPaths) {
longbackupSize = 0L;
if (CollectionUtils.isNullOrEmpty(diskPaths)) {
List<String> outputLines = Arrays.asList(stdout.split("\n"));
if (!outputLines.isEmpty()) {
backupSize = Long.parseLong(outputLines.get(outputLines.size() - 1).trim());
}
} else {
for (Stringline : stdout.split("\n")) {
backupSize = backupSize + Long.parseLong(line.split(" ")[0].trim());
}
}
returnbackupSize;
}

@weizhouapache could you check if this output order change may cause a regression?

In case of a single volume vm there will be only one line, so order doesn't matter.

abh1sar

Tested, LGTM.

p.s the bash script needs some refactoring. I'll raise a PR for it.
But this change good enough for 4.23

winterhazel

@abh1sar thank you. Merging this one.

CopilotAI review requested due to automatic review settings July 17, 2026 12:55

boring-cyborgBot added the component:kvm label Jul 17, 2026

Copilotstarted reviewing on behalf of weizhouapache July 17, 2026 12:56 View session

CopilotAI reviewed Jul 17, 2026
View reviewed changes

weizhouapache added this to the 4.23.0 milestone Jul 17, 2026

winterhazel approved these changes Jul 17, 2026
View reviewed changes

winterhazel self-requested a review July 17, 2026 15:48

winterhazel requested a review from abh1sar July 20, 2026 12:58

abh1sar approved these changes Jul 21, 2026
View reviewed changes

winterhazel approved these changes Jul 21, 2026
View reviewed changes

winterhazel merged commit 0da3740 into apache:mainJul 21, 2026
22 of 27 checks passed

DaanHoogland deleted the 4.23-nasbackup-ubuntu26 branch July 21, 2026 18:51

Uh oh!

Conversation

weizhouapache commented Jul 17, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecovBot commented Jul 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

winterhazel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 18, 2026

Uh oh!

blueorangutan commented Jul 18, 2026

Uh oh!

winterhazel commented Jul 20, 2026

Uh oh!

abh1sar commented Jul 20, 2026

Uh oh!

abh1sar commented Jul 21, 2026

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Jul 17, 2026•
edited
Loading

winterhazel left a comment •
edited
Loading