Skip to content

Add back missing changes from #10008 to 4.23 - #13817

Draft
winterhazel wants to merge 4 commits into
apache:mainfrom
winterhazel:add-missing-10008-changes
Draft

Add back missing changes from #10008 to 4.23#13817
winterhazel wants to merge 4 commits into
apache:mainfrom
winterhazel:add-missing-10008-changes

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This PR adds back some changes that were missing on the merge-forward of #10008.

Closes#13796.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tests are still pending.

@winterhazel

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecovBot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.41%. Comparing base (4f11707) to head (a59399a).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (4f11707) and HEAD (a59399a). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (4f11707)HEAD (a59399a)
unittests10
Additional details and impacted files
@@ Coverage Diff @@## main #13817 +/- ##
=============================================
- Coverage 19.65% 3.41% -16.24% 
=============================================
Files 6368 487 -5881 Lines 574881 41867 -533014 Branches 70351 7912 -62439 =============================================
- Hits 112970 1429 -111541 + Misses 449639 40238 -409401 + Partials 12272 200 -12072 
FlagCoverage Δ
uitests3.41% <ø> (ø)
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@winterhazelwinterhazel changed the title Add back missing changes from #10008Add back missing changes from #10008 to 4.23Aug 6, 2026
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18784

@weizhouapache

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16724)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55696 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13817-t16724-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@sudo87sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested the changes

@winterhazel
winterhazel marked this pull request as draft August 7, 2026 12:05
@winterhazel

Copy link
Copy Markdown
MemberAuthor

Changing to draft, as I am making some changes to also cover a few cleanups I missed in the original PR that allow the creation of inconsistent entries.

@winterhazel

Copy link
Copy Markdown
MemberAuthor

@sudo87 thank you for testing!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projects listing breaks after deleting a user (Project Admin) added to a project.

4 participants

@winterhazel@blueorangutan@weizhouapache@sudo87