Uh oh!
There was an error while loading. Please reload this page.
zip the processed json files so we save diskspace - #1421
Closed
remibergsma wants to merge 1 commit into
Closed
Conversation
remibergsma
commented
Feb 20, 2016
ContributorAuthor
Test result: |
| timestamp = str(int(round(time.time()))) | ||
| os.rename(origPath, path + "/" + self.fileName + "." + timestamp) | ||
| zipped_file_name = path + "/" + self.fileName + "." + str(uuid.uuid4()) + ".gz" |
Contributor
There was a problem hiding this comment.
would it make sense to have the timestamp in the filename as well? for easy ordering
ContributorAuthor
There was a problem hiding this comment.
The filename becomes quite long in that case. The date is already in the meta data of the file, so one could use ls -latr to get it:
DaanHoogland
commented
Feb 22, 2016
Contributor
LGTM, based on the code and the presented output. |
remibergsmaforce-pushed
the
gzip-processed-json-router-config
branch
from
April 30, 2016 19:12
8b03716 to
d099790Compareremibergsma
commented
Apr 30, 2016
ContributorAuthor
@swill force pushed |
remibergsmaforce-pushed
the
gzip-processed-json-router-config
branch
from
May 1, 2016 09:29
d099790 to
79febd7Compareremibergsma
commented
May 1, 2016
ContributorAuthor
Force pushed again. |
yadvr
commented
May 2, 2016
Member
LGTM tag:mergeready |
swill
commented
May 2, 2016
Contributor
@remibergsma requires force push again. Travis timed out... |
swill
commented
May 2, 2016
Contributor
How do I test this and verify it is working? |
swill
commented
May 6, 2016
Contributor
any suggestions for how to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zip the processed json files and make sure they're unique (timestamp is not unique). Especially in combination with #1400.