Uh oh!
There was an error while loading. Please reload this page.
Restore iptables at once using iptables-restore instead of calling iptables numerous times - #1482
Conversation
…tables numerous times
DaanHoogland
commented
Apr 11, 2016
1482.results.network.txt CI bubble runCommit Reference: 30741a3 Looks good to me |
swill
commented
Apr 28, 2016
@remibergsma please rebase as we currently have merge conflicts with master. Thanks... |
remibergsma
commented
Apr 30, 2016
@swill conflict resolved |
yadvr
commented
May 2, 2016
@remibergsma please rebase against master and squash changes to a single commit tag:needlove |
swill
commented
May 2, 2016
Squash yes, but this can remain open against 4.7 as we are still fixing bugs and such against 4.7 and it is still supported (until 4.9 is released). Anything merged into 4.7 will be forward merged... |
swill
commented
May 6, 2016
@remibergsma can you squash this and re-push. I need one more code review on this one and we should be ready to merge it. Thanks... |
swill
commented
May 11, 2016
@remibergsma just a reminder to squash and re-push so we can get jenkins green. Thx... |
swill
commented
May 12, 2016
@remibergsma can you re-push this one. Jenkins and Travis should be fixed now, so we should be able to get this green with a new push. I am missing one code review on this one. @kiwiflyer and @dmabry did you guys happen to check this one already? I know you guys have been reviewing stuff in this space. Thx... |
kiwiflyer
commented
May 12, 2016
@swill We'll pull this in. |
swill
commented
May 12, 2016
Thanks guys. 👍 |
kiwiflyer
commented
May 12, 2016
ok, I'm just blind and didn't see the additional commit to remove the forceencaps. :-) |
remibergsma
commented
May 12, 2016
@kiwiflyer I'll see if I can get it out completely ;-) |
swill
commented
May 16, 2016
@remibergsma would you mind rebasing and re-pushing? We don't have the reason why Jenkins failed, but Travis passed, so I am considering making a judgment call on this one, but would rather not. Thx... |
kiwiflyer
commented
May 16, 2016
I've done some basic testing of this patch adding and deleting ACLs and rules within ACLs within VPCs. |
kiwiflyer
commented
May 16, 2016
LGTM above from @DaanHoogland as well. |
swill
commented
May 16, 2016
Thank you. I think that bumps this into my judgement call category. 👍 |
Restore iptables at once using iptables-restore instead of calling iptables numerous timesThis makes handling the firewall rules about 50-60 times faster because it is generated in memory and then loaded once. It's work by @borisroman see PR #1400. Reopened it here because I think this is a great improvement. * pr/1482: Resolve conflict as forceencap is already in master Split the cidr lists so we won't hit the iptables-resture limits Check the existence of 'forceencap' parameter before use Do not load previous firewall rules as we replace everyhing anyway Wait for dnsmasq to finish restart Remove duplicate spaces, and thus duplicate rules. Restore iptables at once using iptables-restore instead of calling iptables numerous times Add iptables copnversion script. Signed-off-by: Will Stevens <williamstevens@gmail.com>
* 4.7: Revert "Merge pull request #1482 from remibergsma/iptables-fix"
swill
commented
May 20, 2016
@remibergsma can you give me a status on this PR. I know you reverted it because of missing licenses. Should I be trying to wait for this one to get back in for 4.9? Thx... |
remibergsma
commented
May 22, 2016
@swill Some parts need to be rewritten so that won't be on time I'm afraid. |
swill
commented
May 24, 2016
@remibergsma ok, no problem. Thanks for the heads up. :) |
This makes handling the firewall rules about 50-60 times faster because it is generated in memory and then loaded once. It's work by @borisroman see PR #1400. Reopened it here because I think this is a great improvement.