CLOUDSTACK-8715: Add channel to Instances for Qemu Guest Agent by wido · Pull Request #1545 · apache/cloudstack

wido · 2016-05-13T09:41:10Z

This commit adds a additional VirtIO channel with the name
'org.qemu.guest_agent.0' to all Instances.

With the Qemu Guest Agent the Hypervisor gains more control over the Instance if
these tools are present inside the Instance, for example:

Power control
Flushing filesystems
Fetching Network information

In the future this should allow safer snapshots on KVM since we can instruct the
Instance to flush the filesystems prior to snapshotting the disk.

More information: http://wiki.qemu.org/Features/QAPI/GuestAgent

Keep in mind that on Ubuntu AppArmor still needs to be disabled since the default
AppArmor profile doesn't allow libvirt to write into /var/lib/libvirt/qemu

This commit does not add any communication methods through API-calls, it merely
adds the channel to the Instances and installs the Guest Agent in the SSVMs.

wido · 2016-05-13T09:42:34Z

This PR follows up on #985, but this one does not have a libvirt-java dependency.

It only adds the channel in the XML for all Instances and it installs the Qemu Guest Agent inside the SSVM.

This allows is in the future to use the available channel when libvirt-java has the proper support.

wido · 2016-05-13T12:55:31Z

@swill and @rhtyd could you take a look at this one?

Once we fork libvirt-java (which I want to do when we switch to new repos) we can implement the actual commands in the KVM Agent.

Just having the channels there also allows admins to send commands to Instances using virsh manually.

swill · 2016-05-13T17:17:53Z

Ya, I like this. I think this is a nice advancement. If we are going to try to get this into 4.9, I will need some help getting this moving forward cause we are pretty tight on time. @wido are you running this in production and what can you provide to show it is working as expected? I need to review the details for releasing when including system VM changes. I know we wanted to try to get StrongSwan into this release (assuming we can get it there), so that would require a new system VM template as well.

wido · 2016-05-13T20:35:47Z

@swill Yes, running this in production on our cloud

I just started an Instance and the Agent (backport to 4.8, clean merge) produced this XML:

<domain type='kvm'>
<name>i-2-25-VM</name>
<uuid>bd93ca81-d976-41be-823c-6fc0ea013111</uuid>
<description>Ubuntu 12.04 (64-bit)</description>
<cpu mode='host-passthrough'></cpu><sysinfo type='smbios'>
<system>
<entry name='manufacturer'>Apache Software Foundation</entry>
<entry name='product'>CloudStack KVM Hypervisor</entry>
<entry name='uuid'>bd93ca81-d976-41be-823c-6fc0ea013111</entry>
</system>
</sysinfo>
<os>
<type arch='x86_64' machine='pc'>hvm</type>
<boot dev='cdrom'/>
<boot dev='hd'/>
<smbios mode='sysinfo'/>
</os>
<on_reboot>restart</on_reboot>
<on_poweroff>destroy</on_poweroff>
<on_crash>destroy</on_crash>
<memory>4194304</memory>
<devices>
<memballoon model='none'/>
</devices>
<vcpu>2</vcpu>
<features>
<pae/>
<apic/>
<acpi/>
</features>
<cputune>
<shares>1000</shares>
</cputune>
<clock offset='utc'>
<timer name='kvmclock' >
</timer>
</clock>
<devices>
<emulator>/usr/libexec/qemu-kvm</emulator>
<interface type='bridge'>
<source bridge='cloudbr0'/>
<mac address='06:73:12:00:00:67'/>
<model type='virtio'/>
<bandwidth>
<inbound average='128000' peak='128000'/>
<outbound average='128000' peak='128000'/>
</bandwidth>
</interface>
<console type='pty'>
<target port='0'/>
</console>
<disk device='disk' type='network'>
<driver name='qemu' type='raw' cache='writeback' />
<source protocol='rbd' name='rbd-c01-p01/d70d7e6e-753d-4a0e-ad5f-ec8ac531e32b'>
<host name='monitor.ceph.XXXX.XXXX.XXXXX.nl' port='6789'/>
</source>
<auth username='cloudstack'>
<secret type='ceph' uuid='5e34fd37-1763-3092-9f51-280a31bdb36f'/>
</auth>
<target dev='vda' bus='virtio'/>
<serial>d70d7e6e753d4a0ead5f</serial></disk>
<disk device='disk' type='network'>
<driver name='qemu' type='raw' cache='writeback' />
<source protocol='rbd' name='rbd-c01-p01/3fcb9970-cf63-4251-b1b9-2d916f6ab1c6'>
<host name='monitor.ceph.XXXXX.XXXXXX.XXXXXX.nl' port='6789'/>
</source>
<auth username='cloudstack'>
<secret type='ceph' uuid='5e34fd37-1763-3092-9f51-280a31bdb36f'/>
</auth>
<target dev='vdb' bus='virtio'/>
<serial>3fcb9970cf634251b1b9</serial></disk>
<disk device='cdrom' type='file'>
<driver name='qemu' type='raw' cache='none' />
<source file=''/>
<target dev='hdc' bus='ide'/>
</disk>
<serial type='pty'>
<target port='0'/>
</serial>
<graphics type='vnc' autoport='yes' listen='10.5.0.106' passwd='XXXXXXXX'/>
<channel type='unix'>
<source mode='bind' path='/var/lib/libvirt/qemu/i-2-25-VM.org.qemu.guest_agent.0'/>
<address type='virtio-serial'/>
<target type='virtio' name='org.qemu.guest_agent.0'/>
</channel>
<input type='tablet' bus='usb'/>
</devices>
</domain>

There you see this channel added:

<channel type='unix'>
<source mode='bind' path='/var/lib/libvirt/qemu/i-2-25-VM.org.qemu.guest_agent.0'/>
<address type='virtio-serial'/>
<target type='virtio' name='org.qemu.guest_agent.0'/>
</channel>

In the Ubuntu 14.04 the Guest Agent is running:

root@vhosting-relay:~# ps aux|grep qemu
root 2789 0.0 0.0 17468 700 ? Ss 22:19 0:00 /usr/sbin/qemu-ga --daemonize -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0
root 2890 0.0 0.0 10460 908 pts/6 S+ 22:20 0:00 grep qemu
root@vhosting-relay:~#

From the HV I can send commands through libvirt:

[root@n06 ~]# virsh qemu-agent-command i-2-25-VM '{"execute":"guest-ping"}'
{"return":{}}
[root@n06 ~]#

I also re-started a Console Proxy which has a additional channel, that works as well:

<channel type='unix'>
<source mode='bind' path='/var/lib/libvirt/qemu/v-215-VM.agent'/>
<address type='virtio-serial'/>
<target type='virtio' name='v-215-VM.vport'/>
</channel>
<channel type='unix'>
<source mode='bind' path='/var/lib/libvirt/qemu/v-215-VM.org.qemu.guest_agent.0'/>
<address type='virtio-serial'/>
<target type='virtio' name='org.qemu.guest_agent.0'/>
</channel>

The commands afterwards:

[root@n04 ~]# virsh qemu-agent-command v-215-VM '{"execute":"guest-ping"}'
{"return":{}}
[root@n04 ~]# virsh qemu-agent-command v-215-VM '{"execute":"guest-sync", "arguments":{"id":1234}}'
{"return":1234}
[root@n04 ~]#

By having the channels already in place it is later just a matter of updating libvirt-java and starting to use this communication channel.

wido · 2016-05-13T21:53:39Z

@swill I added a small fix for inside the SSVM. During some additional manual testing I found that the SSVM is picky in the order in the XML definition.

My second commit makes sure it doesn't use the first VirtIO port, but uses the proper port.

I tested that fix in production as well, works just fine.

swill · 2016-05-13T21:54:51Z

ok, thank you sir. 👍

wido · 2016-05-19T08:43:29Z

@rhtyd and @DaanHoogland Could you maybe take a quick look at this one? We could finally get the first part of this in.

DaanHoogland · 2016-05-19T09:28:18Z

-final VirtioSerialDef vserial = new VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + vmTO.getName() + ".agent"));


these names and paths should not be hardcoded here.

agree, @wido do you mind moving them something configurable via global settings or agent.properties

This has always been hardcoded, it's just that I'm moving this part.
This is the SSVM socket which is already there. The socket patch code wants to find the .agent there. Not much I can do there.

DaanHoogland · 2016-05-19T09:36:49Z

apart from some code style and convention things LGTM

yadvr · 2016-05-19T09:46:04Z

+ String state = getAttrValue("target", "state", channel);
+
+ ChannelDef def = null;
+ if (state == null || state.length() == 0) {


we can use Strings.isNullOrEmpty here

yadvr · 2016-05-19T09:51:25Z

In general, a good idea and would be useful for flushing out disk IO and doing clean shutdown of VRs and vms. There are some outstanding issues, but the feature is nice.

I've not tested this, I suppose @wido would have tested this for Debian/Ubuntu based kvm hosts, we'll also need testing efforts on centos6 and 7 based kvm hosts.

DaanHoogland · 2016-05-19T10:04:28Z

@swill, did this pass the (not so C)I?

wido · 2016-05-19T14:32:42Z

Thanks for the feedback, I will work on that tomorrow.

@rhtyd I tested this on both Ubuntu and CentOS systems.

The main issue with Ubuntu is AppArmor where libvirt isn't allowed to write in /var/lib/qemu.

I'll make that directory configurable, but keep in mind that on all platforms I know that is the directory where the sockets are stored.

swill · 2016-05-19T15:44:47Z

Sorry, I need to queue this one up... I will wait for @wido's changes though so I am testing his latest code.

wido · 2016-05-19T20:21:12Z

@swill I will work on the changes tomorrow morning (my time, CET). Shouldn't be very hard to do.

swill · 2016-05-20T04:04:26Z

CI RESULTS

Tests Run: 78
Skipped: 0
Failed: 0
Errors: 4
Duration: 7h 47m 49s

Summary of the problem(s):

ERROR: test suite for <class 'integration.smoke.test_internal_lb.TestInternalLb'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 296, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt

ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt

ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt

ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_37_29_UK7LQG:

/tmp/MarvinLogs/test_network_YJVJO9:

/tmp/MarvinLogs/test_vpc_routers_NDLJQN:

Uploads will be available until 2016-07-20 02:00:00 +0200 CEST

Comment created by upr comment.

swill · 2016-05-20T04:05:19Z

These failures are not related to this PR, but if you have ideas why they are happening I would be interested. I will wait till @wido has a chance to work on this PR to run the CI again. Thx...

yadvr · 2016-11-21T07:51:32Z

@blueorangutan test

blueorangutan · 2016-11-21T07:52:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2016-11-21T10:24:30Z

@wido the Trillian env failed to run the tests for your latest PR due to following error:
2016-11-21 09:59:54,000 INFO [cloud.agent.AgentShell] (main:null) (logid:) Agent started
2016-11-21 09:59:54,005 INFO [cloud.agent.AgentShell] (main:null) (logid:) Implementation Version is 4.10.0.0-SNAPSHOT
2016-11-21 09:59:54,007 INFO [cloud.agent.AgentShell] (main:null) (logid:) agent.properties found at /etc/cloudstack/agent/agent.properties
2016-11-21 09:59:54,013 INFO [cloud.agent.AgentShell] (main:null) (logid:) Defaulting to using properties file for storage
2016-11-21 09:59:54,016 INFO [cloud.agent.AgentShell] (main:null) (logid:) Defaulting to the constant time backoff algorithm
2016-11-21 09:59:54,035 INFO [cloud.utils.LogUtils] (main:null) (logid:) log4j configuration found at /etc/cloudstack/agent/log4j-cloud.xml
2016-11-21 09:59:54,050 INFO [cloud.agent.AgentShell] (main:null) (logid:) Using default Java settings for IPv6 preference for agent connection
2016-11-21 09:59:54,211 INFO [cloud.agent.Agent] (main:null) (logid:) id is
2016-11-21 09:59:54,251 ERROR [cloud.agent.AgentShell] (main:null) (logid:) Unable to start agent:
java.lang.NullPointerException
at java.io.File.(File.java:277)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:786)
at com.cloud.agent.Agent.(Agent.java:165)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:397)
at com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
at com.cloud.agent.AgentShell.start(AgentShell.java:456)
at com.cloud.agent.AgentShell.main(AgentShell.java:491)

Please modify the code to still work where an explicit path may not be defined, and that with your change KVM agent would run on CentOS6/7. Thanks.
/cc @jburwell

wido · 2016-11-23T11:13:37Z

@jburwell @rhtyd I fixed most of the comments.

The NPE should be fixed and the StringUtils comments as well. I didn't refactor the other stuff @jburwell mentioned as my code is in-line with how the existing classes are written in the same files.

A new PR could do a refactor of those whole files, but it wouldn't change anything for a end-result. The functionality is still that we have a Qemu Guest Agent inside the VMs.

But this PR is open since May. Could we please merge this one in?

yadvr · 2016-11-23T11:18:06Z

@wido can you confirm if you've fixed the NPE issue I've shared in the comment above?
java.lang.NullPointerException
at java.io.File.(File.java:277)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:786)
at com.

wido · 2016-11-23T11:22:33Z

Yes @rhtyd, I added a check for NULL there.

yadvr · 2016-11-23T11:28:11Z

@wido alright, I'll initiate a final test round -- if that passes we can consider merging. /cc @jburwell

yadvr · 2016-11-23T11:28:18Z

@blueorangutan package

blueorangutan · 2016-11-23T11:29:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-11-23T11:52:44Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-237

yadvr · 2016-11-23T11:55:50Z

@blueorangutan test

blueorangutan · 2016-11-23T11:56:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2016-11-23T12:10:36Z

@wido please fix the build failures:
[INFO] Starting audit...
/jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java:31:8: error: Unused import - com.cloud.utils.StringUtils.
Audit done.

This commit adds a additional VirtIO channel with the name 'org.qemu.guest_agent.0' to all Instances. With the Qemu Guest Agent the Hypervisor gains more control over the Instance if these tools are present inside the Instance, for example: * Power control * Flushing filesystems * Fetching Network information In the future this should allow safer snapshots on KVM since we can instruct the Instance to flush the filesystems prior to snapshotting the disk. More information: http://wiki.qemu.org/Features/QAPI/GuestAgent Keep in mind that on Ubuntu AppArmor still needs to be disabled since the default AppArmor profile doesn't allow libvirt to write into /var/lib/libvirt/qemu This commit does not add any communication methods through API-calls, it merely adds the channel to the Instances and installs the Guest Agent in the SSVMs. With the addition of the Qemu Guest Agent channel a second channel appears in /dev on a SSVM as a VirtIO port. The order in which the ports are defined in the XML matters for the naming inside the SSVM VM and by not relying on /dev/vportXX but looking for a static name the SSVM still boots properly if the order in the XML definition is changed. A SSVM with both ports attached will have something like this: root@v-215-VM:~# ls -l /dev/virtio-ports total 0 lrwxrwxrwx 1 root root 11 May 13 21:41 org.qemu.guest_agent.0 -> ../vport0p2 lrwxrwxrwx 1 root root 11 May 13 21:41 v-215-VM.vport -> ../vport0p1 root@v-215-VM:~# ls -l /dev/vport* crw------- 1 root root 251, 1 May 13 21:41 /dev/vport0p1 crw------- 1 root root 251, 2 May 13 21:41 /dev/vport0p2 root@v-215-VM:~# In this case the SSVM port points to /dev/vport0p1, but if the order in the XML is different it might point to /dev/vport0p2 By looking for a portname with a pre-defined pattern in /dev/virtio-ports we do not rely on the order in the XML definition. Signed-off-by: Wido den Hollander <wido@widodh.nl>

wido · 2016-11-23T15:02:15Z

@rhtyd Yes, fixed. Forgot to commit that change locally. Pushed a new version.

yadvr · 2016-11-23T15:57:25Z

@blueorangutan package

blueorangutan · 2016-11-23T15:58:02Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-11-23T16:37:15Z

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-239

yadvr · 2016-11-24T06:42:32Z

@blueorangutan package

blueorangutan · 2016-11-24T06:43:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-11-24T07:31:14Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-240

yadvr · 2016-11-24T07:45:32Z

@blueorangutan test

blueorangutan · 2016-11-24T07:46:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2016-11-24T15:57:48Z

Trillian test result (tid-421)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29503 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1545-t421-kvm-centos7.zip
Test completed. 48 look ok, 1 have error(s)

Test	Result	Time (s)	Test File
test_01_create_template	`Error`	55.62	test_templates.py
test_01_vpc_site2site_vpn	Success	166.49	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	Success	66.20	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	Success	321.26	test_vpc_vpn.py
test_02_VPC_default_routes	Success	311.06	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	Success	552.87	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	Success	534.88	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Success	1427.78	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Success	564.46	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	Success	823.05	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Success	1359.34	test_vpc_redundant.py
test_09_delete_detached_volume	Success	15.67	test_volumes.py
test_08_resize_volume	Success	15.46	test_volumes.py
test_07_resize_fail	Success	20.53	test_volumes.py
test_06_download_detached_volume	Success	15.38	test_volumes.py
test_05_detach_volume	Success	100.28	test_volumes.py
test_04_delete_attached_volume	Success	10.27	test_volumes.py
test_03_download_attached_volume	Success	15.36	test_volumes.py
test_02_attach_volume	Success	43.75	test_volumes.py
test_01_create_volume	Success	621.70	test_volumes.py
test_deploy_vm_multiple	Success	299.13	test_vm_life_cycle.py
test_deploy_vm	Success	0.04	test_vm_life_cycle.py
test_advZoneVirtualRouter	Success	0.03	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Success	27.20	test_vm_life_cycle.py
test_09_expunge_vm	Success	125.26	test_vm_life_cycle.py
test_08_migrate_vm	Success	36.04	test_vm_life_cycle.py
test_07_restore_vm	Success	0.15	test_vm_life_cycle.py
test_06_destroy_vm	Success	130.98	test_vm_life_cycle.py
test_03_reboot_vm	Success	131.14	test_vm_life_cycle.py
test_02_start_vm	Success	10.20	test_vm_life_cycle.py
test_01_stop_vm	Success	40.37	test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName	Success	176.45	test_templates.py
test_08_list_system_templates	Success	0.03	test_templates.py
test_07_list_public_templates	Success	0.05	test_templates.py
test_05_template_permissions	Success	0.13	test_templates.py
test_04_extract_template	Success	5.16	test_templates.py
test_03_delete_template	Success	5.13	test_templates.py
test_02_edit_template	Success	90.17	test_templates.py
test_10_destroy_cpvm	Success	166.77	test_ssvm.py
test_09_destroy_ssvm	Success	198.98	test_ssvm.py
test_08_reboot_cpvm	Success	136.74	test_ssvm.py
test_07_reboot_ssvm	Success	139.10	test_ssvm.py
test_06_stop_cpvm	Success	167.17	test_ssvm.py
test_05_stop_ssvm	Success	168.95	test_ssvm.py
test_04_cpvm_internals	Success	1.24	test_ssvm.py
test_03_ssvm_internals	Success	3.92	test_ssvm.py
test_02_list_cpvm_vm	Success	0.14	test_ssvm.py
test_01_list_sec_storage_vm	Success	0.17	test_ssvm.py
test_01_snapshot_root_disk	Success	21.61	test_snapshots.py
test_04_change_offering_small	Success	215.40	test_service_offerings.py
test_03_delete_service_offering	Success	0.05	test_service_offerings.py
test_02_edit_service_offering	Success	0.10	test_service_offerings.py
test_01_create_service_offering	Success	0.16	test_service_offerings.py
test_02_sys_template_ready	Success	0.14	test_secondary_storage.py
test_01_sys_vm_start	Success	0.20	test_secondary_storage.py
test_09_reboot_router	Success	55.49	test_routers.py
test_08_start_router	Success	35.39	test_routers.py
test_07_stop_router	Success	15.23	test_routers.py
test_06_router_advanced	Success	0.06	test_routers.py
test_05_router_basic	Success	0.06	test_routers.py
test_04_restart_network_wo_cleanup	Success	5.75	test_routers.py
test_03_restart_network_cleanup	Success	75.67	test_routers.py
test_02_router_internal_adv	Success	1.05	test_routers.py
test_01_router_internal_basic	Success	0.58	test_routers.py
test_router_dns_guestipquery	Success	78.25	test_router_dns.py
test_router_dns_externalipquery	Success	0.08	test_router_dns.py
test_router_dhcphosts	Success	287.06	test_router_dhcphosts.py
test_01_updatevolumedetail	Success	0.12	test_resource_detail.py
test_01_reset_vm_on_reboot	Success	186.54	test_reset_vm_on_reboot.py
test_createRegion	Success	0.06	test_regions.py
test_create_pvlan_network	Success	5.29	test_pvlan.py
test_dedicatePublicIpRange	Success	0.61	test_public_ip_range.py
test_04_rvpc_privategw_static_routes	Success	1087.09	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Success	609.67	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Success	508.03	test_privategw_acl.py
test_01_vpc_privategw_acl	Success	108.70	test_privategw_acl.py
test_01_primary_storage_nfs	Success	36.09	test_primary_storage.py
test_createPortablePublicIPRange	Success	10.39	test_portable_publicip.py
test_createPortablePublicIPAcquire	Success	15.50	test_portable_publicip.py
test_isolate_network_password_server	Success	90.10	test_password_server.py
test_UpdateStorageOverProvisioningFactor	Success	0.17	test_over_provisioning.py
test_oobm_zchange_password	Success	21.02	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	Success	16.52	test_outofbandmanagement.py
test_oobm_issue_power_status	Success	11.01	test_outofbandmanagement.py
test_oobm_issue_power_soft	Success	15.53	test_outofbandmanagement.py
test_oobm_issue_power_reset	Success	15.55	test_outofbandmanagement.py
test_oobm_issue_power_on	Success	15.52	test_outofbandmanagement.py
test_oobm_issue_power_off	Success	15.52	test_outofbandmanagement.py
test_oobm_issue_power_cycle	Success	15.51	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	Success	62.76	test_outofbandmanagement.py
test_oobm_enable_feature_valid	Success	5.28	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	Success	0.18	test_outofbandmanagement.py
test_oobm_disable_feature_valid	Success	0.28	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	Success	0.24	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	Success	0.14	test_outofbandmanagement.py
test_oobm_configure_default_driver	Success	0.18	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	Success	23.87	test_outofbandmanagement.py
test_extendPhysicalNetworkVlan	Success	15.35	test_non_contigiousvlan.py
test_01_nic	Success	637.54	test_nic.py
test_releaseIP	Success	349.88	test_network.py
test_reboot_router	Success	470.65	test_network.py
test_public_ip_user_account	Success	10.32	test_network.py
test_public_ip_admin_account	Success	40.29	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	Success	67.18	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	Success	61.99	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	Success	124.50	test_network.py
test_delete_account	Success	279.31	test_network.py
test_02_port_fwd_on_non_src_nat	Success	56.17	test_network.py
test_01_port_fwd_on_src_nat	Success	112.02	test_network.py
test_nic_secondaryip_add_remove	Success	254.25	test_multipleips_per_nic.py
login_test_saml_user	Success	26.37	test_login.py
test_assign_and_removal_lb	Success	134.19	test_loadbalance.py
test_02_create_lb_rule_non_nat	Success	187.98	test_loadbalance.py
test_01_create_lb_rule_src_nat	Success	240.15	test_loadbalance.py
test_03_list_snapshots	Success	0.11	test_list_ids_parameter.py
test_02_list_templates	Success	0.05	test_list_ids_parameter.py
test_01_list_volumes	Success	0.04	test_list_ids_parameter.py
test_07_list_default_iso	Success	0.07	test_iso.py
test_05_iso_permissions	Success	0.07	test_iso.py
test_04_extract_Iso	Success	5.59	test_iso.py
test_03_delete_iso	Success	95.21	test_iso.py
test_02_edit_iso	Success	0.06	test_iso.py
test_01_create_iso	Success	22.49	test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Success	309.76	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Success	309.27	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Success	679.36	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Success	502.22	test_internal_lb.py
test_dedicateGuestVlanRange	Success	10.35	test_guest_vlan_range.py
test_UpdateConfigParamWithScope	Success	0.16	test_global_settings.py
test_rolepermission_lifecycle_update	Success	7.57	test_dynamicroles.py
test_rolepermission_lifecycle_list	Success	7.54	test_dynamicroles.py
test_rolepermission_lifecycle_delete	Success	6.98	test_dynamicroles.py
test_rolepermission_lifecycle_create	Success	7.08	test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates	Success	7.01	test_dynamicroles.py
test_role_lifecycle_update_role_inuse	Success	6.88	test_dynamicroles.py
test_role_lifecycle_update	Success	12.69	test_dynamicroles.py
test_role_lifecycle_list	Success	6.99	test_dynamicroles.py
test_role_lifecycle_delete	Success	12.14	test_dynamicroles.py
test_role_lifecycle_create	Success	7.28	test_dynamicroles.py
test_role_inuse_deletion	Success	6.81	test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers	Success	9.48	test_dynamicroles.py
test_role_account_acls	Success	9.53	test_dynamicroles.py
test_default_role_deletion	Success	7.23	test_dynamicroles.py
test_04_create_fat_type_disk_offering	Success	0.11	test_disk_offerings.py
test_03_delete_disk_offering	Success	0.04	test_disk_offerings.py
test_02_edit_disk_offering	Success	0.05	test_disk_offerings.py
test_02_create_sparse_type_disk_offering	Success	0.07	test_disk_offerings.py
test_01_create_disk_offering	Success	0.11	test_disk_offerings.py
test_deployvm_userdispersing	Success	20.75	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	Success	20.79	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit	Success	50.68	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post	Success	5.45	test_deploy_vm_with_userdata.py
test_deployvm_userdata	Success	46.14	test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize	Success	6.93	test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize	Success	7.20	test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize	Success	279.09	test_deploy_vm_root_resize.py
test_deploy_vm_from_iso	Success	218.50	test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup	Success	96.33	test_affinity_groups.py
test_03_delete_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_02_revert_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_01_test_vm_volume_snapshot	Skipped	0.00	test_vm_snapshots.py
test_01_create_vm_snapshots	Skipped	0.00	test_vm_snapshots.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.05	test_primary_storage.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.04	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

yadvr · 2016-11-24T17:41:00Z

LGTM, the tests are all good as one (one failure was due to cleanup in the create template test case and was env related). Based on this I'm merging this.

CLOUDSTACK-8715: Add channel to Instances for Qemu Guest Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

wido mentioned this pull request May 13, 2016
CLOUDSTACK-8715: Add VirtIO channel to all Instances for the Qemu Gue… #985
Closed

wido force-pushed the qemu-guest-agent branch from 58a591c to afe55eaCompare May 13, 2016 10:02

wido force-pushed the qemu-guest-agent branch from afe55ea to ecfd1d3Compare May 13, 2016 21:29

wido force-pushed the qemu-guest-agent branch 2 times, most recently from 2e65de2 to 7ac6627Compare May 14, 2016 07:56

wido mentioned this pull request May 17, 2016
Kvm plugin restructure #1521
Closed

DaanHoogland reviewed May 19, 2016
View reviewed changes

yadvr reviewed May 19, 2016
View reviewed changes

wido force-pushed the qemu-guest-agent branch 2 times, most recently from fb41aaa to 7960733Compare May 20, 2016 10:00

wido force-pushed the qemu-guest-agent branch from 87da276 to 9d84868Compare November 23, 2016 11:10

wido force-pushed the qemu-guest-agent branch from 9d84868 to 221b27eCompare November 23, 2016 11:22

wido force-pushed the qemu-guest-agent branch from 221b27e to 2a5f37cCompare November 23, 2016 15:01

asfgit merged commit 2a5f37c into apache:masterNov 24, 2016

asfgit pushed a commit that referenced this pull request Nov 24, 2016
Merge PR#1545
16c2761
CLOUDSTACK-8715: Add channel to Instances for Qemu Guest Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Uh oh!

Conversation

wido commented May 13, 2016

Uh oh!

wido commented May 13, 2016

Uh oh!

wido commented May 13, 2016

Uh oh!

swill commented May 13, 2016

Uh oh!

wido commented May 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido commented May 13, 2016

Uh oh!

swill commented May 13, 2016

Uh oh!

wido commented May 19, 2016

Uh oh!

DaanHooglandMay 19, 2016

Choose a reason for hiding this comment

Uh oh!

yadvrMay 19, 2016

Choose a reason for hiding this comment

Uh oh!

widoMay 19, 2016

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented May 19, 2016

Uh oh!

yadvrMay 19, 2016

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 19, 2016

Uh oh!

DaanHoogland commented May 19, 2016

Uh oh!

wido commented May 19, 2016

Uh oh!

swill commented May 19, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido commented May 19, 2016

Uh oh!

swill commented May 20, 2016

CI RESULTS

Uh oh!

swill commented May 20, 2016

Uh oh!

yadvr commented Nov 21, 2016

Uh oh!

blueorangutan commented Nov 21, 2016

Uh oh!

yadvr commented Nov 21, 2016

Uh oh!

wido commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

wido commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

blueorangutan commented Nov 23, 2016

Uh oh!

blueorangutan commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

blueorangutan commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

wido commented Nov 23, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

blueorangutan commented Nov 23, 2016

wido commented May 13, 2016•
edited
Loading

swill commented May 19, 2016•
edited
Loading