Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANs by The-Loeki · Pull Request #1547 · apache/cloudstack

The-Loeki · 2016-05-13T14:04:36Z

During the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in our setups.

This PR fixes a number of things:

Multiple IP's per VLAN interface are now supported & working again, including DNS, DHCP ranges, password and metadata services
useextdns fixed (I had a small merge conflict with an attempt to fix this at 4.7, but these fixes are more comprehensive)
CLOUDSTACK-8303
Apache configs better in line with best-practices and distro-expected locations
Added a few more helper functions & getters & setters for utility
some minor cleanup & fixes

DaanHoogland · 2016-05-13T14:09:20Z

 def get_dns(self):
+ conf = self.cmdline().idata()
 dns = []
+<<<<<<< e09480728f4ed77d0bd0bdc6a6c0966d90f7ee26


I think you want to squash these out with the last commit in your PR. We wouldn't want this in our history you dutch commercial fan ;)

Yeah spotted it just too late... Thought I fixxed it but my git-merge-fu isn't fully up to spec yet ;)

DaanHoogland · 2016-05-13T14:10:54Z

@The-Loeki 6 commits with the same message is not helpful and indeed confusing. Can you change them to shortly describe the individual fixes, or if you must squash them?

The-Loeki · 2016-05-13T14:11:19Z

@DaanHoogland click on the (...) 👯

DaanHoogland · 2016-05-13T14:12:21Z

@The-Loeki those don't show in a short listing

The-Loeki · 2016-05-13T14:39:10Z

@DaanHoogland like it better now?

DaanHoogland · 2016-05-13T14:42:57Z

👍 maybe squash the conflict entries out?
you can rebase -i HEAD^7 and then reorder the commits. If you put the last one at position 3 and change the prefix 'pick' to 'f' for fixup you should be fine.

The-Loeki · 2016-05-13T16:33:57Z

Like this then 🎯

DaanHoogland · 2016-05-13T18:21:59Z

I like the first two.
The third should read something like:
CLOUDSTACK-8303 allow multiple ranges & finite lease time
the 4th and 5th I really need to think about but these are not very concise or clear
the 6th could be something like

Fixing router ipaddress issues
cleanup imports,
fix get_str(),
improve & fix service post_config logic

that way all the info is there for who takes the trouble to click the (...) and for those that are to lazy there is a clear subtract in less then 72 chars.

DaanHoogland · 2016-05-15T08:41:10Z

started the integration tests on this

DaanHoogland · 2016-05-15T09:02:16Z

code looks clean. I don't understand all if it yet so I may ask questions yet. but anaother set of eyes required;
tag:needsreview

DaanHoogland · 2016-05-15T17:49:39Z

@swill can you schedule this one. Would be nice to get in before freeze. Mine test effort failed (see dev@)

ustcweizhou · 2016-05-16T06:28:36Z

+ conf = self.cmdline().idata()
 dns = []
- if not self.cl.get_use_ext_dns():
- if not self.is_vpc() and self.cl.is_redundant():


these should not be changed.

please explain @ustcweizhou?

@DaanHoogland As I can see, the CsGuestNetwork means the vpc tiers.
For isolated networks/shared networks, the dns is set in CsConfig.get_dns().
So, I think the change in CsConfig.get_dns() is wrong.

@ustcweizhou / @DaanHoogland: This should revert the behaviour

ustcweizhou · 2016-05-16T06:30:52Z

guys, please donot merge the changes on VR before a LGTM with functional testing.
the changes on VR should be careful and careful.
a code review and an integration test are not enough.

DaanHoogland · 2016-05-16T12:00:41Z

@ustcweizhou the integration tests are functional tests. If there is extra functionality to be tested please provide the test for it. And at least describe what is missing in the tests, here
You are of course right that we should be carefull with these, but given that @The-Loeki works at PCExtreme, I would not be surprised if this runs in production at the moment.

The-Loeki · 2016-05-17T12:59:12Z

@DaanHoogland is correct; we're running this code in test-production. Keep in mind however that we only use Basic Networking Zones, so I did my best to keep the behaviour in other circumstances (barring obvious bugs) the same, but I can't test those either.

Regarding @ustcweizhou 's comment; the only change I perceive there is that, analogous to what's in the CsGuestNetwork, the code seems to imply that the router_guest_gateway will be added as DNS server in the case the SysVM is either a VPC or a redundant router.

As I encountered a merge conflict while building this PR, I think this is a relatively new conditional which seems to mirror the one (incorrectly) in CsGuestNetwork (one depends on the is_vpc() or is_redundant(), the other depends on the availability of the router_guest_gateway key).

If this both is true, I propose to change the has_dns() method to incorporate this logic and merge the same decision in CsGuestNetwork with that.

On the tests side, the (re)added use_extdns and ipaliases functionality both seem to lack functional testing.

DaanHoogland · 2016-05-17T13:10:47Z

@The-Loeki maybe it makes sense to split the PR, especially on the part where there is discussion.

The-Loeki · 2016-05-17T15:26:46Z

Maybe, but for now it's still just one conditional which needs just one decision/explanation.
On the plus side, if the decision can be taken in CsConfig correctly and CsGuestNetwork can employ the same logic this reduces code duplication and improves the overall quality.

swill · 2016-05-17T15:43:29Z

I am currently testing this in both a basic and advanced zone. I will post results when I have them...

swill · 2016-05-17T19:29:17Z

CI RESULTS

Tests Run: 57
Skipped: 0
Failed: 18
Errors: 37
Duration: 2h 54m 41s

NOTE: THIS IS THE FIRST TIME I HAVE EVER RUN CI AGAINST A BASIC NETWORKING CONFIG, SO I DON'T KNOW WHAT ERRORS OF THESE ARE GOING TO HAPPEN ON MASTER.

Summary of the problem(s):

ERROR: Test restart network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 388, in test_03_restart_network_cleanup
self.apiclient.restartNetwork(cmd)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2145, in restartNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:15:44+0200', cmd : u'org.apache.cloudstack.api.command.user.network.RestartNetworkCmd', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'4cfda548-c261-473e-9b28-64153433c766', jobresultcode : 530, jobresulttype : u'object', jobresult : {errorcode : 530, errortext : u'Failed to restart network'}, accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_reset_vm_on_reboot.py", line 75, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:31:58+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'dd63665e-7c16-41ef-9ac1-94f9c9479515', jobresultcode : 530, jobinstanceid : u'183e2185-7722-4a58-afbb-551a36bbdb08', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestDeployVM'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 95, in setUpClass
mode=cls.services['mode']
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:47:53+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'2d2fdeef-093d-47e5-857e-8d7d72adc18e', jobresultcode : 530, jobinstanceid : u'663fca3c-0b1c-4517-b9af-c6176de609b1', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestVMLifeCycle'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 312, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:03:23+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'77d899a2-b3a9-46b5-b3cc-0d58ebc683da', jobresultcode : 530, jobinstanceid : u'4601556f-27eb-492f-9e56-2ec68db36208', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_service_offerings.TestServiceOfferings'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_service_offerings.py", line 202, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:20:33+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'f89bff99-e8fe-45a5-a043-700eba171f8a', jobresultcode : 530, jobinstanceid : u'406bb071-4c06-4531-8af1-23f6397ff1d0', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test for delete account
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 924, in setUp
serviceofferingid=self.service_offering.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:35:52+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'673ba199-907e-4ba6-b213-d423bb85d91f', jobresultcode : 530, jobinstanceid : u'ccf57397-7cc0-4ead-8b0c-155bb77d4b7b', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_network.TestPublicIP'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 104, in setUpClass
cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test for release public IP address
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 785, in setUp
serviceofferingid=self.service_offering.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:51:23+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'5df5ae03-0cd8-4d36-a270-6e7ae0ada521', jobresultcode : 530, jobinstanceid : u'11451e9b-b647-4111-99b2-6b343834cb22', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test VPC offering without load balancing service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 553, in test_03_vpc_off_without_lb
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test VPC offering without static NAT service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 675, in test_04_vpc_off_without_static_nat
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test VPC offering without port forwarding service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 799, in test_05_vpc_off_without_pf
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: Test update VPC offering
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 943, in test_07_update_vpc_off
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 1178, in test_09_create_redundant_vpc_offering
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.component.test_vpc_routers.TestVPCRouterOneNetwork'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_routers.py", line 681, in setUpClass
domainid=cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.component.test_vpc_routers.TestVPCRoutersBasic'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_routers.py", line 243, in setUpClass
domainid=cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test router internal advanced zone
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 222, in test_02_router_internal_adv
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test router basic setup
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 556, in test_05_router_basic
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test router advanced setup
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 622, in test_06_router_advanced
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test stop router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 703, in test_07_stop_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test start router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 746, in test_08_start_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

FAIL: Test reboot router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 798, in test_09_reboot_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt

ERROR: test suite for <class 'integration.smoke.test_password_server.TestIsolatedNetworksPasswdServer'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_password_server.py", line 110, in setUpClass
zoneid=cls.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a redundant VPC with two networks with two VMs in each network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a redundant VPC with two networks with two VMs in each network and check default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a redundant VPC with two networks with two VMs in each network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test iptables default INPUT/FORWARD policies on VPC router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py", line 273, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 729, in test_01_isolate_network_FW_PF_default_routes_egress_true
zoneid=self.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 885, in test_02_isolate_network_FW_PF_default_routes_egress_false
zoneid=self.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 170, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 335, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 510, in test_03_RVR_Network_check_router_state
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a VPC with two networks with one VM in each network and test nics after destroy
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 243, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Create a VPC with two networks with one VM in each network and test default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 243, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: test suite for <class 'integration.smoke.test_router_dhcphosts.TestRouterDHCPHosts'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_router_dhcphosts.py", line 110, in setUpClass
zoneid=cls.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: test suite for <class 'integration.smoke.test_loadbalance.TestLoadBalance'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_loadbalance.py", line 93, in setUpClass
cls.services["virtual_machine"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test Remote Access VPN in VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 336, in test_01_vpc_remote_access_vpn
self.assert_(vpc is not None, "VPC creation failed")
UnboundLocalError: local variable 'vpc' referenced before assignment
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test for port forwarding on non source NAT
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 459, in test_02_port_fwd_on_non_src_nat
self.services["virtual_machine"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test for reboot router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 630, in setUp
e)
Exception: Warning: Exception during fetching source NAT: 'NoneType' object has no attribute '__getitem__'
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test iptables default INPUT/FORWARD policy on RouterVM
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py", line 418, in test_02_routervm_iptables_policies
"Check for list routers response return valid data")
AssertionError: Check for list routers response return valid data
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 599, in test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
self.execute_internallb_roundrobin_tests(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 635, in execute_internallb_roundrobin_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 617, in test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80
self.execute_internallb_roundrobin_tests(redundant_vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 635, in execute_internallb_roundrobin_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test to verify access to loadbalancer haproxy admin stats page
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 763, in test_03_vpc_internallb_haproxy_stats_on_all_interfaces
self.execute_internallb_haproxy_tests(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 807, in execute_internallb_haproxy_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test to verify access to loadbalancer haproxy admin stats page
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 784, in test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
self.execute_internallb_haproxy_tests(redundant_vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 807, in execute_internallb_haproxy_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test Site 2 Site VPN Across redundant VPCs
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 965, in test_01_redundant_vpc_site2site_vpn
self.assert_(vpc1 is not None, "VPC1 creation failed")
AssertionError: VPC1 creation failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test Site 2 Site VPN Across VPCs
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 598, in test_01_vpc_site2site_vpn
self.assert_(vpc1 is not None, "VPC1 creation failed")
AssertionError: VPC1 creation failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 235, in test_01_vpc_privategw_acl
vpc = self.createVPC(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified ----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 262, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified ----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 274, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, restart_with_cleanup = True)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified ----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: test_04_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 286, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified ----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

FAIL: Test for port forwarding on source NAT
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 332, in test_01_port_fwd_on_src_nat
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_07_26_DIMQZZ:

/tmp/MarvinLogs/test_network_F4VHF4:

/tmp/MarvinLogs/test_vpc_offerings_CCC6Z5:

Uploads will be available until 2016-07-17 02:00:00 +0200 CEST

Comment created by upr comment.

swill · 2016-05-17T19:45:51Z

I think we can ignore a lot of this. My tests are mainly setup to test advanced networking. I have to revisit this to know how to test the basic networking stuff correctly. I have tests running against this PR for advanced networking to see if anything is broken on the advanced side because of this.

DaanHoogland · 2016-05-17T20:20:46Z

@swill I think @ustcweizhou has a point. So at least that one commit tag:needslove. The rest should pass our regular suite. We can also create a Marvin definition for a basic zone and run tests on those. @The-Loeki @wido do you have a suitable definition to match your environment ready?

swill · 2016-05-18T02:51:09Z

CI RESULTS

Tests Run: 83
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 52m 19s

Summary of the problem(s):

ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F29Y8L/results.txt

ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F29Y8L/results.txt

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_12_26_5B9U17:

/tmp/MarvinLogs/test_network_F29Y8L:

/tmp/MarvinLogs/test_vpc_routers_OX8K0O:

Uploads will be available until 2016-07-18 02:00:00 +0200 CEST

Comment created by upr comment.

swill · 2016-05-18T02:52:50Z

I have seen these errors on two other PRs tonight, so I don't think they are related to this PR. I think this is a pretty clean CI result. I need to track down where those errors come from and see if they are on master right now as well.

BTW, these results are for an Advanced zone. So this just verifies that this did not introduce new bugs for that use case. We still need proper tests for a Basic zone setup.

wido · 2016-05-18T07:43:40Z

@DaanHoogland I haven't touched this code much. @The-Loeki ran into this issue when working on our Private Cloud (which is where we test upgrades first).

We don't have a modified Marvin suite. The main problem was when you have multiple IPv4 ranges in a POD only the first/primary one would be configured on the VR.

This PR is to make sure that the VR configures all ranges sent to it.

linas-ipxo · 2016-05-18T07:49:36Z

Disclaimer: i'm very new to the whole ACS, but i have built and deployed custom releases for ourselves. I understand the project structure somewhat.

So..
I've applied these commits to 4.8 branch (since that's what we're trying to use at the moment). They appear to be standalone and not affected by other parts of ACS, so 4.8 should be fine. (correct me if i'm wrong)

I'm using advanced networking with security groups.

After these patches, the VR doesn't load - fails when the scripts get executed with KeyErorr 'gateway'. This is in the ipaliases part. I'm not sure what the ip aliases are for there, but it would seem strange that it an ip alias would require gateway.
I've modified "process_ipaliases(self, dbag)" to include a fake gateway in the ipalias data, and the VR started successfully.

DaanHoogland · 2016-06-07T11:19:08Z

Yes @wido ,they look good to me but I am not running a cloud at the moment so hence I asked @ustcweizhou to have a look.
He had concerns but I did not see him react since.
The test I did were in advanced zone so we do have a rather broad coverage so far.

wido · 2016-06-07T19:00:05Z

Ok, thanks @DaanHoogland , sounds good!

Looking forward to more input or LGTMs :)

remibergsma · 2016-06-08T09:28:46Z

I see some tests failing on VPCs:

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
test_02_redundant_VPC_default_routes

Will rebuild from scratch to see if it fails again.

wido · 2016-06-08T14:38:23Z

@remi: Thanks for the feedback! @DaanHoogland reported a failure as well, but his second test succeeded without any problems.

I don't have experience with VPC, but as far as I can tell this PR does not touch any VPC code.

In Daan's original results the 'test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL' test went fine.

Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS === ok

remibergsma · 2016-06-08T20:42:58Z

@wido FYI all Python code is shared between basic/advanced and router/vpc so it's important to test both. Will try to look into it again in the next days. Not saying it's broken, just want to be careful.

swill · 2016-06-08T20:44:19Z

CI RESULTS

Tests Run: 22
Skipped: 1
Failed: 0
Errors: 0
Duration: 0h 32m 39s

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1:

/tmp/MarvinLogs/test_service_offerings_U496F9:

/tmp/MarvinLogs/test_ssvm_WVHYBZ:

Uploads will be available until 2016-08-08 02:00:00 +0200 CEST

Comment created by upr comment.

swill · 2016-06-08T20:44:46Z

The above is a test against basic networking.

remibergsma · 2016-06-08T20:50:39Z

Can you also run one against advanced please @swill?

swill · 2016-06-08T21:08:59Z

The tests run against basic networking hardly test the functionality of the network though. Apparently most of the tests for the network are only for advanced networking.

I will run against advanced networking again now...

wido · 2016-06-08T21:15:20Z

Thanks for the feedback @remibergsma and @swill !

Hopefully the results come back positive.

swill · 2016-06-08T21:17:17Z

Should this set of test have the "basic" tag? It only has the "sg" tag, which I am not targeting.

/Users/swill/Dropbox/code/cs/cloudstack/test/integration/component/maint/test_multiple_ip_ranges.py

swill · 2016-06-09T12:31:44Z

CI RESULTS

Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 00m 38s

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB:

/tmp/MarvinLogs/test_network_N3C2B9:

/tmp/MarvinLogs/test_vpc_routers_7OVU64:

Uploads will be available until 2016-08-09 02:00:00 +0200 CEST

Comment created by upr comment.

swill · 2016-06-09T12:37:41Z

Above is a run against advanced networking. Nice clean run. 👍

I am trying to test a bunch of basic zone networking tests, but I had never previously verified if they were broken. I have run them against this PR, but there are a bunch of issues. I am going to run the same set of tests against master to see if there is a difference in the results.

Unverified tests run against this PR. Doing the same against master now...

Tests Run: 24
Skipped: 0
Failed: 7
Errors: 2
Duration: 2h 21m 30s

(details masked intentionally as this set of tests is unverified)

swill · 2016-06-09T23:23:15Z

I ran the same network tests I mentioned above against master and I had the following results.

Tests Run: 24
Skipped: 0
Failed: 8
Errors: 2
Duration: 2h 35m 53s

All of the errors were the same on master, but in addition it also had a failure on this test:

FAIL: Test authorize ingress rule
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs2/cloudstack/test/integration/component/test_security_groups.py", line 459, in test_01_authorizeIngressRule
(self.virtual_machine.ipaddress, e)
AssertionError: SSH Access failed for 192.168.22.221: SSH connection has Failed. Waited 600s. Error is SSH Connection Failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_routers_ZEOUOD/results.txt

I am not sure if this PR fixed this issue or if it is just an intermittent issue, but this shows that this PR did not introduce any new issues into master (according to these unverified tests).

Given that this fixes issues in basic networking and does not appear to introduce any new issues, I am inclined to add it to the 4.9 release.

@wido, @remibergsma and @DaanHoogland do you guys agree with this decision? Thanks...

swill · 2016-06-09T23:26:19Z

BTW, these tests results are for the following tests

nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=basic \
component/test_deploy_vm_userdata_multi_nic.py \
component/test_escalations_securitygroups.py \
component/test_escalations_vpncustomergateways.py \
component/test_security_groups.py \
smoke/test_multipleips_per_nic.py \
smoke/test_portable_publicip.py \
smoke/test_routers.py
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a \
component/maint/test_multiple_ip_ranges.py

With ${marvinCfg} of:
/data/shared/marvin/mct-zone1-kvm1-basic.cfg
and
/data/shared/marvin/mct-zone3-kvm3-basic.cfg

wido · 2016-06-10T07:03:30Z

@swill I agree, but that's also because this bug is hitting and hurting us. However, I need other people to say LGTM :)

swill · 2016-06-10T11:53:50Z

@wido judging from your testing and commentary, I believe this has your LGTM? You have not officially specified that it does.

wido · 2016-06-12T08:48:24Z

@swill: Yes, LGTM from me. But @The-Loeki and I tested this together, so I would prefer more LGTMs, but also want this bug fixed :)

DaanHoogland · 2016-06-12T08:58:23Z

@swill Pinging @ustcweizhou again, I know leaseweb has an interest in this. They use advanced zones in several different setups so their ok is a good indication we can merge (together with pcxtreme their ok)

swill · 2016-06-13T13:50:39Z

@ustcweizhou can you review this PR please. I think we are ready on this one and since it fixes issues on master I would like to get it in before I cut the RC. Thanks...

swill · 2016-06-14T11:17:21Z

@ustcweizhou I can't wait forever on this. What I will likely do if I don't hear back from you is merge this and then cut the RC right away. I am hoping to cut the RC tomorrow, so if you can give me feedback before then I would appreciate it.

NuxRo · 2016-06-14T12:36:17Z

+1 merging, I'm also interested in this if it affects Advanced zone + Security Groups.
Will test ASAP.

wido · 2016-06-19T15:06:47Z

Great, if the RC is cut we can test that better. I'm about to leave on a 2 week holiday however.

bvbharatk · 2016-06-20T11:19:49Z

ACS CI BVT Run

Sumarry:
Build Number 202
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

swill · 2016-06-20T16:12:00Z

There have been a couple issues that have been reported on master so I don't expect the RC to be cut right away as we sort out those problems. I will probably merge this and we can then continue testing the other issues we have found.

Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANsDuring the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in our setups. This PR fixes a number of things: * Multiple IP's per VLAN interface are now supported & working again, including DNS, DHCP ranges, password and metadata services * `useextdns` fixed (I had a small merge conflict with an attempt to fix this at 4.7, but these fixes are more comprehensive) * CLOUDSTACK-8303 * Apache configs better in line with best-practices and distro-expected locations * Added a few more helper functions & getters & setters for utility * some minor cleanup & fixes * pr/1547: Remove /etc/apache2/sites-enabled/000-default in cloud-early-config SysVM various fixes to previous refactorings * make CORS include a regular glob-matched one * fix NameVirtualHost in CsApp.py as well * even moar cleanups SysVM: Cleanup and removal of old (and dangerous) config files * ports.conf * default & default-ssl sites * SSL config in httpd.conf * deprecated & dead setup_redundant_router in cloud-early-config SysVM cloud-early-config: Intermediate fix for SecStore & CORS * Take setup from vhost.template rather than default(-ssl) * should move into Python CS code as well * Move CORS setup to separate conf * Modify vhost template to Optionally include the cors file * Add NameVirtualHost to vhost template for feature parity with ports.conf * Take setup from vhost.template rather than default(-ssl) VR cloud-early-config: Commonize Apache2 common setup VR cloud-early-config: Fix Apache2 alias cleanup VR: consistent SSL setup, vhost is not an example, but a template VR CsConfig: reintroduce old get_dns() behaviour for redundant non-VPC's VR CsAddress fixes: * cleanup imports, * fix to_str(), * improve & fix service post_config logic * don't arpPing when there's no gateway VR CsApp: Expose config to classes, move vhost confs to proper location, allow for multiple IP's per intf, sanitize servername, don't open port 53 if no DNS is foreseen VR CsConfig: Add is_router(), is_dns(), has_dns(), has_metadata(), use_extdns(), fix get_dns() with use_extdns() VR CsDhcp: allow multiple ranges & finite lease time (fixes CLOUDSTACK-8303) VR CsGuestNetwork obey useextdns VR merge.py ipalias fix & dhcpconfig stub notification Signed-off-by: Will Stevens <williamstevens@gmail.com>

DaanHoogland reviewed May 13, 2016
View reviewed changes

The-Loeki force-pushed the vrouter-fixes branch from 073db04 to 13fcd65Compare May 13, 2016 14:36

The-Loeki force-pushed the vrouter-fixes branch 3 times, most recently from 5d2cda8 to 4b5d316Compare May 13, 2016 15:32

ustcweizhou reviewed May 16, 2016
View reviewed changes

The-Loeki force-pushed the vrouter-fixes branch from 4b5d316 to d0edabdCompare May 18, 2016 11:45

asfgit merged commit 67eb6ca into apache:masterJun 28, 2016

romain-dartigues mentioned this pull request Jul 5, 2016
Vrouter fixes pylint #1603
Closed

This was referenced Apr 11, 2019
VR DHCP lease file not persistent #3272
Closed
VR DHCP VPC multihomed VM broken #3273
Closed

Uh oh!

Conversation

The-Loeki commented May 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHooglandMay 13, 2016

Choose a reason for hiding this comment

Uh oh!

The-LoekiMay 13, 2016

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented May 13, 2016

Uh oh!

The-Loeki commented May 13, 2016

Uh oh!

DaanHoogland commented May 13, 2016

Uh oh!

The-Loeki commented May 13, 2016

Uh oh!

DaanHoogland commented May 13, 2016

Uh oh!

The-Loeki commented May 13, 2016

Uh oh!

DaanHoogland commented May 13, 2016

Uh oh!

DaanHoogland commented May 15, 2016

Uh oh!

DaanHoogland commented May 15, 2016

Uh oh!

DaanHoogland commented May 15, 2016

Uh oh!

ustcweizhouMay 16, 2016

Choose a reason for hiding this comment

Uh oh!

DaanHooglandMay 16, 2016

Choose a reason for hiding this comment

Uh oh!

ustcweizhouMay 17, 2016

Choose a reason for hiding this comment

Uh oh!

The-LoekiMay 18, 2016

Choose a reason for hiding this comment

Uh oh!

ustcweizhou commented May 16, 2016

Uh oh!

DaanHoogland commented May 16, 2016

Uh oh!

The-Loeki commented May 17, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented May 17, 2016

Uh oh!

The-Loeki commented May 17, 2016

Uh oh!

swill commented May 17, 2016

Uh oh!

swill commented May 17, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI RESULTS

Uh oh!

swill commented May 17, 2016

Uh oh!

DaanHoogland commented May 17, 2016

Uh oh!

swill commented May 18, 2016

CI RESULTS

Uh oh!

swill commented May 18, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido commented May 18, 2016

Uh oh!

linas-ipxo commented May 18, 2016

Uh oh!

DaanHoogland commented Jun 7, 2016

Uh oh!

wido commented Jun 7, 2016

Uh oh!

remibergsma commented Jun 8, 2016

Uh oh!

The-Loeki commented May 13, 2016•
edited
Loading

The-Loeki commented May 17, 2016•
edited
Loading

swill commented May 17, 2016•
edited
Loading

swill commented May 18, 2016•
edited
Loading

swill commented Jun 9, 2016•
edited
Loading