added constant for magic code by vcharmcaster · Pull Request #1597 · apache/cloudstack

vcharmcaster · 2016-06-25T04:55:47Z

"=" was used in lots of space extracted it as constant

syed · 2016-06-28T15:11:12Z

Looks like there are some trailing space problems. Can you please fix that @vcharmcaster

/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:25: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:26:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:28:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29:1: error: Line contains a tab character.

Also, can you rebase your commits into a single commit?

Otherwise, the code LGTM 👍

swill · 2016-06-28T15:14:06Z

Should the result of the splits be stripped of whitespace to make sure there is no extra whitespace being saved into variables?

vcharmcaster · 2016-06-28T18:23:22Z

@swill @syed updated formatting. Let me know if i missed something.

syed · 2016-06-28T20:25:50Z

@vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need to be fixed.

yadvr · 2016-08-06T08:52:16Z

@blueorangutan package

blueorangutan · 2016-08-06T08:53:05Z

@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-08-06T10:27:17Z

Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1597

blueorangutan · 2016-08-08T06:43:48Z

Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1597
Job ID #66

yadvr · 2016-11-20T08:10:04Z

@blueorangutan package

blueorangutan · 2016-11-20T08:11:06Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-11-20T18:27:46Z

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-212

yadvr · 2016-11-23T09:06:07Z

@vcharmcaster can you fix the space/tab issue.

fmaximus · 2017-05-18T21:13:04Z

 if (paramTokens != null && paramTokens.length == 2) {
- String name = param.split("=")[0];
- String value = param.split("=")[1];
+ String name = param.split(EQUALS)[0];


Could be also simplified to paramTokens[0]

fmaximus · 2017-05-18T21:13:18Z

- String name = param.split("=")[0];
- String value = param.split("=")[1];
+ String name = param.split(EQUALS)[0];
+ String value = param.split(EQUALS)[1];


Could be also simplified to paramTokens[1]

DaanHoogland · 2020-03-06T15:01:59Z

@vcharmcaster please rebase and re-open if still relevant

@GabrielBrascher is this still relevant?

vcharmcaster added 2 commits June 25, 2016 10:25

added constant for magic code
bddeafb
"=" was used in lots of space extracted it as constant

(long)0 replaced by 0L
159948c

Update ConsoleProxyHttpHandlerHelper.java
04373e8

fmaximus reviewed May 18, 2017
View reviewed changes

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 10, 2018
Address reviewers on abandoned PRapache#1597.
be67766

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 10, 2018
Address reviewers from abandoned PRapache#1597.
2f97ed5

GabrielBrascher mentioned this pull request Dec 10, 2018
Address reviewers from abandoned PR #1597. #3091
Closed
5 tasks

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 10, 2018
Address reviewers from abandoned PRapache#1597.
0ddc166

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 10, 2018
Address reviewers from abandoned PRapache#1597.
ae7c764

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 10, 2018
Address reviewers from abandoned PRapache#1597.
8de4362

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 11, 2018
Address reviewers from abandoned PRapache#1597.
58a7a6a

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Dec 11, 2018
Address reviewers from abandoned PRapache#1597.
fd3945b

DaanHoogland closed this Mar 6, 2020

Uh oh!

Conversation

vcharmcaster commented Jun 25, 2016

Uh oh!

syed commented Jun 28, 2016

Uh oh!

swill commented Jun 28, 2016

Uh oh!

vcharmcaster commented Jun 28, 2016

Uh oh!

syed commented Jun 28, 2016

Uh oh!

yadvr commented Aug 6, 2016

Uh oh!

blueorangutan commented Aug 6, 2016

Uh oh!

blueorangutan commented Aug 6, 2016

Uh oh!

blueorangutan commented Aug 8, 2016

Uh oh!

yadvr commented Nov 20, 2016

Uh oh!

blueorangutan commented Nov 20, 2016

Uh oh!

blueorangutan commented Nov 20, 2016

Uh oh!

yadvr commented Nov 23, 2016

Uh oh!

fmaximusMay 18, 2017

Choose a reason for hiding this comment

Uh oh!

fmaximusMay 18, 2017

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants