[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs

[syed]

With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the VHDProcessor incorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file.

Before the fix: template.properties on Swift

uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=2894447637315205059

After the fix

uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=3145728000

Look at the virutalsize in both cases

[swill]

@syed my understanding is that you have tested this fix with swift in our lab. That is correct?

I will get CI run against it to make sure this does not break anything outside swift.

[syed]

Yes @swill I've tested this on my local setup.

On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens notifications@github.com
wrote:

@syedhttps://github.com/syed my understanding is that you have tested
this fix with swift in our lab. That is correct?

I will get CI run against it to make sure this does not break anything
outside swift.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1598 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADaLukgRTWegA80eHmB9lgg9QMRZxv3ks5qQD2mgaJpZM4I_d12
.

[swill]

Thank you. I have CI running and I should have results later tonight.

[swill]

CI RESULTS

Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 07m 10s

Associated Uploads

/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600:

• dc_entries.obj
• failed_plus_exceptions.txt
• runinfo.txt

/tmp/MarvinLogs/test_network_HRWEBW:

• failed_plus_exceptions.txt
• results.txt
• runinfo.txt

/tmp/MarvinLogs/test_vpc_routers_Z3TJCB:

• failed_plus_exceptions.txt
• results.txt
• runinfo.txt

Uploads will be available until 2016-08-28 02:00:00 +0200 CEST

Comment created by upr comment.

[swill]

This is coming back clean. Since it fixes issues in 4.9, I think it should be merged...

[swill]

Can you fix the method indentation here. This should not be indented that extra tab.

[swill]

@syed, can you do a once through and clean up some of the white space issues in this diff. I have highlighted a couple. The method indent is the most important, but there are a few other cases where the white space can be cleaned up as well. Thx...

[syed]

@swill. I've fixed the whitespaces and rebased everything. Should be good now.

[swill]

Good enough. Thanks... :)

[syed]

@swill if you can merge this before you cut the release, it would be awesome.