Uh oh!
There was an error while loading. Please reload this page.
[blocker] CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms - #1634
Merged
Conversation
blueorangutan
commented
Aug 10, 2016
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
yadvrforce-pushed
the
patchviasocket-49-py26fix
branch
from
August 10, 2016 09:29
50e1d16 to
cddf385Comparesverrirab
commented
Aug 10, 2016
+1 from me (for what it's worth) |
blueorangutan
commented
Aug 10, 2016
Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1634 |
The patchviasocket script was rewritten in Python from PR apache#1533 and made assumptions that Python 2.7 would be available. In case of CentOS, python 2.7 may not be available or installed. This change ensures that python-argparse is installed which is used by this script. Expose cmd error in the logs when patch command fails. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvrforce-pushed
the
patchviasocket-49-py26fix
branch
from
August 10, 2016 10:56
cddf385 to
7b8ba24Comparejburwell
commented
Aug 10, 2016
Contributor
LGTM for code |
yadvr
commented
Aug 18, 2016
MemberAuthor
yadvr
commented
Aug 22, 2016
MemberAuthor
@blueorangutan test |
blueorangutan
commented
Aug 22, 2016
@rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1634 |
blueorangutan
commented
Aug 22, 2016
Trillian test result (trillian-pr1634-33-vmware-55u3-cs49):
|
jburwell
commented
Aug 22, 2016
Contributor
@rhtyd the test results from blueorangutan are looking pretty good. A couple of observations:
|
yadvr
commented
Aug 23, 2016
MemberAuthor
@jburwell thanks
|
yadvr
commented
Aug 23, 2016
MemberAuthor
We've enough LGTMs and test result (with vmware), I'll fire another Trillian job with KVM. |
blueorangutan
commented
Aug 23, 2016
Trillian test result (trillian-pr1634-49-kvm-centos68-cs49):
Trillian env - trillian-pr1634-49-kvm-centos68-cs49, Job ID 49 |
yadvr
commented
Aug 24, 2016
MemberAuthor
Merging based on lgtms and test results (the failures are due to env issues, and failing tests not related to the pkging fix). |
asfgit pushed a commit
that referenced
this pull request
Aug 24, 2016
[blocker] CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpmsThe patchviasocket script was rewritten in Python from PR #1533 and made assumptions that Python 2.7 would be available. In case of CentOS, python 2.7 may not be available or installed. This change ensures that python-argparse is installed which is used by this script. /cc @wido@sverrirab@karuturi@jburwell@blueorangutan package * pr/1634: CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
lucas-a-martins pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Jan 29, 2024
Permitir configuração manual das _flags_ envolvidas em uma migração KVM Closesapache#1634 See merge request scclouds/scclouds!675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patchviasocket script was rewritten in Python from PR #1533 and made
assumptions that Python 2.7 would be available. In case of CentOS, python 2.7
may not be available or installed. This change ensures that python-argparse
is installed which is used by this script.
/cc @wido@sverrirab@karuturi@jburwell
@blueorangutan package