Skip to content

CLOUDSTACK-9498: VR CsFile search utility methods fail when search st… - #1680

Merged
asfgit merged 1 commit into
apache:4.9from
murali-reddy:vr_csfile_search
Nov 23, 2016
Merged

CLOUDSTACK-9498: VR CsFile search utility methods fail when search st…#1680
asfgit merged 1 commit into
apache:4.9from
murali-reddy:vr_csfile_search

Conversation

@murali-reddy

@murali-reddymurali-reddy commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

There is no real use of python 're' module in CsFile.py utility methods searchString, deleteLine. Regular string search is sufficient. These methods are used only for VPN user add/delete. Since VPN user password can have python 're' module meta characters, it interfere with search functionality.

Replacing re.search() with regular string search instead.

Change is confined to VPN add/delete users. Have run the test/integration/component/test_vpn_users.py

VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit | Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName: test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName: test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users | Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName: test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... === TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... === TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok

@jburwell

jburwell commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

LGTM for code

abhinandanprateek
abhinandanprateek reviewed Sep 23, 2016
View reviewed changes

@abhinandanprateekabhinandanprateek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murali-reddy the changes look good
LGTM for PR

@cloudmonger

cloudmonger commented Sep 23, 2016

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 103
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=1
Skipped=4

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_non_contigiousvlan.py
    • test_extendPhysicalNetworkVlan Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@murali-reddy

murali-reddy commented Sep 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@cloudmonger error seems to be due to 'physicalnetwork 200 has allocated vnets in the range 731-732' This is same error seen in test run. After test run in done, please see if there is network that was not cleaned and reason for that.

This patch is contained to VPN user add/delete functionality, unrelated to the error.

@jburwell

jburwell commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Sep 26, 2016

Copy link
Copy Markdown

@jburwell a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@jburwell

jburwell commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

@murali-reddy could you please add and/or update Marvin test cases to verify this fix?

@blueorangutan

blueorangutan commented Sep 26, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-26

@murali-reddy

murali-reddy commented Sep 27, 2016

Copy link
Copy Markdown
ContributorAuthor

@jburwell changed the existing marvin test to use password as "p@a#s=s.w_o-r+d", which will cover the all chars permitted for VPN user password

@yadvr

yadvr commented Oct 21, 2016

Copy link
Copy Markdown
Member

@murali-reddy can you check if changes to the test_data will work in general
@blueorangutan package

@blueorangutan

blueorangutan commented Oct 21, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 21, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-85

@murali-reddy
CLOUDSTACK-9498: VR CsFile search utility methods fail when search st…
9cc06a8
…ring has
're' meta chars, and causing VPN user add/deelte to fail
-there is no real use of python 're' in CsFile.py utility methods searchString, deleteLine
Replacing with regular string search instead.
-modifying the smoke test for VPN user add/delete to have all permissable chars
@murali-reddy

murali-reddy commented Oct 28, 2016

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 28, 2016

Copy link
Copy Markdown

@murali-reddy a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 28, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-113

@murali-reddy

murali-reddy commented Oct 28, 2016

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test

@blueorangutan

blueorangutan commented Oct 28, 2016

Copy link
Copy Markdown

@murali-reddy a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@murali-reddy

murali-reddy commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test

@blueorangutan

blueorangutan commented Oct 31, 2016

Copy link
Copy Markdown

@murali-reddy a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Oct 31, 2016

Copy link
Copy Markdown

Trillian test result (tid-228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27152 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1680-t228-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)

TestResultTime (s)Test File
test_02_redundant_VPC_default_routesFailure869.98test_vpc_redundant.py
ContextSuite context=TestRVPCSite2SiteVpn>:setupError0.00test_vpc_vpn.py
test_01_vpc_site2site_vpnSuccess160.40test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess66.16test_vpc_vpn.py
test_02_VPC_default_routesSuccess275.84test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess558.87test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess516.84test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1420.15test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess554.03test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1297.41test_vpc_redundant.py
test_09_delete_detached_volumeSuccess15.44test_volumes.py
test_08_resize_volumeSuccess15.43test_volumes.py
test_07_resize_failSuccess20.44test_volumes.py
test_06_download_detached_volumeSuccess15.32test_volumes.py
test_05_detach_volumeSuccess100.24test_volumes.py
test_04_delete_attached_volumeSuccess10.20test_volumes.py
test_03_download_attached_volumeSuccess15.28test_volumes.py
test_02_attach_volumeSuccess73.78test_volumes.py
test_01_create_volumeSuccess712.50test_volumes.py
test_deploy_vm_multipleSuccess273.65test_vm_life_cycle.py
test_deploy_vmSuccess0.03test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.62test_vm_life_cycle.py
test_09_expunge_vmSuccess125.20test_vm_life_cycle.py
test_08_migrate_vmSuccess40.92test_vm_life_cycle.py
test_07_restore_vmSuccess0.13test_vm_life_cycle.py
test_06_destroy_vmSuccess125.86test_vm_life_cycle.py
test_03_reboot_vmSuccess125.84test_vm_life_cycle.py
test_02_start_vmSuccess10.18test_vm_life_cycle.py
test_01_stop_vmSuccess40.34test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess60.66test_templates.py
test_08_list_system_templatesSuccess0.04test_templates.py
test_07_list_public_templatesSuccess0.04test_templates.py
test_05_template_permissionsSuccess0.07test_templates.py
test_04_extract_templateSuccess5.17test_templates.py
test_03_delete_templateSuccess5.12test_templates.py
test_02_edit_templateSuccess90.15test_templates.py
test_01_create_templateSuccess50.61test_templates.py
test_10_destroy_cpvmSuccess161.64test_ssvm.py
test_09_destroy_ssvmSuccess168.57test_ssvm.py
test_08_reboot_cpvmSuccess161.86test_ssvm.py
test_07_reboot_ssvmSuccess133.64test_ssvm.py
test_06_stop_cpvmSuccess131.68test_ssvm.py
test_05_stop_ssvmSuccess133.74test_ssvm.py
test_04_cpvm_internalsSuccess1.21test_ssvm.py
test_03_ssvm_internalsSuccess3.31test_ssvm.py
test_02_list_cpvm_vmSuccess0.12test_ssvm.py
test_01_list_sec_storage_vmSuccess0.13test_ssvm.py
test_01_snapshot_root_diskSuccess11.09test_snapshots.py
test_04_change_offering_smallSuccess239.50test_service_offerings.py
test_03_delete_service_offeringSuccess0.04test_service_offerings.py
test_02_edit_service_offeringSuccess0.05test_service_offerings.py
test_01_create_service_offeringSuccess0.11test_service_offerings.py
test_02_sys_template_readySuccess0.13test_secondary_storage.py
test_01_sys_vm_startSuccess0.18test_secondary_storage.py
test_09_reboot_routerSuccess35.31test_routers.py
test_08_start_routerSuccess30.30test_routers.py
test_07_stop_routerSuccess10.18test_routers.py
test_06_router_advancedSuccess0.06test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.70test_routers.py
test_03_restart_network_cleanupSuccess55.50test_routers.py
test_02_router_internal_advSuccess1.06test_routers.py
test_01_router_internal_basicSuccess0.59test_routers.py
test_router_dns_guestipquerySuccess76.71test_router_dns.py
test_router_dns_externalipquerySuccess0.07test_router_dns.py
test_router_dhcphostsSuccess273.81test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.08test_resource_detail.py
test_01_reset_vm_on_rebootSuccess130.96test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.23test_pvlan.py
test_dedicatePublicIpRangeSuccess0.45test_public_ip_range.py
test_04_rvpc_privategw_static_routesSuccess461.59test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess505.94test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess406.39test_privategw_acl.py
test_01_vpc_privategw_aclSuccess93.44test_privategw_acl.py
test_01_primary_storage_nfsSuccess35.70test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.18test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.44test_portable_publicip.py
test_isolate_network_password_serverSuccess86.42test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.14test_over_provisioning.py
test_oobm_zchange_passwordSuccess20.53test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.52test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.51test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.52test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.52test_outofbandmanagement.py
test_oobm_issue_power_onSuccess10.51test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.52test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess52.23test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.18test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.19test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.09test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.09test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.93test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.30test_non_contigiousvlan.py
test_01_nicSuccess621.20test_nic.py
test_releaseIPSuccess268.97test_network.py
test_reboot_routerSuccess394.23test_network.py
test_public_ip_user_accountSuccess10.26test_network.py
test_public_ip_admin_accountSuccess40.48test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess66.82test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.68test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess124.23test_network.py
test_delete_accountSuccess298.76test_network.py
test_02_port_fwd_on_non_src_natSuccess55.66test_network.py
test_01_port_fwd_on_src_natSuccess111.77test_network.py
test_nic_secondaryip_add_removeSuccess203.83test_multipleips_per_nic.py
login_test_saml_userSuccess24.73test_login.py
test_assign_and_removal_lbSuccess133.38test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.25test_loadbalance.py
test_01_create_lb_rule_src_natSuccess218.21test_loadbalance.py
test_03_list_snapshotsSuccess0.08test_list_ids_parameter.py
test_02_list_templatesSuccess0.04test_list_ids_parameter.py
test_01_list_volumesSuccess0.03test_list_ids_parameter.py
test_07_list_default_isoSuccess0.06test_iso.py
test_05_iso_permissionsSuccess0.06test_iso.py
test_04_extract_IsoSuccess5.17test_iso.py
test_03_delete_isoSuccess95.16test_iso.py
test_02_edit_isoSuccess0.06test_iso.py
test_01_create_isoSuccess21.97test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess244.55test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess183.04test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success520.64test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success429.75test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.27test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.13test_global_settings.py
test_rolepermission_lifecycle_updateSuccess7.05test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.88test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess6.79test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess6.77test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess7.11test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess6.78test_dynamicroles.py
test_role_lifecycle_updateSuccess11.86test_dynamicroles.py
test_role_lifecycle_listSuccess6.79test_dynamicroles.py
test_role_lifecycle_deleteSuccess11.80test_dynamicroles.py
test_role_lifecycle_createSuccess6.79test_dynamicroles.py
test_role_inuse_deletionSuccess6.76test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess9.12test_dynamicroles.py
test_role_account_aclsSuccess9.19test_dynamicroles.py
test_default_role_deletionSuccess6.89test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.08test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.04test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.05test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.07test_disk_offerings.py
test_01_create_disk_offeringSuccess0.11test_disk_offerings.py
test_deployvm_userdispersingSuccess20.56test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess20.59test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess80.80test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess10.40test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess75.85test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess6.87test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess6.85test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess223.41test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess208.46test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess111.21test_affinity_groups.py
test_03_delete_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_02_revert_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_01_test_vm_volume_snapshotSkipped0.00test_vm_snapshots.py
test_01_create_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.00test_deploy_vgpu_enabled_vm.py

@jburwell

jburwell commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

@blueorangutan test centos6 vmware55u3

@blueorangutan

blueorangutan commented Nov 1, 2016

Copy link
Copy Markdown

@jburwell a Trillian-Jenkins test job (centos6 mgmt + vmware55u3) has been kicked to run smoke tests

@yadvr

yadvr commented Nov 1, 2016

Copy link
Copy Markdown
Member

The job failed due to systemvms failed to come up, I'll re-kick this.

@blueorangutan

blueorangutan commented Nov 1, 2016

Copy link
Copy Markdown

Trillian test result (tid-233)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38420 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1680-t233-vmware-55u3.zip
Test completed. 45 look ok, 3 have error(s)

TestResultTime (s)Test File
test_02_vpc_privategw_static_routesFailure297.65test_privategw_acl.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure146.16test_internal_lb.py
test_01_vpc_site2site_vpnError505.78test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnError716.92test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess206.47test_vpc_vpn.py
test_02_VPC_default_routesSuccess348.71test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess735.10test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess700.01test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1618.14test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess762.62test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess819.78test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1574.37test_vpc_redundant.py
test_09_delete_detached_volumeSuccess31.12test_volumes.py
test_06_download_detached_volumeSuccess80.92test_volumes.py
test_05_detach_volumeSuccess110.27test_volumes.py
test_04_delete_attached_volumeSuccess15.16test_volumes.py
test_03_download_attached_volumeSuccess20.24test_volumes.py
test_02_attach_volumeSuccess58.95test_volumes.py
test_01_create_volumeSuccess546.95test_volumes.py
test_03_delete_vm_snapshotsSuccess280.22test_vm_snapshots.py
test_02_revert_vm_snapshotsSuccess234.16test_vm_snapshots.py
test_01_test_vm_volume_snapshotSuccess196.23test_vm_snapshots.py
test_01_create_vm_snapshotsSuccess162.06test_vm_snapshots.py
test_deploy_vm_multipleSuccess272.62test_vm_life_cycle.py
test_deploy_vmSuccess0.02test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.75test_vm_life_cycle.py
test_09_expunge_vmSuccess125.21test_vm_life_cycle.py
test_08_migrate_vmSuccess110.95test_vm_life_cycle.py
test_07_restore_vmSuccess0.06test_vm_life_cycle.py
test_06_destroy_vmSuccess10.12test_vm_life_cycle.py
test_03_reboot_vmSuccess5.10test_vm_life_cycle.py
test_02_start_vmSuccess20.17test_vm_life_cycle.py
test_01_stop_vmSuccess10.11test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess331.67test_templates.py
test_08_list_system_templatesSuccess0.02test_templates.py
test_07_list_public_templatesSuccess0.03test_templates.py
test_05_template_permissionsSuccess0.04test_templates.py
test_04_extract_templateSuccess20.39test_templates.py
test_03_delete_templateSuccess5.08test_templates.py
test_02_edit_templateSuccess90.14test_templates.py
test_01_create_templateSuccess140.79test_templates.py
test_10_destroy_cpvmSuccess266.51test_ssvm.py
test_09_destroy_ssvmSuccess238.48test_ssvm.py
test_08_reboot_cpvmSuccess156.36test_ssvm.py
test_07_reboot_ssvmSuccess158.50test_ssvm.py
test_06_stop_cpvmSuccess206.61test_ssvm.py
test_05_stop_ssvmSuccess213.50test_ssvm.py
test_04_cpvm_internalsSuccess1.64test_ssvm.py
test_03_ssvm_internalsSuccess4.36test_ssvm.py
test_02_list_cpvm_vmSuccess0.09test_ssvm.py
test_01_list_sec_storage_vmSuccess0.10test_ssvm.py
test_01_snapshot_root_diskSuccess26.02test_snapshots.py
test_04_change_offering_smallSuccess97.28test_service_offerings.py
test_03_delete_service_offeringSuccess0.03test_service_offerings.py
test_02_edit_service_offeringSuccess0.06test_service_offerings.py
test_01_create_service_offeringSuccess0.08test_service_offerings.py
test_02_sys_template_readySuccess0.10test_secondary_storage.py
test_01_sys_vm_startSuccess0.13test_secondary_storage.py
test_09_reboot_routerSuccess175.92test_routers.py
test_08_start_routerSuccess145.80test_routers.py
test_07_stop_routerSuccess30.21test_routers.py
test_06_router_advancedSuccess0.05test_routers.py
test_05_router_basicSuccess0.03test_routers.py
test_04_restart_network_wo_cleanupSuccess5.55test_routers.py
test_03_restart_network_cleanupSuccess171.38test_routers.py
test_02_router_internal_advSuccess0.90test_routers.py
test_01_router_internal_basicSuccess0.47test_routers.py
test_router_dns_guestipquerySuccess76.91test_router_dns.py
test_router_dns_externalipquerySuccess0.07test_router_dns.py
test_router_dhcphostsSuccess158.40test_router_dhcphosts.py
test_01_updatevolumedetailSuccess5.11test_resource_detail.py
test_01_reset_vm_on_rebootSuccess75.49test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.16test_pvlan.py
test_dedicatePublicIpRangeSuccess0.31test_public_ip_range.py
test_04_rvpc_privategw_static_routesSuccess1283.63test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess1112.45test_privategw_acl.py
test_01_vpc_privategw_aclSuccess258.02test_privategw_acl.py
test_01_primary_storage_nfsSuccess39.23test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.20test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.34test_portable_publicip.py
test_isolate_network_password_serverSuccess97.48test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.12test_over_provisioning.py
test_oobm_zchange_passwordSuccess20.51test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.52test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.51test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.52test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.51test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess56.84test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.14test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.12test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.15test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.09test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.07test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.07test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.55test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.24test_non_contigiousvlan.py
test_01_nicSuccess750.93test_nic.py
test_releaseIPSuccess318.13test_network.py
test_reboot_routerSuccess760.28test_network.py
test_public_ip_user_accountSuccess10.24test_network.py
test_public_ip_admin_accountSuccess40.20test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess76.47test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.60test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess124.88test_network.py
test_delete_accountSuccess438.51test_network.py
test_02_port_fwd_on_non_src_natSuccess55.54test_network.py
test_01_port_fwd_on_src_natSuccess111.86test_network.py
test_nic_secondaryip_add_removeSuccess252.84test_multipleips_per_nic.py
login_test_saml_userSuccess21.41test_login.py
test_assign_and_removal_lbSuccess148.67test_loadbalance.py
test_02_create_lb_rule_non_natSuccess207.50test_loadbalance.py
test_01_create_lb_rule_src_natSuccess209.11test_loadbalance.py
test_03_list_snapshotsSuccess0.05test_list_ids_parameter.py
test_02_list_templatesSuccess0.03test_list_ids_parameter.py
test_01_list_volumesSuccess0.02test_list_ids_parameter.py
test_07_list_default_isoSuccess0.04test_iso.py
test_05_iso_permissionsSuccess0.05test_iso.py
test_04_extract_IsoSuccess5.51test_iso.py
test_03_delete_isoSuccess95.13test_iso.py
test_02_edit_isoSuccess0.04test_iso.py
test_01_create_isoSuccess21.51test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess787.64test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess515.98test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success1250.19test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.25test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.10test_global_settings.py
test_rolepermission_lifecycle_updateSuccess6.56test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.29test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess6.17test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess6.19test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.32test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess6.18test_dynamicroles.py
test_role_lifecycle_updateSuccess11.72test_dynamicroles.py
test_role_lifecycle_listSuccess6.23test_dynamicroles.py
test_role_lifecycle_deleteSuccess11.22test_dynamicroles.py
test_role_lifecycle_createSuccess6.30test_dynamicroles.py
test_role_inuse_deletionSuccess6.29test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess7.64test_dynamicroles.py
test_role_account_aclsSuccess7.91test_dynamicroles.py
test_default_role_deletionSuccess6.27test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.05test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.04test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.04test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.05test_disk_offerings.py
test_01_create_disk_offeringSuccess0.08test_disk_offerings.py
test_deployvm_userdispersingSuccess75.68test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess120.97test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess211.99test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess105.88test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess241.71test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess6.16test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess6.15test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess6.24test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess253.51test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess312.17test_affinity_groups.py
test_08_resize_volumeSkipped5.09test_volumes.py
test_07_resize_failSkipped15.23test_volumes.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_01_scale_vmSkipped66.31test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.03test_primary_storage.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.01test_deploy_vgpu_enabled_vm.py

@jburwell

jburwell commented Nov 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@murali-reddy the test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 and test_02_vpc_privategw_static_routes test cases failed on the most recent test run. Could you please investigate these failures?

(test_01_redundant_vpc_site2site_vpn and test_01_redundant_vpc_site2site_vpn are expected until the redundant VPC VR defects are fixed)

@jburwelljburwell mentioned this pull request Nov 1, 2016
Merged
@yadvr

yadvr commented Nov 20, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-197

@yadvr

yadvr commented Nov 23, 2016

Copy link
Copy Markdown
Member

LGTM. Merging this based on review and tests.
Failures in vpc/rvr are known intermittent issues and will be addressed separately for xen/vmware.

asfgit pushed a commit that referenced this pull request Nov 23, 2016
@yadvr
Merge pull request#1680from murali-reddy/vr_csfile_search
1e88ad4
CLOUDSTACK-9498: VR CsFile search utility methods fail when search stThere is no real use of python 're' module in CsFile.py utility methods searchString, deleteLine. Regular string search is sufficient. These methods are used only for VPN user add/delete. Since VPN user password can have python 're' module meta characters, it interfere with search functionality.
Replacing re.search() with regular string search instead.
Change is confined to VPN add/delete users. Have run the test/integration/component/test_vpn_users.py
VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit | Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName: test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName: test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users | Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName: test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... === TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... === TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok
* pr/1680:
CLOUDSTACK-9498: VR CsFile search utility methods fail when search string has 're' meta chars, and causing VPN user add/deelte to fail
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@asfgit
asfgit merged commit 9cc06a8 into apache:4.9Nov 23, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@abhinandanprateekabhinandanprateekabhinandanprateek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@murali-reddy@jburwell@cloudmonger@blueorangutan@yadvr@abhinandanprateek@asfgit