Skip to content

CLOUDSTACK-9500: remove the IP from the databag if it is not used - #1706

Closed
vilisseranen wants to merge 1 commit into
apache:masterfrom
vilisseranen:CLOUDSTACK-9500
Closed

CLOUDSTACK-9500: remove the IP from the databag if it is not used#1706
vilisseranen wants to merge 1 commit into
apache:masterfrom
vilisseranen:CLOUDSTACK-9500

Conversation

@vilisseranen

@vilisseranenvilisseranen commented Oct 12, 2016

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/CLOUDSTACK-9500

This removes the IP from the databags ips.json and forwardingrules.json when the IP is unused.

@pdion891

pdion891 commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

Hi @remibergsma,

We found this issue CLOUDSTACK-9500 where Public IP's is not removed from a VR when the Public IP is release. this cause routing issues because the arp table is refresh at any operation on the VR which reset de MAC for the release IP that can be used into another VR in a VPC deployement model.

Is this something you faced?

Thanks,

@yadvr

yadvr commented Oct 21, 2016

Copy link
Copy Markdown
Member

/cc @murali-reddy

@yadvr

yadvr commented Oct 21, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 21, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 21, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-71

@remibergsma

remibergsma commented Oct 29, 2016

Copy link
Copy Markdown
Contributor

@pdion891 saw your msg only now. Will have a look when I find some time. Thx!

@ustcweizhou

ustcweizhou commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

this is our change for similar issue

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
index 9f9513d..fc2b639 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
@@ -118,6 +118,16 @@ class CsAddress(CsDataBag):
if CsDevice(dev, self.config).waitfordevice():
ip.configure(address)
+ def delete(self, addr):
+ for dev in self.dbag:
+ if dev == "id":
+ continue
+ for address in self.dbag[dev]:
+ if address['public_ip'] == addr:
+ self.dbag[dev].remove(address)
+ self.save()
+ break
+
class CsInterface:
@@ -537,6 +547,8 @@ class CsIP:
route.copy_routes_from_main(devs, [self.dev])
elif method == "delete":
+ logging.info("delete %s from /etc/cloudstack/ips.json" % self.address['public_ip'])
+ self.config.address().delete(self.address['public_ip'])
logging.warn("delete route not implemented")
self.fw_router()

@jburwell

jburwell commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

@murali-reddy have any of your patches addressed this issue?

@yadvr

yadvr commented Nov 2, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 2, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 2, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-139

@yadvr

yadvr commented Nov 3, 2016

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Nov 3, 2016

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Nov 3, 2016

Copy link
Copy Markdown

Trillian test result (tid-269)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1706-t269-kvm-centos7.zip
Test completed. 45 look ok, 3 have error(s)

TestResultTime (s)Test File
test_02_redundant_VPC_default_routesFailure845.38test_vpc_redundant.py
test_oobm_zchange_passwordFailure20.38test_outofbandmanagement.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleFailure36.36test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleFailure31.31test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleFailure93.29test_network.py
test_10_attachAndDetach_isoError32.29test_vm_life_cycle.py
test_01_vpc_site2site_vpnSuccess144.27test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess61.00test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnSuccess227.25test_vpc_vpn.py
test_02_VPC_default_routesSuccess253.81test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess515.20test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess494.85test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1402.39test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess525.90test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1235.82test_vpc_redundant.py
test_09_delete_detached_volumeSuccess15.35test_volumes.py
test_08_resize_volumeSuccess15.28test_volumes.py
test_07_resize_failSuccess20.35test_volumes.py
test_06_download_detached_volumeSuccess15.22test_volumes.py
test_05_detach_volumeSuccess100.24test_volumes.py
test_04_delete_attached_volumeSuccess10.16test_volumes.py
test_03_download_attached_volumeSuccess15.24test_volumes.py
test_02_attach_volumeSuccess43.61test_volumes.py
test_01_create_volumeSuccess617.32test_volumes.py
test_deploy_vm_multipleSuccess338.31test_vm_life_cycle.py
test_deploy_vmSuccess0.02test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_09_expunge_vmSuccess125.21test_vm_life_cycle.py
test_08_migrate_vmSuccess35.66test_vm_life_cycle.py
test_07_restore_vmSuccess0.08test_vm_life_cycle.py
test_06_destroy_vmSuccess125.63test_vm_life_cycle.py
test_03_reboot_vmSuccess125.67test_vm_life_cycle.py
test_02_start_vmSuccess10.13test_vm_life_cycle.py
test_01_stop_vmSuccess35.22test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess65.67test_templates.py
test_08_list_system_templatesSuccess0.02test_templates.py
test_07_list_public_templatesSuccess0.03test_templates.py
test_05_template_permissionsSuccess0.04test_templates.py
test_04_extract_templateSuccess5.44test_templates.py
test_03_delete_templateSuccess5.11test_templates.py
test_02_edit_templateSuccess90.10test_templates.py
test_01_create_templateSuccess45.35test_templates.py
test_10_destroy_cpvmSuccess131.23test_ssvm.py
test_09_destroy_ssvmSuccess163.00test_ssvm.py
test_08_reboot_cpvmSuccess101.22test_ssvm.py
test_07_reboot_ssvmSuccess102.97test_ssvm.py
test_06_stop_cpvmSuccess131.34test_ssvm.py
test_05_stop_ssvmSuccess133.09test_ssvm.py
test_04_cpvm_internalsSuccess0.93test_ssvm.py
test_03_ssvm_internalsSuccess4.03test_ssvm.py
test_02_list_cpvm_vmSuccess0.09test_ssvm.py
test_01_list_sec_storage_vmSuccess0.09test_ssvm.py
test_01_snapshot_root_diskSuccess11.01test_snapshots.py
test_04_change_offering_smallSuccess204.31test_service_offerings.py
test_03_delete_service_offeringSuccess0.03test_service_offerings.py
test_02_edit_service_offeringSuccess0.04test_service_offerings.py
test_01_create_service_offeringSuccess0.07test_service_offerings.py
test_02_sys_template_readySuccess0.09test_secondary_storage.py
test_01_sys_vm_startSuccess0.12test_secondary_storage.py
test_09_reboot_routerSuccess30.21test_routers.py
test_08_start_routerSuccess25.19test_routers.py
test_07_stop_routerSuccess10.12test_routers.py
test_06_router_advancedSuccess0.04test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.54test_routers.py
test_03_restart_network_cleanupSuccess75.48test_routers.py
test_02_router_internal_advSuccess1.01test_routers.py
test_01_router_internal_basicSuccess0.49test_routers.py
test_router_dns_guestipquerySuccess73.58test_router_dns.py
test_router_dns_externalipquerySuccess0.06test_router_dns.py
test_router_dhcphostsSuccess235.94test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.06test_resource_detail.py
test_01_reset_vm_on_rebootSuccess130.71test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.16test_pvlan.py
test_dedicatePublicIpRangeSuccess0.29test_public_ip_range.py
test_04_rvpc_privategw_static_routesSuccess489.93test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess423.33test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess385.04test_privategw_acl.py
test_01_vpc_privategw_aclSuccess82.20test_privategw_acl.py
test_01_primary_storage_nfsSuccess35.68test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.15test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.33test_portable_publicip.py
test_isolate_network_password_serverSuccess88.86test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.10test_over_provisioning.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.51test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess5.50test_outofbandmanagement.py
test_oobm_issue_power_softSuccess10.52test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_onSuccess10.51test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.52test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess62.34test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.13test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.14test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.09test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.08test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.09test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.70test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.24test_non_contigiousvlan.py
test_01_nicSuccess634.72test_nic.py
test_releaseIPSuccess152.38test_network.py
test_reboot_routerSuccess418.34test_network.py
test_public_ip_user_accountSuccess10.21test_network.py
test_public_ip_admin_accountSuccess40.25test_network.py
test_delete_accountSuccess252.60test_network.py
test_02_port_fwd_on_non_src_natSuccess55.48test_network.py
test_01_port_fwd_on_src_natSuccess109.60test_network.py
test_nic_secondaryip_add_removeSuccess267.74test_multipleips_per_nic.py
login_test_saml_userSuccess21.28test_login.py
test_assign_and_removal_lbSuccess132.81test_loadbalance.py
test_02_create_lb_rule_non_natSuccess186.82test_loadbalance.py
test_01_create_lb_rule_src_natSuccess217.21test_loadbalance.py
test_03_list_snapshotsSuccess0.06test_list_ids_parameter.py
test_02_list_templatesSuccess0.03test_list_ids_parameter.py
test_01_list_volumesSuccess0.02test_list_ids_parameter.py
test_07_list_default_isoSuccess0.04test_iso.py
test_05_iso_permissionsSuccess0.04test_iso.py
test_04_extract_IsoSuccess5.11test_iso.py
test_03_delete_isoSuccess95.17test_iso.py
test_02_edit_isoSuccess0.04test_iso.py
test_01_create_isoSuccess21.26test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess202.34test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess163.11test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success452.43test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success414.70test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.21test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.65test_global_settings.py
test_rolepermission_lifecycle_updateSuccess6.37test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.26test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess6.15test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess6.18test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.27test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess6.18test_dynamicroles.py
test_role_lifecycle_updateSuccess11.25test_dynamicroles.py
test_role_lifecycle_listSuccess6.19test_dynamicroles.py
test_role_lifecycle_deleteSuccess11.22test_dynamicroles.py
test_role_lifecycle_createSuccess6.19test_dynamicroles.py
test_role_inuse_deletionSuccess6.22test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess7.66test_dynamicroles.py
test_role_account_aclsSuccess7.64test_dynamicroles.py
test_default_role_deletionSuccess6.28test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.05test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.03test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.04test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.05test_disk_offerings.py
test_01_create_disk_offeringSuccess0.07test_disk_offerings.py
test_deployvm_userdispersingSuccess20.44test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess65.61test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess45.40test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess10.27test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess45.65test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess6.40test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess6.26test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess237.56test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess247.68test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess55.61test_affinity_groups.py
test_03_delete_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_02_revert_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_01_test_vm_volume_snapshotSkipped0.00test_vm_snapshots.py
test_01_create_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.01test_staticroles.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.03test_primary_storage.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.03test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.03test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Nov 8, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 8, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 8, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-152

@yadvr

yadvr commented Nov 8, 2016

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Nov 8, 2016

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@murali-reddy

murali-reddy commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

@jburwell#1659 has a fix which complements this patch.Basically when first IP is associated with an interface routing table is created and should be deleted when last IP associated is removed. #1659 handles that case.

@vilisseranen could you please see if there is regression. Looks like IP may be getting removed from ips.json data bag, but not really getting dis-associated from the interface. Failure in below tests indicate so.

test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Failure 36.36 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Failure 31.31 test_network.py
est_network_rules_acquired_public_ip_1_static_nat_rule Failure 93.29 test_network.py

@blueorangutan

blueorangutan commented Nov 9, 2016

Copy link
Copy Markdown

Trillian test result (tid-315)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1706-t315-vmware-55u3.zip
Test completed. 44 look ok, 4 have error(s)

TestResultTime (s)Test File
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleFailure41.83test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleFailure31.59test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleFailure94.90test_network.py
test_01_vpc_site2site_vpnError486.90test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnError743.77test_vpc_vpn.py
test_06_stop_cpvmError415.91test_ssvm.py
test_01_snapshot_root_diskError15.22test_snapshots.py
ContextSuite context=TestSnapshotRootDisk>:teardownError65.58test_snapshots.py
test_01_vpc_remote_access_vpnSuccess146.77test_vpc_vpn.py
test_02_VPC_default_routesSuccess315.46test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess747.72test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess683.07test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1554.80test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess680.07test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess719.78test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1473.36test_vpc_redundant.py
test_09_delete_detached_volumeSuccess25.98test_volumes.py
test_06_download_detached_volumeSuccess60.67test_volumes.py
test_05_detach_volumeSuccess100.27test_volumes.py
test_04_delete_attached_volumeSuccess10.22test_volumes.py
test_03_download_attached_volumeSuccess20.39test_volumes.py
test_02_attach_volumeSuccess53.78test_volumes.py
test_01_create_volumeSuccess460.61test_volumes.py
test_03_delete_vm_snapshotsSuccess280.27test_vm_snapshots.py
test_02_revert_vm_snapshotsSuccess237.15test_vm_snapshots.py
test_01_test_vm_volume_snapshotSuccess146.47test_vm_snapshots.py
test_01_create_vm_snapshotsSuccess161.87test_vm_snapshots.py
test_deploy_vm_multipleSuccess253.77test_vm_life_cycle.py
test_deploy_vmSuccess0.03test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.03test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.94test_vm_life_cycle.py
test_09_expunge_vmSuccess125.20test_vm_life_cycle.py
test_08_migrate_vmSuccess71.09test_vm_life_cycle.py
test_07_restore_vmSuccess0.10test_vm_life_cycle.py
test_06_destroy_vmSuccess10.16test_vm_life_cycle.py
test_03_reboot_vmSuccess5.15test_vm_life_cycle.py
test_02_start_vmSuccess20.26test_vm_life_cycle.py
test_01_stop_vmSuccess10.16test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess262.25test_templates.py
test_08_list_system_templatesSuccess0.03test_templates.py
test_07_list_public_templatesSuccess0.04test_templates.py
test_05_template_permissionsSuccess0.06test_templates.py
test_04_extract_templateSuccess15.39test_templates.py
test_03_delete_templateSuccess5.11test_templates.py
test_02_edit_templateSuccess90.17test_templates.py
test_01_create_templateSuccess126.13test_templates.py
test_10_destroy_cpvmSuccess328.61test_ssvm.py
test_09_destroy_ssvmSuccess299.93test_ssvm.py
test_08_reboot_cpvmSuccess186.65test_ssvm.py
test_07_reboot_ssvmSuccess158.82test_ssvm.py
test_05_stop_ssvmSuccess183.74test_ssvm.py
test_04_cpvm_internalsSuccess1.41test_ssvm.py
test_03_ssvm_internalsSuccess4.06test_ssvm.py
test_02_list_cpvm_vmSuccess0.13test_ssvm.py
test_01_list_sec_storage_vmSuccess0.13test_ssvm.py
test_04_change_offering_smallSuccess96.90test_service_offerings.py
test_03_delete_service_offeringSuccess0.04test_service_offerings.py
test_02_edit_service_offeringSuccess0.08test_service_offerings.py
test_01_create_service_offeringSuccess0.09test_service_offerings.py
test_02_sys_template_readySuccess0.14test_secondary_storage.py
test_01_sys_vm_startSuccess0.25test_secondary_storage.py
test_09_reboot_routerSuccess120.82test_routers.py
test_08_start_routerSuccess110.84test_routers.py
test_07_stop_routerSuccess20.25test_routers.py
test_06_router_advancedSuccess0.06test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.65test_routers.py
test_03_restart_network_cleanupSuccess146.01test_routers.py
test_02_router_internal_advSuccess0.99test_routers.py
test_01_router_internal_basicSuccess0.53test_routers.py
test_router_dns_guestipquerySuccess76.70test_router_dns.py
test_router_dns_externalipquerySuccess0.06test_router_dns.py
test_router_dhcphostsSuccess139.14test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.09test_resource_detail.py
test_01_reset_vm_on_rebootSuccess70.57test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.21test_pvlan.py
test_dedicatePublicIpRangeSuccess0.45test_public_ip_range.py
test_04_rvpc_privategw_static_routesSuccess1087.23test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess1170.60test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess708.77test_privategw_acl.py
test_01_vpc_privategw_aclSuccess193.91test_privategw_acl.py
test_01_primary_storage_nfsSuccess37.12test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.19test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.49test_portable_publicip.py
test_isolate_network_password_serverSuccess59.31test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.19test_over_provisioning.py
test_oobm_zchange_passwordSuccess21.02test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.51test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.52test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.52test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.52test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.53test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.51test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.52test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess52.63test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.19test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.12test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess0.18test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.17test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.12test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.11test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess23.95test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.45test_non_contigiousvlan.py
test_01_nicSuccess632.15test_nic.py
test_releaseIPSuccess289.27test_network.py
test_reboot_routerSuccess676.69test_network.py
test_public_ip_user_accountSuccess10.25test_network.py
test_public_ip_admin_accountSuccess40.29test_network.py
test_delete_accountSuccess334.14test_network.py
test_02_port_fwd_on_non_src_natSuccess55.64test_network.py
test_01_port_fwd_on_src_natSuccess111.80test_network.py
test_nic_secondaryip_add_removeSuccess274.01test_multipleips_per_nic.py
login_test_saml_userSuccess24.58test_login.py
test_assign_and_removal_lbSuccess143.24test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.03test_loadbalance.py
test_01_create_lb_rule_src_natSuccess200.08test_loadbalance.py
test_03_list_snapshotsSuccess0.08test_list_ids_parameter.py
test_02_list_templatesSuccess0.04test_list_ids_parameter.py
test_01_list_volumesSuccess0.03test_list_ids_parameter.py
test_07_list_default_isoSuccess0.06test_iso.py
test_05_iso_permissionsSuccess0.07test_iso.py
test_04_extract_IsoSuccess5.15test_iso.py
test_03_delete_isoSuccess95.18test_iso.py
test_02_edit_isoSuccess0.06test_iso.py
test_01_create_isoSuccess21.87test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess606.34test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess394.78test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success1048.90test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success807.35test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.27test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.13test_global_settings.py
test_rolepermission_lifecycle_updateSuccess7.26test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.86test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess6.73test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess6.76test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.90test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess6.80test_dynamicroles.py
test_role_lifecycle_updateSuccess11.87test_dynamicroles.py
test_role_lifecycle_listSuccess6.81test_dynamicroles.py
test_role_lifecycle_deleteSuccess11.82test_dynamicroles.py
test_role_lifecycle_createSuccess6.82test_dynamicroles.py
test_role_inuse_deletionSuccess6.78test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess9.17test_dynamicroles.py
test_role_account_aclsSuccess9.12test_dynamicroles.py
test_default_role_deletionSuccess7.01test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.07test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.04test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.06test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.07test_disk_offerings.py
test_01_create_disk_offeringSuccess0.11test_disk_offerings.py
test_deployvm_userdispersingSuccess50.75test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess116.14test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess226.82test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess30.50test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess176.77test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess6.76test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess6.78test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess6.85test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess168.10test_deploy_vm_iso.py
test_3d_gpu_supportSuccess456.11test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroupSuccess196.88test_affinity_groups.py
test_08_resize_volumeSkipped5.11test_volumes.py
test_07_resize_failSkipped10.29test_volumes.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.03test_ssvm.py
test_01_scale_vmSkipped66.31test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped1.99test_deploy_vgpu_enabled_vm.py

nathanejohnson added a commit to myENA/cloudstack that referenced this pull request Nov 9, 2016
@nathanejohnson
EC-1147 Rolling in PR 1706
0cc5417
apache#1706
CLOUDSTACK-9500: remove the IP from the databag if it is not used
@jburwell

jburwell commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

@murali-reddy should we merge #1659 and then re-base this PR before running more tests?

nathanejohnson added a commit to myENA/cloudstack that referenced this pull request Nov 9, 2016
@nathanejohnson
EC-1147 Rolling in PR 1706
1a664ec
apache#1706
CLOUDSTACK-9500: remove the IP from the databag if it is not used
@nathanejohnsonnathanejohnson mentioned this pull request Nov 10, 2016
Merged
@remibergsma

remibergsma commented Nov 16, 2016

Copy link
Copy Markdown
Contributor

@pdion891 Sorry for being late to the party. We've seen this issue too and resolved it in a different way. Removing the ip from the databag probably won't work too well, as it is used to deprovision the old ip address from the router. This is what works well for us instead: https://github.com/MissionCriticalCloud/cosmic/pull/114/files

@yadvr

yadvr commented Nov 20, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@nathanejohnson@vilisseranen can we have a conclusion on this PR, thanks.

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-195

@yadvr

yadvr commented Nov 24, 2016

Copy link
Copy Markdown
Member

@vilisseranen@nathanejohnson can you consider suggestion from @remibergsma and apply suitable changes, thanks.

@yadvr

yadvr commented Nov 28, 2016

Copy link
Copy Markdown
Member

@murali-reddy can you help review this? thanks.

@swillswill mentioned this pull request Dec 9, 2016
Merged
@swill

swill commented Dec 9, 2016

Copy link
Copy Markdown
Contributor

The merge conflict between this PR and #1741 is a bit tricky, so I have included this fix in #1741. @vilisseranen and I are currently running both PRs in production so we had to resolve the merge conflict for our deployment. Since the resolution is not trivial, I thought it made sense to just include this fix in my PR.

@swillswill mentioned this pull request Jan 16, 2017
Merged
@swill

swill commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

We have proven that the fix in this PR does not work. I have removed it from #1741.

A new PR which we have proven does work is at: #1907

@swill

swill commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

@vilisseranen can you close this PR?

@vilisseranen

vilisseranen commented Jan 18, 2017

Copy link
Copy Markdown
Author

This PR was not working as expected. See PR from @remibergsma for a proper fix.

asfgit pushed a commit that referenced this pull request Feb 28, 2017
@karuturi
Merge pull request#1907from swill/fix_vr_ip
017c42b
Fix public IPs not being removed from the VR when deprovisionedThis PR replaces #1706. It does not remove the IP from the database, but it does deprovision the IP correctly from the VR when the public IP is removed.
* pr/1907:
Fix public IPs not being removed from the VR when deprovisioned
Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@vilisseranen@pdion891@yadvr@blueorangutan@remibergsma@ustcweizhou@jburwell@murali-reddy@swill