Skip to content

CLOUDSTACK-9397: Add Watchdog timer to KVM Instance - #1707

Merged
yadvr merged 1 commit into
apache:masterfrom
wido:watchdog-timer
Sep 28, 2017
Merged

CLOUDSTACK-9397: Add Watchdog timer to KVM Instance#1707
yadvr merged 1 commit into
apache:masterfrom
wido:watchdog-timer

Conversation

@wido

@widowido commented Oct 13, 2016

Copy link
Copy Markdown
Contributor

The watchdog timer adds functionality where the Hypervisor can detect if an
instance has crashed or stopped functioning.

When the Instance has the 'watchdog' daemon running it will send heartbeats
to the /dev/watchdog device.

If these heartbeats are no longer received by the HV it will reset the Instance.

If the Instance never sends the heartbeats the HV does not take action. It only
takes action if it stops sending heartbeats.

This is supported since Libvirt 0.7.3 and can be defined in the XML format as
described in the docs: https://libvirt.org/formatdomain.html#elementsWatchdog

To the 'devices' section this will be added:

In the agent.properties the action to be taken can be defined:

vm.watchdog.action=reset

The same goes for the model. The Intel i6300esb is however the most commonly used.

vm.watchdog.model=i6300esb

@yadvr

yadvr commented Nov 2, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 2, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 2, 2016

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-140

@yadvr

yadvr commented Nov 3, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 3, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 3, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-142

@yadvr

yadvr commented Nov 20, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-196

@wido

wido commented Dec 7, 2016

Copy link
Copy Markdown
ContributorAuthor

I fixed the merge conflict of this PR and it should cleanly merge now.

@yadvr

yadvr commented Dec 7, 2016

Copy link
Copy Markdown
Member

Thanks @wido I'll kick some tests
@blueorangutan package

@blueorangutan

blueorangutan commented Dec 7, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 7, 2016

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✖debian. JID-337

@yadvr

yadvr commented Dec 7, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 7, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 7, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-342

@yadvr

yadvr commented Dec 8, 2016

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 8, 2016

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Dec 8, 2016

Copy link
Copy Markdown

Trillian test result (tid-614)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31536 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t614-kvm-centos7.zip
Test completed. 42 look ok, 7 have error(s)

TestResultTime (s)Test File
test_02_VPC_default_routesFailure917.71test_vpc_router_nics.py
test_01_VPC_nics_after_destroyFailure998.58test_vpc_router_nics.py
test_05_rvpc_multi_tiersFailure148.41test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsFailure97.47test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersFailure158.02test_vpc_redundant.py
test_02_redundant_VPC_default_routesFailure143.27test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure148.20test_vpc_redundant.py
test_router_dhcphostsFailure95.80test_router_dhcphosts.py
test_04_rvpc_privategw_static_routesFailure1129.83test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure1094.63test_privategw_acl.py
test_02_vpc_privategw_static_routesFailure1049.14test_privategw_acl.py
test_isolate_network_password_serverFailure62.76test_password_server.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure357.30test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure357.44test_internal_lb.py
test_01_vpc_site2site_vpnError357.34test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnError527.94test_vpc_vpn.py
test_05_rvpc_multi_tiersError445.31test_vpc_redundant.py
ContextSuite context=TestRouterDHCPHosts>:teardownError151.17test_router_dhcphosts.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesError261.53test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesError221.42test_internal_lb.py
test_01_vpc_remote_access_vpnSuccess65.82test_vpc_vpn.py
test_09_delete_detached_volumeSuccess15.36test_volumes.py
test_08_resize_volumeSuccess15.29test_volumes.py
test_07_resize_failSuccess20.36test_volumes.py
test_06_download_detached_volumeSuccess15.30test_volumes.py
test_05_detach_volumeSuccess100.18test_volumes.py
test_04_delete_attached_volumeSuccess10.15test_volumes.py
test_03_download_attached_volumeSuccess15.23test_volumes.py
test_02_attach_volumeSuccess73.68test_volumes.py
test_01_create_volumeSuccess713.26test_volumes.py
test_deploy_vm_multipleSuccess267.48test_vm_life_cycle.py
test_deploy_vmSuccess0.02test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.52test_vm_life_cycle.py
test_09_expunge_vmSuccess125.21test_vm_life_cycle.py
test_08_migrate_vmSuccess40.68test_vm_life_cycle.py
test_07_restore_vmSuccess0.08test_vm_life_cycle.py
test_06_destroy_vmSuccess130.69test_vm_life_cycle.py
test_03_reboot_vmSuccess130.70test_vm_life_cycle.py
test_02_start_vmSuccess10.14test_vm_life_cycle.py
test_01_stop_vmSuccess45.27test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess120.72test_templates.py
test_08_list_system_templatesSuccess0.02test_templates.py
test_07_list_public_templatesSuccess0.03test_templates.py
test_05_template_permissionsSuccess0.04test_templates.py
test_04_extract_templateSuccess5.13test_templates.py
test_03_delete_templateSuccess5.09test_templates.py
test_02_edit_templateSuccess90.11test_templates.py
test_01_create_templateSuccess85.51test_templates.py
test_10_destroy_cpvmSuccess171.51test_ssvm.py
test_09_destroy_ssvmSuccess168.55test_ssvm.py
test_08_reboot_cpvmSuccess136.48test_ssvm.py
test_07_reboot_ssvmSuccess138.61test_ssvm.py
test_06_stop_cpvmSuccess136.61test_ssvm.py
test_05_stop_ssvmSuccess143.59test_ssvm.py
test_04_cpvm_internalsSuccess1.24test_ssvm.py
test_03_ssvm_internalsSuccess3.87test_ssvm.py
test_02_list_cpvm_vmSuccess0.09test_ssvm.py
test_01_list_sec_storage_vmSuccess0.09test_ssvm.py
test_01_snapshot_root_diskSuccess11.00test_snapshots.py
test_04_change_offering_smallSuccess245.80test_service_offerings.py
test_03_delete_service_offeringSuccess0.03test_service_offerings.py
test_02_edit_service_offeringSuccess0.04test_service_offerings.py
test_01_create_service_offeringSuccess0.08test_service_offerings.py
test_02_sys_template_readySuccess0.09test_secondary_storage.py
test_01_sys_vm_startSuccess0.14test_secondary_storage.py
test_09_reboot_routerSuccess60.40test_routers.py
test_08_start_routerSuccess40.26test_routers.py
test_07_stop_routerSuccess15.14test_routers.py
test_06_router_advancedSuccess0.04test_routers.py
test_05_router_basicSuccess0.03test_routers.py
test_04_restart_network_wo_cleanupSuccess5.64test_routers.py
test_03_restart_network_cleanupSuccess60.44test_routers.py
test_02_router_internal_advSuccess1.02test_routers.py
test_01_router_internal_basicSuccess0.55test_routers.py
test_router_dns_guestipquerySuccess76.65test_router_dns.py
test_router_dns_externalipquerySuccess0.06test_router_dns.py
test_router_dhcp_optsSuccess21.54test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.06test_resource_detail.py
test_01_reset_vm_on_rebootSuccess175.92test_reset_vm_on_reboot.py
test_createRegionSuccess0.03test_regions.py
test_create_pvlan_networkSuccess5.16test_pvlan.py
test_dedicatePublicIpRangeSuccess0.29test_public_ip_range.py
test_01_vpc_privategw_aclSuccess96.59test_privategw_acl.py
test_01_primary_storage_nfsSuccess35.72test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.14test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.51test_portable_publicip.py
test_UpdateStorageOverProvisioningFactorSuccess0.10test_over_provisioning.py
test_oobm_zchange_passwordSuccess30.47test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.25test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.18test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.23test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.24test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.23test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.33test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.23test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess77.16test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.12test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess5.09test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.24test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.07test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.06test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.06test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.32test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.24test_non_contigiousvlan.py
test_01_nicSuccess529.07test_nic.py
test_releaseIPSuccess307.32test_network.py
test_reboot_routerSuccess437.72test_network.py
test_public_ip_user_accountSuccess10.20test_network.py
test_public_ip_admin_accountSuccess40.20test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess66.60test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.63test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess154.10test_network.py
test_delete_accountSuccess342.69test_network.py
test_02_port_fwd_on_non_src_natSuccess55.49test_network.py
test_01_port_fwd_on_src_natSuccess111.58test_network.py
test_nic_secondaryip_add_removeSuccess297.51test_multipleips_per_nic.py
login_test_saml_userSuccess17.78test_login.py
test_assign_and_removal_lbSuccess133.47test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.20test_loadbalance.py
test_01_create_lb_rule_src_natSuccess227.56test_loadbalance.py
test_03_list_snapshotsSuccess0.06test_list_ids_parameter.py
test_02_list_templatesSuccess0.03test_list_ids_parameter.py
test_01_list_volumesSuccess0.02test_list_ids_parameter.py
test_07_list_default_isoSuccess0.04test_iso.py
test_05_iso_permissionsSuccess0.04test_iso.py
test_04_extract_IsoSuccess5.27test_iso.py
test_03_delete_isoSuccess95.17test_iso.py
test_02_edit_isoSuccess0.04test_iso.py
test_01_create_isoSuccess20.69test_iso.py
test_dedicateGuestVlanRangeSuccess10.25test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.12test_global_settings.py
test_rolepermission_lifecycle_updateSuccess5.83test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess5.67test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess5.58test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess5.79test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess5.79test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess5.62test_dynamicroles.py
test_role_lifecycle_updateSuccess10.66test_dynamicroles.py
test_role_lifecycle_listSuccess5.60test_dynamicroles.py
test_role_lifecycle_deleteSuccess10.63test_dynamicroles.py
test_role_lifecycle_createSuccess5.60test_dynamicroles.py
test_role_inuse_deletionSuccess5.58test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess6.92test_dynamicroles.py
test_role_account_aclsSuccess7.06test_dynamicroles.py
test_default_role_deletionSuccess5.67test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.06test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.03test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.09test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.05test_disk_offerings.py
test_01_create_disk_offeringSuccess0.08test_disk_offerings.py
test_deployvm_userdispersingSuccess20.41test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess61.07test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess55.49test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess10.26test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess50.48test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess5.65test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess5.65test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess262.22test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess237.43test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess120.94test_affinity_groups.py
test_03_delete_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_02_revert_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_01_test_vm_volume_snapshotSkipped0.00test_vm_snapshots.py
test_01_create_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.03test_primary_storage.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.03test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.03test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Dec 8, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 8, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 8, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-365

@yadvr

yadvr commented Dec 9, 2016

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 9, 2016

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Dec 9, 2016

Copy link
Copy Markdown

Trillian test result (tid-638)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27687 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t638-kvm-centos7.zip
Test completed. 45 look ok, 4 have error(s)

TestResultTime (s)Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure407.80test_vpc_redundant.py
test_04_rvpc_privategw_static_routesFailure379.10test_privategw_acl.py
ContextSuite context=TestTemplates>:setupError354.09test_templates.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
test_01_vpc_site2site_vpnSuccess169.33test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess70.80test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnSuccess304.86test_vpc_vpn.py
test_02_VPC_default_routesSuccess366.80test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess567.31test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess538.71test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1457.23test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess607.93test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess784.38test_vpc_redundant.py
test_09_delete_detached_volumeSuccess15.79test_volumes.py
test_08_resize_volumeSuccess15.25test_volumes.py
test_07_resize_failSuccess20.43test_volumes.py
test_06_download_detached_volumeSuccess15.24test_volumes.py
test_05_detach_volumeSuccess100.24test_volumes.py
test_04_delete_attached_volumeSuccess10.15test_volumes.py
test_03_download_attached_volumeSuccess15.24test_volumes.py
test_02_attach_volumeSuccess73.68test_volumes.py
test_01_create_volumeSuccess724.49test_volumes.py
test_deploy_vm_multipleSuccess271.94test_vm_life_cycle.py
test_deploy_vmSuccess0.02test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.55test_vm_life_cycle.py
test_09_expunge_vmSuccess125.17test_vm_life_cycle.py
test_08_migrate_vmSuccess40.64test_vm_life_cycle.py
test_07_restore_vmSuccess0.09test_vm_life_cycle.py
test_06_destroy_vmSuccess130.60test_vm_life_cycle.py
test_03_reboot_vmSuccess130.67test_vm_life_cycle.py
test_02_start_vmSuccess10.12test_vm_life_cycle.py
test_01_stop_vmSuccess45.26test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess126.44test_templates.py
test_01_create_templateSuccess95.59test_templates.py
test_10_destroy_cpvmSuccess171.51test_ssvm.py
test_09_destroy_ssvmSuccess228.73test_ssvm.py
test_08_reboot_cpvmSuccess136.60test_ssvm.py
test_07_reboot_ssvmSuccess139.18test_ssvm.py
test_06_stop_cpvmSuccess166.72test_ssvm.py
test_05_stop_ssvmSuccess140.53test_ssvm.py
test_04_cpvm_internalsSuccess1.17test_ssvm.py
test_03_ssvm_internalsSuccess3.81test_ssvm.py
test_02_list_cpvm_vmSuccess0.08test_ssvm.py
test_01_list_sec_storage_vmSuccess0.09test_ssvm.py
test_01_snapshot_root_diskSuccess11.01test_snapshots.py
test_04_change_offering_smallSuccess244.40test_service_offerings.py
test_03_delete_service_offeringSuccess0.03test_service_offerings.py
test_02_edit_service_offeringSuccess0.05test_service_offerings.py
test_01_create_service_offeringSuccess0.07test_service_offerings.py
test_02_sys_template_readySuccess0.08test_secondary_storage.py
test_01_sys_vm_startSuccess0.12test_secondary_storage.py
test_09_reboot_routerSuccess45.31test_routers.py
test_08_start_routerSuccess30.22test_routers.py
test_07_stop_routerSuccess15.14test_routers.py
test_06_router_advancedSuccess0.04test_routers.py
test_05_router_basicSuccess0.03test_routers.py
test_04_restart_network_wo_cleanupSuccess5.64test_routers.py
test_03_restart_network_cleanupSuccess65.44test_routers.py
test_02_router_internal_advSuccess1.01test_routers.py
test_01_router_internal_basicSuccess0.56test_routers.py
test_router_dns_guestipquerySuccess76.79test_router_dns.py
test_router_dns_externalipquerySuccess0.06test_router_dns.py
test_router_dhcphostsSuccess287.50test_router_dhcphosts.py
test_router_dhcp_optsSuccess21.48test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.05test_resource_detail.py
test_01_reset_vm_on_rebootSuccess165.78test_reset_vm_on_reboot.py
test_createRegionSuccess0.03test_regions.py
test_create_pvlan_networkSuccess5.15test_pvlan.py
test_dedicatePublicIpRangeSuccess0.27test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess644.92test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess428.71test_privategw_acl.py
test_01_vpc_privategw_aclSuccess116.64test_privategw_acl.py
test_01_primary_storage_nfsSuccess35.81test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.12test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.32test_portable_publicip.py
test_isolate_network_password_serverSuccess86.26test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.09test_over_provisioning.py
test_oobm_zchange_passwordSuccess30.46test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.25test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.18test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.23test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.22test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.24test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.24test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.22test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess92.14test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.33test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.12test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess0.22test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.14test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.08test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.11test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.37test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.22test_non_contigiousvlan.py
test_01_nicSuccess553.65test_nic.py
test_releaseIPSuccess166.63test_network.py
test_reboot_routerSuccess457.82test_network.py
test_public_ip_user_accountSuccess10.17test_network.py
test_public_ip_admin_accountSuccess40.18test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess66.57test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.46test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess124.35test_network.py
test_delete_accountSuccess312.06test_network.py
test_02_port_fwd_on_non_src_natSuccess55.44test_network.py
test_01_port_fwd_on_src_natSuccess111.62test_network.py
test_nic_secondaryip_add_removeSuccess216.75test_multipleips_per_nic.py
login_test_saml_userSuccess17.75test_login.py
test_assign_and_removal_lbSuccess133.16test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.53test_loadbalance.py
test_01_create_lb_rule_src_natSuccess228.42test_loadbalance.py
test_07_list_default_isoSuccess0.04test_iso.py
test_05_iso_permissionsSuccess0.04test_iso.py
test_04_extract_IsoSuccess5.12test_iso.py
test_03_delete_isoSuccess95.16test_iso.py
test_02_edit_isoSuccess0.04test_iso.py
test_01_create_isoSuccess20.65test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess273.41test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess192.49test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Success550.97test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success489.68test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.21test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.09test_global_settings.py
test_rolepermission_lifecycle_updateSuccess5.84test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess5.65test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess5.56test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess5.59test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess5.66test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess5.62test_dynamicroles.py
test_role_lifecycle_updateSuccess10.64test_dynamicroles.py
test_role_lifecycle_listSuccess5.59test_dynamicroles.py
test_role_lifecycle_deleteSuccess10.60test_dynamicroles.py
test_role_lifecycle_createSuccess5.59test_dynamicroles.py
test_role_inuse_deletionSuccess5.56test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess6.99test_dynamicroles.py
test_role_account_aclsSuccess7.06test_dynamicroles.py
test_default_role_deletionSuccess5.63test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.04test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.02test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.03test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.04test_disk_offerings.py
test_01_create_disk_offeringSuccess0.07test_disk_offerings.py
test_deployvm_userdispersingSuccess20.37test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess20.49test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess125.73test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess10.25test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess110.75test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess5.62test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess5.65test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess281.98test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess226.73test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess75.66test_affinity_groups.py
test_03_delete_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_02_revert_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_01_test_vm_volume_snapshotSkipped0.00test_vm_snapshots.py
test_01_create_vm_snapshotsSkipped0.00test_vm_snapshots.py
test_static_role_account_aclsSkipped0.01test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.01test_ssvm.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.02test_primary_storage.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.02test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.02test_deploy_vgpu_enabled_vm.py

@wido

wido commented Mar 23, 2017

Copy link
Copy Markdown
ContributorAuthor

I rebased the code against master, merges again. Tests are looking good.

@yadvr

yadvr commented Sep 19, 2017

Copy link
Copy Markdown
Member

@wido I can run another round of testing, for comparison I'm using the #2225 test results as baseline for comparison
@blueorangutan package

@blueorangutan

blueorangutan commented Sep 19, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Sep 19, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1103

@yadvr

yadvr commented Sep 19, 2017

Copy link
Copy Markdown
Member

@blueorangutan test centos7 kvm-centos6

@blueorangutan

blueorangutan commented Sep 19, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Sep 20, 2017

Copy link
Copy Markdown

Trillian test result (tid-1529)
Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49877 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1529-kvm-centos6.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 55 look OK, 7 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure66.00test_vpc_vpn.py
test_04_rvpc_privategw_static_routesFailure451.12test_privategw_acl.py
test_01_create_isoFailure1513.55test_iso.py
test_05_change_vm_ostype_restartFailure21.35test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskFailure11.04test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartFailure141.87test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtFailure0.77test_deploy_virtio_scsi_vm.py
ContextSuite context=TestRedundantIsolateNetworks>:setupError1815.07test_routers_network_ops.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
ContextSuite context=TestISO>:setupError3032.19test_iso.py
ContextSuite context=TestInternalLb>:setupError0.00test_internal_lb.py
test_change_service_offering_for_vm_with_snapshotsSkipped0.00test_vm_snapshots.py
test_09_copy_delete_templateSkipped0.03test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_02_list_snapshots_with_removed_data_storeSkipped0.00test_snapshots.py
test_01_snapshot_root_diskSkipped0.00test_snapshots.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.03test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_list_ha_for_host_validSkipped0.03test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.03test_hostha_simulator.py
test_list_ha_for_hostSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.03test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.04test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.03test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.04test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.03test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.02test_hostha_simulator.py
test_ha_list_providersSkipped0.04test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.06test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.05test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.06test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.02test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.04test_hostha_simulator.py
test_deploy_vgpu_enabled_vmSkipped0.05test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.04test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Sep 20, 2017

Copy link
Copy Markdown
Member

@borisstoyanov can you check failures related to libvirt tests on kvm/centos6, however those failures are not seen in kvm/centos7? /cc @wido

@wido

wido commented Sep 21, 2017

Copy link
Copy Markdown
ContributorAuthor

Is virtio-scsi supported in CentOS 6 by libvirt? I doubt it.

@kiwiflyer

kiwiflyer commented Sep 21, 2017

Copy link
Copy Markdown
Contributor

According to Redhat, it's supported in RHEL6 U4, so it's quite possible it's supported in Centos 6.4 and beyond, but we haven't tested it. All of our testing was Centos 7.x.

@yadvr

yadvr commented Sep 22, 2017

Copy link
Copy Markdown
Member

@wido I think Trillian may be using CentOS 6.8 for buildilng kvm hosts, @borisstoyanov@PaulAngus can you comment?

@wido

wido commented Sep 22, 2017

Copy link
Copy Markdown
ContributorAuthor

Understood! It was my only explanation I could give for this error. Right now I don't know anything else.

borisstoyanov
borisstoyanov reviewed Sep 25, 2017
View reviewed changes

@borisstoyanovborisstoyanov left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that these tests fail at CentOS release 6.8 (Final) but pass on CentOS 7... Looks like the discard attribute is missing from the XML on CentOS-6. Please let me know if you need me to retest this once we have a fix. Test failures are observed in the #2225 PR as well (smoke tests on master)

@yadvr

yadvr commented Sep 26, 2017

Copy link
Copy Markdown
Member

Comparing a recent smoketest result against centos6-kvm I don't see an issue with failing tests, they are failing on the baseline as well. However I do see additional failures around routers, isos etc that diverge from the baseline. We may run another round.
@blueorangutan package

@blueorangutan

blueorangutan commented Sep 26, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Sep 26, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1110

@yadvr

yadvr commented Sep 26, 2017

Copy link
Copy Markdown
Member

@blueorangutan test centos7 kvm-centos6

@blueorangutan

blueorangutan commented Sep 26, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been kicked to run smoke tests

@yadvr

yadvr commented Sep 26, 2017

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Sep 26, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Sep 27, 2017

Copy link
Copy Markdown

Trillian test result (tid-1538)
Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56153 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1538-kvm-centos6.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 52 look OK, 10 have error(s)

TestResultTime (s)Test File
test_07_resize_failFailure15.26test_volumes.py
test_10_attachAndDetach_isoFailure1510.82test_vm_life_cycle.py
test_09_destroy_ssvmFailure0.02test_ssvm.py
test_08_reboot_cpvmFailure0.02test_ssvm.py
test_07_reboot_ssvmFailure0.02test_ssvm.py
test_06_stop_cpvmFailure0.02test_ssvm.py
test_05_stop_ssvmFailure0.02test_ssvm.py
test_04_cpvm_internalsFailure0.02test_ssvm.py
test_03_ssvm_internalsFailure0.02test_ssvm.py
test_02_list_cpvm_vmFailure0.02test_ssvm.py
test_01_list_sec_storage_vmFailure0.02test_ssvm.py
test_04_rvpc_privategw_static_routesFailure419.50test_privategw_acl.py
test_05_change_vm_ostype_restartFailure20.86test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskFailure10.69test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartFailure141.30test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtFailure0.62test_deploy_virtio_scsi_vm.py
ContextSuite context=TestVpcSite2SiteVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVPCRedundancy>:setupError0.00test_vpc_redundant.py
test_06_download_detached_volumeError20.22test_volumes.py
test_04_extract_templateError5.08test_templates.py
test_03_delete_templateError5.08test_templates.py
test_01_create_templateError80.51test_templates.py
test_10_destroy_cpvmError5.10test_ssvm.py
ContextSuite context=TestRedundantIsolateNetworks>:setupError1711.98test_routers_network_ops.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
test_change_service_offering_for_vm_with_snapshotsSkipped0.00test_vm_snapshots.py
test_09_copy_delete_templateSkipped0.01test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.01test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.01test_ssvm.py
test_02_list_snapshots_with_removed_data_storeSkipped0.00test_snapshots.py
test_01_snapshot_root_diskSkipped0.00test_snapshots.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.06test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_list_ha_for_host_validSkipped0.02test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.01test_hostha_simulator.py
test_list_ha_for_hostSkipped0.01test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.01test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.01test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.02test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.01test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.01test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.01test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.01test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.01test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.02test_hostha_simulator.py
test_ha_list_providersSkipped0.01test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.01test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.01test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.01test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.02test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.02test_hostha_simulator.py
test_deploy_vgpu_enabled_vmSkipped0.02test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.02test_deploy_vgpu_enabled_vm.py

@blueorangutan

blueorangutan commented Sep 27, 2017

Copy link
Copy Markdown

Trillian test result (tid-1539)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40838 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1539-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 58 look OK, 4 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure65.98test_vpc_vpn.py
test_05_rvpc_multi_tiersFailure207.34test_vpc_redundant.py
test_04_rvpc_privategw_static_routesFailure446.81test_privategw_acl.py
ContextSuite context=TestSnapshotRootDisk>:teardownError102.50test_snapshots.py
test_change_service_offering_for_vm_with_snapshotsSkipped0.00test_vm_snapshots.py
test_09_copy_delete_templateSkipped0.02test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.18test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_list_ha_for_host_validSkipped0.04test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.03test_hostha_simulator.py
test_list_ha_for_hostSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.02test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.02test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.02test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.02test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.02test_hostha_simulator.py
test_ha_list_providersSkipped0.02test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.02test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.02test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.04test_hostha_simulator.py
test_deploy_vgpu_enabled_vmSkipped0.03test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.03test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Sep 28, 2017

Copy link
Copy Markdown
Member

Ignoring test failures on centos6, LGTM. @borisstoyanov@wido@kiwiflyer what do you think, should we merge this PR?

borisstoyanov
borisstoyanov approved these changes Sep 28, 2017
View reviewed changes

@borisstoyanovborisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wido

wido commented Sep 28, 2017

Copy link
Copy Markdown
ContributorAuthor

I personally think we can merge it. But hey, it's my PR, I can't make that decision.

@yadvr

yadvr commented Sep 28, 2017

Copy link
Copy Markdown
Member

@wido can you comment on the potential NPE issue, see the code/comment?

@wido

wido commented Sep 28, 2017

Copy link
Copy Markdown
ContributorAuthor

@rhtyd: I already did? I added a if-statement around the check in case libvirt doesn't return anything. Which is highly unlikely

@yadvr

yadvr commented Sep 28, 2017

Copy link
Copy Markdown
Member

Alright based on test results and LGTMs presented on this PR, I'll merge this. If we hit regressions or error reports, we might revisit this (unlikely).

@yadvr
yadvr merged commit b130e55 into apache:masterSep 28, 2017
lucas-a-martins pushed a commit to scclouds/cloudstack that referenced this pull request Jan 29, 2024
Daniel Augusto Veronezi Salvador
Merge branch 'show-root-disk-offering-in-vm-deployment' into '4.18.0.…
bfdf714
…0-scclouds'
Apresentar _disk offering_ utilizada para o _root disk_ no _wizard_ de _deploy_ de VMs
Closesapache#1707
See merge request scclouds/scclouds!722
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvryadvryadvr left review comments
@GabrielBrascherGabrielBrascherGabrielBrascher approved these changes
@borisstoyanovborisstoyanovborisstoyanov approved these changes

Assignees

No one assigned

Labels

component:kvmtype:enhancement

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@wido@yadvr@blueorangutan@cloudmonger@kiwiflyer@GabrielBrascher@borisstoyanov@DaanHoogland