Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. - #1875
Conversation
sureshanaparti
commented
Feb 20, 2017
@rhtyd Can you run VMware CI on this PR. |
yadvr
commented
Feb 20, 2017
@blueorangutan package |
blueorangutan
commented
Feb 20, 2017
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
blueorangutan
commented
Feb 20, 2017
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-511 |
yadvr
commented
Feb 21, 2017
@blueorangutan test centos7 vmware-55u3 |
blueorangutan
commented
Feb 21, 2017
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
blueorangutan
commented
Feb 21, 2017
Trillian test result (tid-867)
|
sureshanaparti
commented
Feb 21, 2017
@rhtyd Thanks for running tests. The test failures/errors above are failing in other PRs as well, not related to the changes in this PR. |
sureshanaparti
commented
Feb 21, 2017
@sateesh-chodapuneedi @rhtyd Please review the changes. |
| s_logger.debug("Set permissions for " + mountPoint); | ||
| String result = null; | ||
| Script script = new Script(true, "chmod", _timeout, s_logger); | ||
| script.add("-R", "0777", mountPoint); |
There was a problem hiding this comment.
@sureshanaparti In place of using 0777, I think it is better to declare a constant and use it.
| String result = null; | ||
| final String systemVmTmpltPermissions = "0777"; | ||
| Script script = new Script(true, "chmod", _timeout, s_logger); | ||
| script.add("-R", systemVmTmpltPermissions, mountPoint); |
There was a problem hiding this comment.
@SudharmaJain Used the string as suggested instead of hardcoded value for permissions.
There was a problem hiding this comment.
@sureshanaparti It would be better if you can move it to TemplateConstants.
SudharmaJain
commented
Mar 13, 2017
LGTM on the code changes. |
yadvr
commented
Apr 13, 2017
LGTM. |
yadvr
commented
Apr 19, 2017
LGTM, @sureshanaparti since this is a critical bugfix wher systemvm can fail to start, can you change PR's base branch to 4.9? |
sureshanaparti
commented
Apr 24, 2017
@rhtyd Changed PR base branch to 4.9. |
yadvr
commented
Apr 24, 2017
Thanks @sureshanaparti |
blueorangutan
commented
Apr 24, 2017
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
blueorangutan
commented
Apr 24, 2017
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-675 |
yadvr
commented
Apr 24, 2017
@blueorangutan test centos7 vmware-55u3 |
blueorangutan
commented
Apr 24, 2017
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
blueorangutan
commented
Apr 25, 2017
Trillian test result (tid-1033)
|
sureshanaparti
commented
May 4, 2017
The above intermitten failures are not related to this PR changes. |
…ns issue. Provide permissions to template folder when mounted on management server.
yadvr
commented
Jul 22, 2017
@sureshanaparti please rebase/fix the branch |
yadvr
commented
Dec 17, 2017
@sureshanaparti ping, can you fix the conflicts? |
yadvr
commented
Jan 2, 2018
@sureshanaparti this is marked blocker however no activity or discussion is seen, I'll remove the 'blocker' label and ask the author to engage in a conversation. Thanks. |
DaanHoogland
commented
Mar 6, 2020
@sureshanaparti please rebase and re-open if still relevant |
[VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server.
This closes#555