Skip to content

CLOUDSTACK-9450: Network Offering for VPC based on DB flag - #2005

Merged
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/nw_offering_for_vpc
Nov 16, 2017
Merged

CLOUDSTACK-9450: Network Offering for VPC based on DB flag#2005
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/nw_offering_for_vpc

Conversation

@prashanthvarma

@prashanthvarmaprashanthvarma commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

@prashanthvarma

prashanthvarma commented Mar 14, 2017

Copy link
Copy Markdown
ContributorAuthor

PEP8 & PyFlakes compliance of our marvin test code:

CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$

Validations:

Marvin test results:

=> nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_static_nat.py

Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok

Ran 10 tests in 10713.290s

OK

results.txt
runinfo.txt

=> nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_source_nat.py

Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with different Egress ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test

Ran 8 tests in 1490.621s

OK (SKIP=6)

results.txt
runinfo.txt

@prashanthvarma
prashanthvarmaforce-pushed the feature/nw_offering_for_vpc branch 2 times, most recently from f4a9eb2 to d6c4cd4CompareMarch 21, 2017 13:38
@prashanthvarma
prashanthvarmaforce-pushed the feature/nw_offering_for_vpc branch from d6c4cd4 to feff501CompareApril 7, 2017 13:41
@prashanthvarmaprashanthvarma changed the title CLOUDSTACK-9450: Network Offering for VPC based on DB flag[4.11/Future] CLOUDSTACK-9450: Network Offering for VPC based on DB flagApr 11, 2017
@prashanthvarma
prashanthvarmaforce-pushed the feature/nw_offering_for_vpc branch 2 times, most recently from 27ea4a5 to e455e18CompareApril 20, 2017 07:59
@kiwiflyerkiwiflyer added this to the 4.11 milestone May 12, 2017
@prashanthvarmaprashanthvarma changed the title [4.11/Future] CLOUDSTACK-9450: Network Offering for VPC based on DB flagCLOUDSTACK-9450: Network Offering for VPC based on DB flagAug 7, 2017
@fmaximus
fmaximusforce-pushed the feature/nw_offering_for_vpc branch from e455e18 to b14f43cCompareSeptember 29, 2017 13:28
sgoeminn
sgoeminn approved these changes Oct 11, 2017
View reviewed changes

@sgoeminnsgoeminn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

smeetsr
smeetsr approved these changes Oct 23, 2017
View reviewed changes

@smeetsrsmeetsr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_nuage_static_nat.py
Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality by enabling Static Nat when ... === TestName: test_11_nuage_enable_staticNat_when_vr_is_in_starting_state | Status : SUCCESS ===
ok

Ran 11 tests in 10718.290s

OK

test_nuage_source_nat.py
Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with different Egress ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test

Ran 8 tests in 1219.378s

OK (SKIP=6)

@fmaximus
fmaximusforce-pushed the feature/nw_offering_for_vpc branch 3 times, most recently from cabb145 to 281f817CompareNovember 3, 2017 11:35
@fmaximus@smeetsr
CLOUDSTACK-9450: Network Offering for VPC based on DB flag
d467a6b
Co-Authored-By: Raf Smeets <raf.smeets@nuagenetworks.net>
@fmaximus
fmaximusforce-pushed the feature/nw_offering_for_vpc branch from 281f817 to d467a6bCompareNovember 3, 2017 11:39
@DaanHoogland

DaanHoogland commented Nov 13, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 13, 2017

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 13, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1249

@DaanHoogland

DaanHoogland commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan test matrix

@blueorangutan

blueorangutan commented Nov 14, 2017

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Nov 14, 2017

Copy link
Copy Markdown

Trillian test result (tid-1650)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 37448 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2005-t1650-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 58 look OK, 5 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure146.69test_vpc_vpn.py
test_05_rvpc_multi_tiersFailure479.53test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure496.52test_vpc_redundant.py
test_04_rvpc_privategw_static_routesFailure571.00test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure258.73test_privategw_acl.py
test_02_vpc_privategw_static_routesFailure274.02test_privategw_acl.py
test_01_vpc_privategw_aclFailure76.94test_privategw_acl.py
test_05_create_template_with_no_checksumError67.72test_templates.py
test_05_create_template_with_no_checksumError72.81test_templates.py
test_04_create_template_with_checksum_md5Error65.76test_templates.py
test_04_create_template_with_checksum_md5Error70.87test_templates.py
test_04_1_create_template_with_checksum_md5_negativeError72.68test_templates.py
test_05_add_annotation_for_invalid_entityTypeError0.09test_host_annotations.py
test_09_copy_delete_templateSkipped0.02test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.03test_ssvm.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_03_nic_multiple_vmwareSkipped1.16test_nic.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_list_ha_for_host_validSkipped0.03test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.04test_hostha_simulator.py
test_list_ha_for_hostSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.03test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.03test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.04test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.04test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.04test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.03test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.04test_hostha_simulator.py
test_ha_list_providersSkipped0.03test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.03test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.04test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.03test_hostha_simulator.py
test_remove_ha_provider_not_possibleSkipped0.04test_hostha_kvm.py
test_hostha_kvm_host_recoveringSkipped0.04test_hostha_kvm.py
test_hostha_kvm_host_fencingSkipped0.05test_hostha_kvm.py
test_hostha_kvm_host_degradedSkipped0.04test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenanceSkipped0.04test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconectedSkipped0.04test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabledSkipped0.04test_hostha_kvm.py
test_hostha_configure_default_driverSkipped0.04test_hostha_kvm.py
test_disable_oobm_ha_state_ineligibleSkipped0.04test_hostha_kvm.py
test_06_verify_guest_lspci_againSkipped0.00test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciSkipped0.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskSkipped0.00test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtSkipped0.00test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vmSkipped0.04test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.04test_deploy_vgpu_enabled_vm.py

@blueorangutan

blueorangutan commented Nov 14, 2017

Copy link
Copy Markdown

Trillian test result (tid-1652)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52156 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2005-t1652-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 54 look OK, 9 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure141.05test_vpc_vpn.py
test_10_list_volumesFailure61.03test_volumes.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseFailure451.02test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueFailure470.70test_routers_network_ops.py
test_04_rvpc_privategw_static_routesFailure825.42test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure423.41test_privategw_acl.py
test_02_vpc_privategw_static_routesFailure503.79test_privategw_acl.py
test_01_vpc_privategw_aclFailure136.92test_privategw_acl.py
test_09_delete_detached_volumeError20.20test_volumes.py
test_08_resize_volumeError5.07test_volumes.py
test_07_resize_failError10.20test_volumes.py
test_06_download_detached_volumeError5.06test_volumes.py
test_05_detach_volumeError5.07test_volumes.py
test_04_delete_attached_volumeError5.07test_volumes.py
test_03_download_attached_volumeError5.07test_volumes.py
test_02_attach_volumeError15.12test_volumes.py
test_01_create_volumeError25.36test_volumes.py
ContextSuite context=TestVolumes>:teardownError61.13test_volumes.py
test_08_migrate_vmError85.83test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_storeError5.13test_snapshots.py
test_01_primary_storage_nfsError0.12test_primary_storage.py
test_01_add_primary_storage_disabled_hostError0.32test_primary_storage.py
ContextSuite context=TestStorageTags>:setupError0.20test_primary_storage.py
test_05_add_annotation_for_invalid_entityTypeError0.06test_host_annotations.py
test_00_deploy_vm_root_resizeError5.27test_deploy_vm_root_resize.py
test_09_copy_delete_templateSkipped0.01test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.01test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped33.37test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.05test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_06_copy_isoSkipped0.00test_iso.py
test_list_ha_for_host_validSkipped0.02test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.02test_hostha_simulator.py
test_list_ha_for_hostSkipped0.02test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.02test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.02test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.02test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.02test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.02test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.02test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.02test_hostha_simulator.py
test_ha_list_providersSkipped0.02test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.02test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.03test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.02test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.02test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.02test_hostha_simulator.py
test_remove_ha_provider_not_possibleSkipped0.03test_hostha_kvm.py
test_hostha_kvm_host_recoveringSkipped0.03test_hostha_kvm.py
test_hostha_kvm_host_fencingSkipped0.03test_hostha_kvm.py
test_hostha_kvm_host_degradedSkipped0.03test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenanceSkipped0.03test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconectedSkipped0.03test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabledSkipped0.03test_hostha_kvm.py
test_hostha_configure_default_driverSkipped0.03test_hostha_kvm.py
test_disable_oobm_ha_state_ineligibleSkipped0.03test_hostha_kvm.py
test_06_verify_guest_lspci_againSkipped0.00test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciSkipped0.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskSkipped0.00test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtSkipped0.00test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vmSkipped0.76test_deploy_vgpu_enabled_vm.py

@fmaximus

fmaximus commented Nov 15, 2017

Copy link
Copy Markdown
Contributor

Our internal CI was OK, and the errors reported by Trillian don't seem related to the changes,
and the XenServer errors are the same as in the baseline #2289.

@fmaximus
fmaximus merged commit 14ab69e into apache:masterNov 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sgoeminnsgoeminnsgoeminn approved these changes
@smeetsrsmeetsrsmeetsr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:reviews-completetype:enhancement

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@prashanthvarma@DaanHoogland@blueorangutan@fmaximus@sgoeminn@smeetsr@kiwiflyer