Skip to content

CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters - #2091

Merged
yadvr merged 5 commits into
4.11from
unknown repository
Aug 21, 2018
Merged

CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters#2091
yadvr merged 5 commits into
4.11from
unknown repository

Conversation

@sureshanaparti

@sureshanapartisureshanaparti commented May 9, 2017

Copy link
Copy Markdown
Contributor

[VMware] VM is not accessible after migration across clusters.

  • Once a VM is successfully started, don't delete the files associated with the unregistered VM, if the files are in a storage that is being used by the new VM.
  • Attempt to unregister a VM in another DC, only if there is a host associated with a VM.

This closes#556

@sureshanaparti

Copy link
Copy Markdown
ContributorAuthor

@borisstoyanov Can you please run VMware trillian tests on this PR

@borisstoyanov

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-704

@borisstoyanov

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1070)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38743 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2091-t1070-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 48 look ok, 4 have error(s)

TestResultTime (s)Test File
test_04_rvpc_privategw_static_routesFailure391.95test_privategw_acl.py
ContextSuite context=TestInternalLb>:setupError0.00test_internal_lb.py
ContextSuite context=TestDeployVirtioSCSIVM>:setupError0.00test_deploy_virtio_scsi_vm.py
test_01_vpc_site2site_vpnSuccess185.72test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess71.24test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnSuccess286.26test_vpc_vpn.py
test_02_VPC_default_routesSuccess270.83test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess589.27test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess538.76test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1352.07test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess580.14test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess775.69test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1318.43test_vpc_redundant.py
test_09_delete_detached_volumeSuccess156.66test_volumes.py
test_08_resize_volumeSuccess156.46test_volumes.py
test_07_resize_failSuccess161.62test_volumes.py
test_06_download_detached_volumeSuccess151.42test_volumes.py
test_05_detach_volumeSuccess150.83test_volumes.py
test_04_delete_attached_volumeSuccess151.32test_volumes.py
test_03_download_attached_volumeSuccess156.48test_volumes.py
test_02_attach_volumeSuccess89.63test_volumes.py
test_01_create_volumeSuccess711.94test_volumes.py
test_03_delete_vm_snapshotsSuccess275.21test_vm_snapshots.py
test_02_revert_vm_snapshotsSuccess100.89test_vm_snapshots.py
test_01_create_vm_snapshotsSuccess168.96test_vm_snapshots.py
test_deploy_vm_multipleSuccess293.09test_vm_life_cycle.py
test_deploy_vmSuccess0.03test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.04test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.80test_vm_life_cycle.py
test_09_expunge_vmSuccess125.26test_vm_life_cycle.py
test_08_migrate_vmSuccess30.98test_vm_life_cycle.py
test_07_restore_vmSuccess0.13test_vm_life_cycle.py
test_06_destroy_vmSuccess125.90test_vm_life_cycle.py
test_03_reboot_vmSuccess125.92test_vm_life_cycle.py
test_02_start_vmSuccess10.18test_vm_life_cycle.py
test_01_stop_vmSuccess35.30test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess141.51test_templates.py
test_08_list_system_templatesSuccess0.04test_templates.py
test_07_list_public_templatesSuccess0.05test_templates.py
test_05_template_permissionsSuccess0.07test_templates.py
test_04_extract_templateSuccess5.20test_templates.py
test_03_delete_templateSuccess5.12test_templates.py
test_02_edit_templateSuccess90.22test_templates.py
test_01_create_templateSuccess85.76test_templates.py
test_10_destroy_cpvmSuccess161.69test_ssvm.py
test_09_destroy_ssvmSuccess193.79test_ssvm.py
test_08_reboot_cpvmSuccess131.79test_ssvm.py
test_07_reboot_ssvmSuccess133.64test_ssvm.py
test_06_stop_cpvmSuccess131.86test_ssvm.py
test_05_stop_ssvmSuccess138.81test_ssvm.py
test_04_cpvm_internalsSuccess1.24test_ssvm.py
test_03_ssvm_internalsSuccess3.67test_ssvm.py
test_02_list_cpvm_vmSuccess0.16test_ssvm.py
test_01_list_sec_storage_vmSuccess0.14test_ssvm.py
test_02_list_snapshots_with_removed_data_storeSuccess87.06test_snapshots.py
test_01_snapshot_root_diskSuccess16.38test_snapshots.py
test_04_change_offering_smallSuccess239.69test_service_offerings.py
test_03_delete_service_offeringSuccess0.04test_service_offerings.py
test_02_edit_service_offeringSuccess0.06test_service_offerings.py
test_01_create_service_offeringSuccess0.13test_service_offerings.py
test_02_sys_template_readySuccess0.14test_secondary_storage.py
test_01_sys_vm_startSuccess0.18test_secondary_storage.py
test_09_reboot_routerSuccess45.41test_routers.py
test_08_start_routerSuccess35.35test_routers.py
test_07_stop_routerSuccess10.17test_routers.py
test_06_router_advancedSuccess0.06test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.77test_routers.py
test_03_restart_network_cleanupSuccess70.71test_routers.py
test_02_router_internal_advSuccess1.13test_routers.py
test_01_router_internal_basicSuccess0.67test_routers.py
test_router_dns_guestipquerySuccess76.96test_router_dns.py
test_router_dns_externalipquerySuccess0.07test_router_dns.py
test_router_dhcphostsSuccess313.68test_router_dhcphosts.py
test_router_dhcp_optsSuccess21.91test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.12test_resource_detail.py
test_01_reset_vm_on_rebootSuccess130.99test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.23test_pvlan.py
test_dedicatePublicIpRangeSuccess0.53test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess541.09test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess416.39test_privategw_acl.py
test_01_vpc_privategw_aclSuccess102.50test_privategw_acl.py
test_03_migration_options_storage_tagsSuccess161.96test_primary_storage.py
test_02_edit_primary_storage_tagsSuccess0.12test_primary_storage.py
test_01_primary_storage_nfsSuccess35.80test_primary_storage.py
test_01_deploy_vms_storage_tagsSuccess31.22test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.23test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.53test_portable_publicip.py
test_isolate_network_password_serverSuccess89.77test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.16test_over_provisioning.py
test_oobm_zchange_passwordSuccess25.80test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.46test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.32test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.39test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.91test_outofbandmanagement.py
test_oobm_issue_power_onSuccess10.45test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.41test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.42test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess87.79test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.19test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess5.21test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.13test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.09test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.10test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess29.49test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.47test_non_contigiousvlan.py
test_01_nicSuccess434.59test_nic.py
test_releaseIPSuccess293.30test_network.py
test_reboot_routerSuccess403.65test_network.py
test_public_ip_user_accountSuccess10.27test_network.py
test_public_ip_admin_accountSuccess40.32test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess67.13test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess62.04test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess124.26test_network.py
test_delete_accountSuccess318.59test_network.py
test_02_port_fwd_on_non_src_natSuccess55.77test_network.py
test_01_port_fwd_on_src_natSuccess111.77test_network.py
test_nic_secondaryip_add_removeSuccess248.65test_multipleips_per_nic.py
test_list_zones_metricsSuccess0.29test_metrics_api.py
test_list_volumes_metricsSuccess5.50test_metrics_api.py
test_list_vms_metricsSuccess282.69test_metrics_api.py
test_list_pstorage_metricsSuccess0.40test_metrics_api.py
test_list_infrastructure_metricsSuccess0.47test_metrics_api.py
test_list_hosts_metricsSuccess0.41test_metrics_api.py
test_list_clusters_metricsSuccess0.35test_metrics_api.py
login_test_saml_userSuccess19.58test_login.py
test_assign_and_removal_lbSuccess151.07test_loadbalance.py
test_02_create_lb_rule_non_natSuccess187.59test_loadbalance.py
test_01_create_lb_rule_src_natSuccess242.99test_loadbalance.py
test_03_list_snapshotsSuccess0.10test_list_ids_parameter.py
test_02_list_templatesSuccess0.05test_list_ids_parameter.py
test_01_list_volumesSuccess0.04test_list_ids_parameter.py
test_07_list_default_isoSuccess0.07test_iso.py
test_05_iso_permissionsSuccess0.08test_iso.py
test_04_extract_IsoSuccess18.58test_iso.py
test_03_delete_isoSuccess95.17test_iso.py
test_02_edit_isoSuccess0.07test_iso.py
test_01_create_isoSuccess71.32test_iso.py
test_dedicateGuestVlanRangeSuccess10.35test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.14test_global_settings.py
test_rolepermission_lifecycle_updateSuccess6.28test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.02test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess5.90test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess6.05test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.09test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess5.93test_dynamicroles.py
test_role_lifecycle_updateSuccess11.05test_dynamicroles.py
test_role_lifecycle_listSuccess5.95test_dynamicroles.py
test_role_lifecycle_deleteSuccess11.02test_dynamicroles.py
test_role_lifecycle_createSuccess5.96test_dynamicroles.py
test_role_inuse_deletionSuccess5.92test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess8.36test_dynamicroles.py
test_role_account_aclsSuccess8.58test_dynamicroles.py
test_default_role_deletionSuccess6.04test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.12test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.05test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.06test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.11test_disk_offerings.py
test_01_create_disk_offeringSuccess0.12test_disk_offerings.py
test_deployvm_userdispersingSuccess25.89test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess20.77test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess156.41test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess25.51test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess116.26test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resizeSuccess0.07test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resizeSuccess0.07test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resizeSuccess383.04test_deploy_vm_root_resize.py
test_deploy_vm_from_isoSuccess288.24test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroupSuccess186.94test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshotsSkipped0.00test_vm_snapshots.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped0.00test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_nested_virtualization_vmwareSkipped0.00test_nested_virtualization.py
test_06_copy_isoSkipped0.00test_iso.py
test_deploy_vgpu_enabled_vmSkipped0.03test_deploy_vgpu_enabled_vm.py
test_3d_gpu_supportSkipped0.04test_deploy_vgpu_enabled_vm.py

@ghost

Copy link
Copy Markdown

Fix verified. LGTM.

@cloudmonger

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 842
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=4
Skipped=12

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 30 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 30 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 30 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 30 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@yadvryadvr added this to the 4.11 milestone Dec 10, 2017
@yadvr

yadvr commented Jan 4, 2018

Copy link
Copy Markdown
Member

Ping can you fix the conflicts @sureshanaparti

@yadvryadvr modified the milestones: 4.11, 4.12Jan 6, 2018
@resmo

Copy link
Copy Markdown
Member

I would like to see this in 4.11.1 @rhtyd

@yadvr

Copy link
Copy Markdown
Member

@resmo I'll inform that PR author, ultimately it will depend on how responsive the PR author is and if we're able to test,review,merge this PR before 4.11.1 RC1. You may also re-open the PR in case you would like to pursue with this PR yourself.
@sureshanaparti can you re-base the PR against 4.11, fix conflicts?

@yadvryadvr modified the milestones: 4.12.0.0, 4.11.1.0Apr 30, 2018
@yadvr

yadvr commented May 9, 2018

Copy link
Copy Markdown
Member

@sureshanaparti can you rebase this against latest 4.11.
I'll in the interim move this to 4.11.2.0 milestone, if the author does not repond I may take over this PR in future.

@yadvryadvr modified the milestones: 4.11.1.0, 4.11.2.0May 9, 2018
@sureshanaparti

Copy link
Copy Markdown
ContributorAuthor

@rhtyd I'll rebase and update. Thanks.

@yadvr
yadvr changed the base branch from master to 4.11May 11, 2018 11:02
@apacheapache deleted a comment from blueorangutanAug 14, 2018
@yadvr

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2250

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan help

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'ernjvr', 'dhlaluku', 'houthuis', 'charles-phiri']

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test centos6 vmware-55u3

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests

@yadvr

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-65

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2937)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32660 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2091-t2937-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardownError0.00test_deploy_virtio_scsi_vm.py
test_04_extract_templateFailure134.42test_templates.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
test_06_download_detached_volumeFailure160.25test_volumes.py

@yadvryadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr

Copy link
Copy Markdown
Member

Review request - @DaanHoogland@rafaelweingartner@resmo and others

@DaanHoogland

DaanHoogland commented Aug 17, 2018

Copy link
Copy Markdown
Contributor

system VMs did not get up ==>> timeout
@blueorangutan test centos6 vmware-55u3

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test centos6 vmware-55u3

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests

@yadvr

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-55u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2943)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30840 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2091-t2943-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardownError0.00test_deploy_virtio_scsi_vm.py

@DaanHoogland

Copy link
Copy Markdown
Contributor

is scsi virtio supposed to work (in vmware)? @rhtyd @rafaelweingartner, if not, any other test needed?

@yadvr

Copy link
Copy Markdown
Member

No @DaanHoogland, that test should skip for vmware. I would ignore the error for now, maybe fix that smoketest in a different PR.

@borisstoyanov

Copy link
Copy Markdown
Contributor

screen shot 2018-08-21 at 14 04 06
Looks like it's properly skipping all non kvm hypervisors

@resmoresmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr

Copy link
Copy Markdown
Member

@borisstoyanov looks like there was an issue in the tear down of that test

@yadvr

Copy link
Copy Markdown
Member

Merging this based on test results and reviews

@yadvr
yadvr merged commit e9003fa into apache:4.11Aug 21, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@sureshanaparti@borisstoyanov@blueorangutan@cloudmonger@yadvr@resmo@PaulAngus@DaanHoogland@rafaelweingartner@GabrielBrascher