Skip to content

CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out - #2092

Merged
sateesh-chodapuneedi merged 1 commit into
masterfrom
unknown repository
Nov 7, 2017
Merged

CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out#2092
sateesh-chodapuneedi merged 1 commit into
masterfrom
unknown repository

Conversation

@sureshanaparti

@sureshanapartisureshanaparti commented May 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

[VMware] Successful migration was reported as failure when vCenter session timed out.

  • When cancelling a vCenter task, Check whether the vCenter task is cancellable or not. If not, wait for the task to complete.

This closes#544

@sureshanapartisureshanaparti mentioned this pull request May 10, 2017
Closed
yadvr
yadvr reviewed May 16, 2017
View reviewed changes
Comment threadvmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java
throw new RuntimeException("vCenter task failed due to " + we.getLocalizedMessage());

// Since task cancellation is asynchronous, wait for the task to be cancelled
Object[] result = waitForValues(task, new String[] {"info.state", "info.error"}, new String[] {"state"},

@yadvryadvrMay 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a check for length of result to avoid array-bound exceptions when accessing result[0], result[1] etc.

@sureshanapartisureshanapartiMay 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd The properties list to filter in the above waitForValues() are "info.state" and "info.error". The result size returned from waitForValues() would be same as the properties list size, which is 2 and so the result Object array would hold two objects: result[0], result[1].

@yadvryadvrMay 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti I see that however my comment aimed to encourage defensive programming. Maybe now the code works, but it can still improve upon overall elegance and include additional checks to defend future bugs [1].

[1] https://en.wikipedia.org/wiki/Defensive_programming

@sureshanapartisureshanapartiMay 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd ok. will check and update. Thanks for the review.

@sureshanapartisureshanapartiMay 17, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd Updated the code. Please take a look. Thanks.

@yadvryadvrMay 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@yadvr

yadvr commented May 16, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented May 16, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 16, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-728

@yadvr

yadvr commented May 17, 2017

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-55u3

@blueorangutan

blueorangutan commented May 17, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 17, 2017

Copy link
Copy Markdown

Trillian test result (tid-1101)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48272 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2092-t1101-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Test completed. 47 look ok, 5 have error(s)

TestResultTime (s)Test File
test_01_create_volumeFailure189.63test_volumes.py
test_04_rvpc_privategw_static_routesFailure297.72test_privategw_acl.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure111.29test_internal_lb.py
ContextSuite context=TestDeployVmRootSize>:setupError0.00test_deploy_vm_root_resize.py
test_01_vpc_site2site_vpnSuccess461.76test_vpc_vpn.py
test_01_vpc_remote_access_vpnSuccess237.11test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpnSuccess763.97test_vpc_vpn.py
test_02_VPC_default_routesSuccess440.76test_vpc_router_nics.py
test_01_VPC_nics_after_destroySuccess872.96test_vpc_router_nics.py
test_05_rvpc_multi_tiersSuccess718.02test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsSuccess1565.17test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersSuccess795.13test_vpc_redundant.py
test_02_redundant_VPC_default_routesSuccess754.96test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLSuccess1527.07test_vpc_redundant.py
test_09_delete_detached_volumeSuccess31.04test_volumes.py
test_06_download_detached_volumeSuccess80.65test_volumes.py
test_05_detach_volumeSuccess110.35test_volumes.py
test_04_delete_attached_volumeSuccess10.21test_volumes.py
test_03_download_attached_volumeSuccess20.28test_volumes.py
test_02_attach_volumeSuccess74.79test_volumes.py
test_change_service_offering_for_vm_with_snapshotsSuccess529.69test_vm_snapshots.py
test_03_delete_vm_snapshotsSuccess280.27test_vm_snapshots.py
test_02_revert_vm_snapshotsSuccess232.15test_vm_snapshots.py
test_01_create_vm_snapshotsSuccess161.62test_vm_snapshots.py
test_deploy_vm_multipleSuccess282.86test_vm_life_cycle.py
test_deploy_vmSuccess0.03test_vm_life_cycle.py
test_advZoneVirtualRouterSuccess0.02test_vm_life_cycle.py
test_10_attachAndDetach_isoSuccess26.91test_vm_life_cycle.py
test_09_expunge_vmSuccess125.19test_vm_life_cycle.py
test_08_migrate_vmSuccess111.34test_vm_life_cycle.py
test_07_restore_vmSuccess0.10test_vm_life_cycle.py
test_06_destroy_vmSuccess10.15test_vm_life_cycle.py
test_03_reboot_vmSuccess5.15test_vm_life_cycle.py
test_02_start_vmSuccess20.22test_vm_life_cycle.py
test_01_stop_vmSuccess10.15test_vm_life_cycle.py
test_CreateTemplateWithDuplicateNameSuccess367.58test_templates.py
test_08_list_system_templatesSuccess0.04test_templates.py
test_07_list_public_templatesSuccess0.04test_templates.py
test_05_template_permissionsSuccess0.05test_templates.py
test_04_extract_templateSuccess20.32test_templates.py
test_03_delete_templateSuccess5.13test_templates.py
test_02_edit_templateSuccess90.17test_templates.py
test_01_create_templateSuccess171.13test_templates.py
test_10_destroy_cpvmSuccess236.84test_ssvm.py
test_09_destroy_ssvmSuccess243.72test_ssvm.py
test_08_reboot_cpvmSuccess156.70test_ssvm.py
test_07_reboot_ssvmSuccess158.55test_ssvm.py
test_06_stop_cpvmSuccess207.06test_ssvm.py
test_05_stop_ssvmSuccess203.92test_ssvm.py
test_04_cpvm_internalsSuccess1.21test_ssvm.py
test_03_ssvm_internalsSuccess3.42test_ssvm.py
test_02_list_cpvm_vmSuccess0.12test_ssvm.py
test_01_list_sec_storage_vmSuccess0.12test_ssvm.py
test_02_list_snapshots_with_removed_data_storeSuccess233.36test_snapshots.py
test_01_snapshot_root_diskSuccess31.27test_snapshots.py
test_04_change_offering_smallSuccess92.17test_service_offerings.py
test_03_delete_service_offeringSuccess0.05test_service_offerings.py
test_02_edit_service_offeringSuccess0.08test_service_offerings.py
test_01_create_service_offeringSuccess0.10test_service_offerings.py
test_02_sys_template_readySuccess0.17test_secondary_storage.py
test_01_sys_vm_startSuccess0.19test_secondary_storage.py
test_09_reboot_routerSuccess176.12test_routers.py
test_08_start_routerSuccess156.12test_routers.py
test_07_stop_routerSuccess20.21test_routers.py
test_06_router_advancedSuccess0.06test_routers.py
test_05_router_basicSuccess0.04test_routers.py
test_04_restart_network_wo_cleanupSuccess5.68test_routers.py
test_03_restart_network_cleanupSuccess166.16test_routers.py
test_02_router_internal_advSuccess1.03test_routers.py
test_01_router_internal_basicSuccess0.59test_routers.py
test_router_dns_guestipquerySuccess76.78test_router_dns.py
test_router_dns_externalipquerySuccess0.07test_router_dns.py
test_router_dhcphostsSuccess199.18test_router_dhcphosts.py
test_router_dhcp_optsSuccess21.59test_router_dhcphosts.py
test_01_updatevolumedetailSuccess0.09test_resource_detail.py
test_01_reset_vm_on_rebootSuccess75.64test_reset_vm_on_reboot.py
test_createRegionSuccess0.04test_regions.py
test_create_pvlan_networkSuccess5.21test_pvlan.py
test_dedicatePublicIpRangeSuccess0.47test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanupSuccess1113.77test_privategw_acl.py
test_02_vpc_privategw_static_routesSuccess818.26test_privategw_acl.py
test_01_vpc_privategw_aclSuccess207.89test_privategw_acl.py
test_03_migration_options_storage_tagsSuccess36.90test_primary_storage.py
test_02_edit_primary_storage_tagsSuccess0.10test_primary_storage.py
test_01_primary_storage_nfsSuccess38.76test_primary_storage.py
test_01_deploy_vms_storage_tagsSuccess46.86test_primary_storage.py
test_createPortablePublicIPRangeSuccess15.24test_portable_publicip.py
test_createPortablePublicIPAcquireSuccess15.54test_portable_publicip.py
test_isolate_network_password_serverSuccess92.27test_password_server.py
test_UpdateStorageOverProvisioningFactorSuccess0.13test_over_provisioning.py
test_oobm_zchange_passwordSuccess30.74test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipSuccess16.41test_outofbandmanagement.py
test_oobm_issue_power_statusSuccess10.36test_outofbandmanagement.py
test_oobm_issue_power_softSuccess15.35test_outofbandmanagement.py
test_oobm_issue_power_resetSuccess15.38test_outofbandmanagement.py
test_oobm_issue_power_onSuccess15.49test_outofbandmanagement.py
test_oobm_issue_power_offSuccess15.30test_outofbandmanagement.py
test_oobm_issue_power_cycleSuccess15.38test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesSuccess82.58test_outofbandmanagement.py
test_oobm_enable_feature_validSuccess5.18test_outofbandmanagement.py
test_oobm_enable_feature_invalidSuccess0.11test_outofbandmanagement.py
test_oobm_disable_feature_validSuccess0.17test_outofbandmanagement.py
test_oobm_disable_feature_invalidSuccess0.10test_outofbandmanagement.py
test_oobm_configure_invalid_driverSuccess0.08test_outofbandmanagement.py
test_oobm_configure_default_driverSuccess0.08test_outofbandmanagement.py
test_oobm_background_powerstate_syncSuccess23.41test_outofbandmanagement.py
test_extendPhysicalNetworkVlanSuccess15.36test_non_contigiousvlan.py
test_01_nicSuccess761.60test_nic.py
test_releaseIPSuccess257.87test_network.py
test_reboot_routerSuccess710.33test_network.py
test_public_ip_user_accountSuccess10.27test_network.py
test_public_ip_admin_accountSuccess40.28test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleSuccess76.76test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleSuccess61.71test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleSuccess124.93test_network.py
test_delete_accountSuccess343.33test_network.py
test_02_port_fwd_on_non_src_natSuccess55.70test_network.py
test_01_port_fwd_on_src_natSuccess111.79test_network.py
test_nested_virtualization_vmwareSuccess413.93test_nested_virtualization.py
test_nic_secondaryip_add_removeSuccess257.93test_multipleips_per_nic.py
test_list_zones_metricsSuccess0.25test_metrics_api.py
test_list_volumes_metricsSuccess5.45test_metrics_api.py
test_list_vms_metricsSuccess242.23test_metrics_api.py
test_list_pstorage_metricsSuccess0.32test_metrics_api.py
test_list_infrastructure_metricsSuccess0.46test_metrics_api.py
test_list_hosts_metricsSuccess0.39test_metrics_api.py
test_list_clusters_metricsSuccess0.36test_metrics_api.py
login_test_saml_userSuccess19.23test_login.py
test_assign_and_removal_lbSuccess148.70test_loadbalance.py
test_02_create_lb_rule_non_natSuccess207.47test_loadbalance.py
test_01_create_lb_rule_src_natSuccess207.97test_loadbalance.py
test_03_list_snapshotsSuccess0.12test_list_ids_parameter.py
test_02_list_templatesSuccess0.04test_list_ids_parameter.py
test_01_list_volumesSuccess0.04test_list_ids_parameter.py
test_07_list_default_isoSuccess0.06test_iso.py
test_05_iso_permissionsSuccess0.06test_iso.py
test_04_extract_IsoSuccess5.13test_iso.py
test_03_delete_isoSuccess95.23test_iso.py
test_02_edit_isoSuccess0.08test_iso.py
test_01_create_isoSuccess20.98test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesSuccess561.10test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesSuccess424.53test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Success924.17test_internal_lb.py
test_dedicateGuestVlanRangeSuccess10.31test_guest_vlan_range.py
test_UpdateConfigParamWithScopeSuccess0.12test_global_settings.py
test_rolepermission_lifecycle_updateSuccess6.24test_dynamicroles.py
test_rolepermission_lifecycle_listSuccess6.02test_dynamicroles.py
test_rolepermission_lifecycle_deleteSuccess5.88test_dynamicroles.py
test_rolepermission_lifecycle_createSuccess5.92test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updatesSuccess6.18test_dynamicroles.py
test_role_lifecycle_update_role_inuseSuccess5.99test_dynamicroles.py
test_role_lifecycle_updateSuccess11.01test_dynamicroles.py
test_role_lifecycle_listSuccess5.98test_dynamicroles.py
test_role_lifecycle_deleteSuccess10.98test_dynamicroles.py
test_role_lifecycle_createSuccess5.93test_dynamicroles.py
test_role_inuse_deletionSuccess5.93test_dynamicroles.py
test_role_account_acls_multiple_mgmt_serversSuccess8.58test_dynamicroles.py
test_role_account_aclsSuccess8.50test_dynamicroles.py
test_default_role_deletionSuccess6.02test_dynamicroles.py
test_04_create_fat_type_disk_offeringSuccess0.08test_disk_offerings.py
test_03_delete_disk_offeringSuccess0.04test_disk_offerings.py
test_02_edit_disk_offeringSuccess0.06test_disk_offerings.py
test_02_create_sparse_type_disk_offeringSuccess0.11test_disk_offerings.py
test_01_create_disk_offeringSuccess0.15test_disk_offerings.py
test_deployvm_userdispersingSuccess65.91test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentratedSuccess111.19test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfitSuccess387.93test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_postSuccess35.55test_deploy_vm_with_userdata.py
test_deployvm_userdataSuccess181.55test_deploy_vm_with_userdata.py
test_deploy_vm_from_isoSuccess252.85test_deploy_vm_iso.py
test_3d_gpu_supportSuccess480.34test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroupSuccess317.76test_affinity_groups.py
test_08_resize_volumeSkipped10.15test_volumes.py
test_07_resize_failSkipped15.29test_volumes.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.03test_ssvm.py
test_01_scale_vmSkipped66.33test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_06_copy_isoSkipped0.00test_iso.py
test_06_verify_guest_lspci_againSkipped0.00test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciSkipped0.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskSkipped0.00test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtSkipped0.00test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vmSkipped1.15test_deploy_vgpu_enabled_vm.py

@sureshanaparti

sureshanaparti commented May 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Above test failures are not related to this PR.

@cloudmonger

cloudmonger commented Jun 15, 2017

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 843
Hypervisor xenserver
NetworkType Advanced
Passed=108
Failed=5
Skipped=12

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_volumes.py

  • test_06_download_detached_volume Failed

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 31 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 31 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 31 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 31 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@yadvr

yadvr commented Aug 19, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 19, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Aug 19, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-965

@yadvr

yadvr commented Aug 19, 2017

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-55u3

@blueorangutan

blueorangutan commented Aug 19, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Aug 20, 2017

Copy link
Copy Markdown

Trillian test result (tid-1389)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2092-t1389-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 51 look OK, 6 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure141.53test_vpc_vpn.py
test_01_create_volumeFailure189.80test_volumes.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseFailure476.17test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueFailure451.91test_routers_network_ops.py
test_04_rvpc_privategw_static_routesFailure874.62test_privategw_acl.py
test_CreateTemplateWithDuplicateNameError5.12test_templates.py
test_01_create_templateError5.13test_templates.py
ContextSuite context=TestTemplates>:setupError248.81test_templates.py
ContextSuite context=TestListIdsParams>:setupError0.00test_list_ids_parameter.py
test_08_resize_volumeSkipped5.12test_volumes.py
test_07_resize_failSkipped10.28test_volumes.py
test_09_copy_delete_templateSkipped0.01test_templates.py
test_static_role_account_aclsSkipped0.02test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.02test_ssvm.py
test_01_scale_vmSkipped66.40test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_06_copy_isoSkipped0.00test_iso.py
test_06_verify_guest_lspci_againSkipped0.00test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciSkipped0.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskSkipped0.00test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtSkipped0.00test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vmSkipped1.19test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Aug 31, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 31, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Aug 31, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1061

@yadvr

yadvr commented Aug 31, 2017

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-55u3

@blueorangutan

blueorangutan commented Aug 31, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Sep 1, 2017

Copy link
Copy Markdown

Trillian test result (tid-1472)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2092-t1472-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 57 look OK, 5 have error(s)

TestResultTime (s)Test File
test_01_vpc_remote_access_vpnFailure136.60test_vpc_vpn.py
test_01_create_volumeFailure190.00test_volumes.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseFailure495.02test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueFailure445.76test_routers_network_ops.py
test_04_rvpc_privategw_static_routesFailure855.63test_privategw_acl.py
test_05_iso_permissionsFailure0.05test_iso.py
test_02_edit_isoFailure0.05test_iso.py
test_08_resize_volumeSkipped10.14test_volumes.py
test_07_resize_failSkipped10.26test_volumes.py
test_09_copy_delete_templateSkipped0.02test_templates.py
test_06_copy_templateSkipped0.00test_templates.py
test_static_role_account_aclsSkipped0.03test_staticroles.py
test_11_ss_nfs_version_on_ssvmSkipped0.03test_ssvm.py
test_01_scale_vmSkipped66.46test_scale_vm.py
test_01_primary_storage_iscsiSkipped0.04test_primary_storage.py
test_vm_nic_adapter_vmxnet3Skipped0.00test_nic_adapter_type.py
test_06_copy_isoSkipped0.00test_iso.py
test_list_ha_for_host_validSkipped0.03test_hostha_simulator.py
test_list_ha_for_host_invalidSkipped0.03test_hostha_simulator.py
test_list_ha_for_hostSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_without_setting_providerSkipped0.03test_hostha_simulator.py
test_hostha_enable_feature_validSkipped0.03test_hostha_simulator.py
test_hostha_disable_feature_validSkipped0.03test_hostha_simulator.py
test_hostha_configure_invalid_providerSkipped0.04test_hostha_simulator.py
test_hostha_configure_default_driverSkipped0.04test_hostha_simulator.py
test_ha_verify_fsm_recoveringSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_fencedSkipped0.04test_hostha_simulator.py
test_ha_verify_fsm_degradedSkipped0.03test_hostha_simulator.py
test_ha_verify_fsm_availableSkipped0.03test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownershipSkipped0.03test_hostha_simulator.py
test_ha_list_providersSkipped0.03test_hostha_simulator.py
test_ha_enable_feature_invalidSkipped0.03test_hostha_simulator.py
test_ha_disable_feature_invalidSkipped0.02test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzonesSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_validSkipped0.03test_hostha_simulator.py
test_configure_ha_provider_invalidSkipped0.04test_hostha_simulator.py
test_remove_ha_provider_not_possibleSkipped0.04test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenanceSkipped0.05test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconectedSkipped0.05test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabledSkipped0.06test_hostha_kvm.py
test_hostha_configure_default_driverSkipped0.06test_hostha_kvm.py
test_ha_kvm_host_recoveringSkipped0.06test_hostha_kvm.py
test_ha_kvm_host_fencingSkipped0.07test_hostha_kvm.py
test_ha_kvm_host_degradedSkipped0.05test_hostha_kvm.py
test_disable_oobm_ha_state_ineligibleSkipped0.08test_hostha_kvm.py
test_06_verify_guest_lspci_againSkipped0.00test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciSkipped0.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskSkipped0.00test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartSkipped0.00test_deploy_virtio_scsi_vm.py
test_01_verify_libvirtSkipped0.00test_deploy_virtio_scsi_vm.py
test_deploy_vgpu_enabled_vmSkipped1.36test_deploy_vgpu_enabled_vm.py

@yadvr

yadvr commented Sep 1, 2017

Copy link
Copy Markdown
Member

LGTM, test failures not related to this PR. Additional review requested @niteshsarda@nitin-maharana@karuturi@sureshanaparti and others

@resmo

resmo commented Nov 6, 2017

Copy link
Copy Markdown
Member

code LGTM, IMHO hard to have a test case for it.

@sateesh-chodapuneedi

sateesh-chodapuneedi commented Nov 7, 2017

Copy link
Copy Markdown
Member

Merging this based on 2 LGTMs and test results confirmation from @rhtyd and @resmo. Thanks.

@sateesh-chodapuneedi
sateesh-chodapuneedi merged commit c5692ce into apache:masterNov 7, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvryadvryadvr left review comments

Assignees

No one assigned

Labels

component:vmwaretype:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sureshanaparti@yadvr@blueorangutan@cloudmonger@resmo@sateesh-chodapuneedi@kiwiflyer