Skip to content

[CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID - #2238

Merged
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/caching_and_statistics
Nov 2, 2017
Merged

[CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID#2238
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/caching_and_statistics

Conversation

@fmaximus

@fmaximusfmaximus commented Aug 16, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
  • VSP Id caching
  • VSP request statistics
  • VSP 5.0 support

@fmaximus
fmaximusforce-pushed the feature/caching_and_statistics branch from 5c5d8b4 to ca57305CompareAugust 16, 2017 12:26
borisstoyanov
borisstoyanov reviewed Aug 17, 2017
View reviewed changes

@borisstoyanovborisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fmaximus, can you please add a community jira for these improvements

@fmaximusfmaximus changed the title Performance improvement: caching of NuageVsp ID[CLOUDSTACK-10053] Performance improvement: caching of NuageVsp IDAug 21, 2017
@fmaximus

fmaximus commented Aug 21, 2017

Copy link
Copy Markdown
ContributorAuthor

CLOUDSTACK-10053

@yadvr

yadvr commented Sep 14, 2017

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Sep 14, 2017

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Sep 14, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1083

@yadvr

yadvr commented Sep 16, 2017

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Sep 16, 2017

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sgoeminn
sgoeminnforce-pushed the feature/caching_and_statistics branch from ca57305 to 7f911baCompareOctober 11, 2017 12:36
@sgoeminn
sgoeminnforce-pushed the feature/caching_and_statistics branch from 7f911ba to a659409CompareOctober 23, 2017 14:57
smeetsr
smeetsr approved these changes Oct 23, 2017
View reviewed changes

@smeetsrsmeetsr left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed all regressions for this PR without failures. Approving.

@sgoeminn

sgoeminn commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

CI failure seems not to be related to this PR (known issue).

Sigert Goeminne@fmaximus@smeetsr
CLOUDSTACK-10053: Performance improvement: caching of NuageVsp ID
0871ff9
* VSP ID Caching
* VSP call Statistics
* 5.0 Support
Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net>
Co-Authored-By: Raf Smeets <raf.smeets@nuagenetworks.net>
@fmaximus
fmaximusforce-pushed the feature/caching_and_statistics branch from a659409 to 0871ff9CompareOctober 31, 2017 16:06
@fmaximusfmaximus added this to the 4.11 milestone Oct 31, 2017
krissterckx
krissterckx approved these changes Oct 31, 2017
View reviewed changes

@krissterckxkrissterckx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmaximus
fmaximus merged commit 2139dbe into apache:masterNov 2, 2017
@yadvr

yadvr commented Nov 2, 2017

Copy link
Copy Markdown
Member

@fmaximus looks like Trillian job failed to complete regression testing. Kindly don't merge PRs that don't have regression testing from at least one of the hypervisors. Travis tests while useful aren't as comprehensive as only those tests run that don't require real hardware, several of the networking, storage tests are simply skipped. I suppose this works with Nuage, I'll kick regression smoke tests on #2225 soon.

@fmaximus

fmaximus commented Nov 8, 2017

Copy link
Copy Markdown
ContributorAuthor

@rhtyd We ran regression tests on our infrastructure (centos7 mgmt + 2 computes: kvm-centos7-nuage)

borisstoyanov
borisstoyanov reviewed Nov 8, 2017
View reviewed changes

@borisstoyanovborisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmaximus we don't have nuage images in trillian, what we can do though is to run regular kvm hosts on centos7, would that be OK?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisstoyanovborisstoyanovborisstoyanov left review comments
+2 more reviewers
@krissterckxkrissterckxkrissterckx approved these changes
@smeetsrsmeetsrsmeetsr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:plugintype:enhancement

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@fmaximus@yadvr@blueorangutan@sgoeminn@krissterckx@borisstoyanov@smeetsr