CLOUDSTACK-10102: New network type (L2) by nvazquez · Pull Request #2281 · apache/cloudstack

nvazquez · 2017-10-03T03:03:23Z

JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10102
Feature Specification: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74680920

Introduction

This feature allows CloudStack administrators to create layer 2 networks on CloudStack. As these networks are purely layer 2, they don't require IP addresses or Virtual Router, only VLAN is necessary (provided by administrator or assigned by CloudStack). Also, network services should be handled externally, e.g. DNS, DHCP, as they are not provided by L2 networks.
As a consequence, a new Guest Network type is created within CloudStack: L2

Description

Network offerings and networks support new guest type: L2.
L2 Network offering creation allows administrator to select Specify VLAN or let CloudStack assign it dynamically.
L2 Network creation allows administrator to specify VLAN tag (if network offerings allows it) or simply create network.
VM deployments on L2 networks:
- VMs should not IP addresses or any network service
- No Virtual Router deployed on network
- If Specify VLAN = true for network offering, network gets implemented using a dynamically assigned VLAN

UI changes

A new button is added on Networks tab, available for admins, to allow L2 networks creation

yadvr · 2017-10-06T14:24:06Z

Did not test it, but good work @nvazquez
@blueorangutan package

blueorangutan · 2017-10-06T14:24:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-10-06T14:56:51Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1135

borisstoyanov · 2017-10-10T09:18:26Z

@blueorangutan test

blueorangutan · 2017-10-10T09:19:31Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-10-10T17:36:05Z

Trillian test result (tid-1573)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29725 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1573-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 41 look OK, 21 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn	`Failure`	15.40	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	5.22	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	`Failure`	10.65	test_vpc_vpn.py
test_04_rvpc_privategw_static_routes	`Failure`	10.95	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	10.92	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	10.94	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	11.02	test_privategw_acl.py
test_02_port_fwd_on_non_src_nat	`Failure`	737.91	test_network.py
test_02_VPC_default_routes	`Error`	10.96	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Error`	10.94	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	`Error`	10.96	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	10.99	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	5.93	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	10.96	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	15.97	test_vpc_redundant.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	6.03	test_vm_snapshots.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestTemplates>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	6.24	test_service_offerings.py
test_03_RVR_Network_check_router_state	`Error`	0.28	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	5.44	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	0.27	test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	5.46	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	0.27	test_routers_network_ops.py
test_02_routervm_iptables_policies	`Error`	5.32	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	5.28	test_routers_iptables_default_policy.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_isolate_network_password_server	`Error`	0.09	test_password_server.py
test_releaseIP	`Error`	11.08	test_network.py
test_reboot_router	`Error`	242.14	test_network.py
test_delete_account	`Error`	86.57	test_network.py
test_02_port_fwd_on_non_src_nat	`Error`	743.02	test_network.py
test_01_port_fwd_on_src_nat	`Error`	0.09	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	17.09	test_network.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	242.74	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	147.06	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	223.14	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	142.86	test_internal_lb.py
test_06_verify_guest_lspci_again	`Error`	721.06	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	`Error`	715.51	test_deploy_virtio_scsi_vm.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
ContextSuite context=TestCreateTemplate>:setup	Skipped	0.00	test_templates.py
ContextSuite context=TestCopyDeleteTemplate>:setup	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.10	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.03	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.03	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.03	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.03	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.03	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.03	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.03	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.03	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

yadvr

Overall nice changes, I've not tested it though. Does it make sense to add some marvin test?

yadvr · 2017-10-12T10:16:46Z

- nicSearch.and().op("ip4Address", nicSearch.entity().getIPv4Address(), SearchCriteria.Op.NNULL);
- nicSearch.or("ip6Address", nicSearch.entity().getIPv6Address(), SearchCriteria.Op.NNULL);
- nicSearch.cp();
+ if (! network.getGuestType().equals(Network.GuestType.L2)) {


Space after ! may be removed

yadvr · 2017-10-12T10:17:24Z

 addr.setState(assign ? IpAddress.State.Allocated : IpAddress.State.Allocating);

- if (vlanUse != VlanType.DirectAttached) {
+ if (assign && vlanUse != VlanType.DirectAttached) {


Could this cause a backward compatibility issue?

yadvr · 2017-10-12T10:17:37Z

 }
 }

+


Remove extra newline?

yadvr · 2017-10-12T10:18:34Z

 $useVpc.css('display', 'inline-block');
+ $supportedServices.css('display', 'inline-block');
+ }
+ else if ($guestTypeField.val() == 'L2') {


Put } else if ... on same line as line 2413.

yadvr · 2017-10-12T10:18:58Z

+ } else if ($(this).val() == "Isolated") {
 $form.find('.form-item[rel=specifyVlan]').find('input[type=checkbox]').removeAttr("disabled"); //make it editable
 $form.find('.form-item[rel=isPersistent]').find('input[type=checkbox]').removeAttr("disabled");



Remove extra new line

yadvr · 2017-10-12T10:19:40Z



- } else { //$(this).val() == "Isolated"
+ } else if ($(this).val() == "Isolated") {


Can both the cases for L2 and Isolated be collapsed, as both are using same code?

yadvr · 2017-10-12T10:19:54Z

@@ -3315,6 +3328,13 @@
 delete inputData.isPersistent; //if Persistent checkbox is unchecked, do not pass isPersistent parameter to API call since we need to keep API call's size as small as possible (p.s. isPersistent is defaulted as false at server-side)
 }
 }


Put } else if.. on same line.

borisstoyanov · 2017-10-18T07:15:13Z

@blueorangutan package

blueorangutan · 2017-10-18T07:15:29Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-10-18T07:40:12Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1170

borisstoyanov · 2017-10-18T07:42:26Z

@blueorangutan test

blueorangutan · 2017-10-18T07:42:30Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-10-18T12:37:34Z

Trillian test result (tid-1595)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 17701 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1595-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 38 look OK, 25 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn	`Failure`	10.38	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	5.17	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	`Failure`	10.41	test_vpc_vpn.py
test_01_sys_vm_start	`Failure`	0.07	test_secondary_storage.py
test_04_rvpc_privategw_static_routes	`Failure`	5.95	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	10.93	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	5.92	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	5.93	test_privategw_acl.py
test_02_VPC_default_routes	`Error`	11.15	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Error`	10.93	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	`Error`	11.07	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	10.99	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	10.97	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	10.96	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	16.04	test_vpc_redundant.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	6.01	test_vm_snapshots.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestTemplates>:setup	`Error`	47.28	test_templates.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	6.18	test_service_offerings.py
test_03_RVR_Network_check_router_state	`Error`	0.51	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	5.38	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	0.54	test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	5.43	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	0.43	test_routers_network_ops.py
test_02_routervm_iptables_policies	`Error`	5.27	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	15.33	test_routers_iptables_default_policy.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_01_primary_storage_nfs	`Error`	0.16	test_primary_storage.py
test_01_add_primary_storage_disabled_host	`Error`	42.00	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.28	test_primary_storage.py
test_isolate_network_password_server	`Error`	0.08	test_password_server.py
test_releaseIP	`Error`	6.07	test_network.py
test_reboot_router	`Error`	166.53	test_network.py
test_public_ip_user_account	`Error`	0.05	test_network.py
test_public_ip_admin_account	`Error`	0.06	test_network.py
test_delete_account	`Error`	41.30	test_network.py
test_02_port_fwd_on_non_src_nat	`Error`	0.05	test_network.py
test_01_port_fwd_on_src_nat	`Error`	0.08	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	12.14	test_network.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	126.82	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	91.78	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	132.70	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	92.38	test_internal_lb.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	20.92	test_hostha_kvm.py
test_05_add_annotation_for_invvalid_entityType	`Error`	0.05	test_host_annotations.py
test_06_verify_guest_lspci_again	`Error`	715.55	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	`Error`	715.48	test_deploy_virtio_scsi_vm.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
ContextSuite context=TestCreateTemplate>:setup	Skipped	0.00	test_templates.py
ContextSuite context=TestCopyDeleteTemplate>:setup	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.09	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.03	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.03	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.03	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.03	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.04	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.07	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.03	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.02	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.02	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.02	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.02	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.03	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_hostha_kvm_host_recovering	Skipped	56.24	test_hostha_kvm.py
test_hostha_kvm_host_fencing	Skipped	36.11	test_hostha_kvm.py
test_hostha_kvm_host_degraded	Skipped	66.36	test_hostha_kvm.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

borisstoyanov · 2017-10-19T09:50:58Z

@DaanHoogland I see this error here when listing hosts:

2017-10-19 09:45:50,498 ERROR [c.c.a.ApiServer] (catalina-exec-8:ctx-6542176f ctx-66e777cb) (logid:cc54a5b2) unhandled exception executing api command: [Ljava.lang.String;@5aa032ab
com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@49891c22: SELECT host_view.id, host_view.uuid, host_view.name, host_view.status, host_view.type, host_view.private_ip_address, host_view.disconnected, host_view.version, host_view.hypervisor_type, host_view.hypervisor_version, host_view.capabilities, host_view.last_ping, host_view.created, host_view.removed, host_view.oobm_enabled, host_view.oobm_power_state, host_view.ha_enabled, host_view.ha_state, host_view.ha_provider, host_view.resource_state, host_view.mgmt_server_id, host_view.cpu_sockets, host_view.cpus, host_view.speed, host_view.ram, host_view.cluster_id, host_view.cluster_uuid, host_view.cluster_name, host_view.cluster_type, host_view.data_center_id, host_view.data_center_uuid, host_view.data_center_name, host_view.pod_id, host_view.pod_uuid, host_view.pod_name, host_view.guest_os_category_id, host_view.guest_os_category_uuid, host_view.guest_os_category_name, host_view.tag, host_view.memory_used_capacity, host_view.memory_reserved_capacity, host_view.cpu_used_capacity, host_view.cpu_reserved_capacity, host_view.job_id, host_view.job_uuid, host_view.job_status, host_view.annotation, host_view.last_annotated, host_view.username FROM host_view WHERE host_view.id IN (1,5)
at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:428)
at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:364)
at com.cloud.api.query.dao.HostJoinDaoImpl.searchByIds(HostJoinDaoImpl.java:447)
at sun.reflect.GeneratedMethodAccessor221.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:168)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:213)
at com.sun.proxy.$Proxy298.searchByIds(Unknown Source)
at com.cloud.api.query.QueryManagerImpl.searchForServersInternal(QueryManagerImpl.java:1683)
at com.cloud.api.query.QueryManagerImpl.searchForServers(QueryManagerImpl.java:1562)
at org.apache.cloudstack.api.command.admin.host.ListHostsCmd.getHostResponses(ListHostsCmd.java:208)
at org.apache.cloudstack.api.command.admin.host.ListHostsCmd.execute(ListHostsCmd.java:233)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:728)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:552)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:297)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:110)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:506)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:962)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:445)
at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1087)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1770)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1729)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown column 'host_view.annotation' in 'field list'
at sun.reflect.GeneratedConstructorAccessor138.newInstance(Unknown Source)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
... 64 more

Does this looks like a db upgrade failure in annotations PR to you?

borisstoyanov · 2017-10-19T11:49:34Z

@nvazquez can you please rebase and push

nvazquez · 2017-10-19T12:57:17Z

@borisstoyanov sure, done.

borisstoyanov · 2017-10-19T12:59:14Z

Thanks @nvazquez, @blueorangutan package

blueorangutan · 2017-10-19T12:59:29Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-10-19T13:25:22Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1174

borisstoyanov · 2017-10-19T13:27:15Z

@blueorangutan test

blueorangutan · 2017-10-19T13:27:29Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-10-19T19:03:54Z

Trillian test result (tid-1598)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 20180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1598-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 41 look OK, 22 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn	`Failure`	10.30	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	5.17	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	`Failure`	5.31	test_vpc_vpn.py
test_04_rvpc_privategw_static_routes	`Failure`	11.03	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	10.91	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	10.92	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	10.91	test_privategw_acl.py
test_02_port_fwd_on_non_src_nat	`Failure`	730.81	test_network.py
test_02_VPC_default_routes	`Error`	5.87	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Error`	10.92	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	`Error`	10.93	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	10.92	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	10.93	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	10.94	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	10.93	test_vpc_redundant.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	5.97	test_vm_snapshots.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestTemplates>:setup	`Error`	47.21	test_templates.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	6.15	test_service_offerings.py
test_03_RVR_Network_check_router_state	`Error`	0.25	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	5.35	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	0.24	test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	5.37	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	0.25	test_routers_network_ops.py
test_02_routervm_iptables_policies	`Error`	5.26	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	10.33	test_routers_iptables_default_policy.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_isolate_network_password_server	`Error`	0.07	test_password_server.py
test_releaseIP	`Error`	5.98	test_network.py
test_reboot_router	`Error`	226.82	test_network.py
test_delete_account	`Error`	56.39	test_network.py
test_02_port_fwd_on_non_src_nat	`Error`	735.94	test_network.py
test_01_port_fwd_on_src_nat	`Error`	0.08	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	11.97	test_network.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	156.91	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	116.77	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Error`	162.79	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	107.26	test_internal_lb.py
test_05_add_annotation_for_invalid_entityType	`Error`	0.06	test_host_annotations.py
test_06_verify_guest_lspci_again	`Error`	715.45	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	`Error`	715.75	test_deploy_virtio_scsi_vm.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
ContextSuite context=TestCreateTemplate>:setup	Skipped	0.00	test_templates.py
ContextSuite context=TestCopyDeleteTemplate>:setup	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.08	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.01	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.01	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.01	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.02	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.01	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.01	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.01	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.01	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.02	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.03	test_deploy_vgpu_enabled_vm.py

borisstoyanov · 2017-10-20T06:51:36Z

@nvazquez can you please see the failing tests

nvazquez · 2017-10-20T11:14:57Z

@borisstoyanov sure, I'll work on fixing failures

nvazquez · 2017-12-12T11:15:19Z

@rhtyd @borisstoyanov master rebased, Jenkins and Travis are green now

yadvr · 2017-12-12T12:48:53Z

Additional review from others request.
@blueorangutan package

blueorangutan · 2017-12-12T12:49:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-12-12T13:14:05Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1367

yadvr · 2017-12-17T21:45:02Z

@blueorangutan package

blueorangutan · 2017-12-17T21:45:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-12-17T23:36:22Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1394

nvazquez · 2017-12-18T21:20:57Z

@blueorangutan test

blueorangutan · 2017-12-18T21:21:33Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-12-19T10:28:06Z

Trillian test result (tid-1821)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29591 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1821-kvm-centos7.zip
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	`Failure`	51.18	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	287.67	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	106.75	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	317.73	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	`Error`	5.15	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.15	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.16	test_templates.py
test_01_vpc_remote_access_vpn	`Failure`	45.58	test_vpc_vpn.py

yadvr · 2017-12-19T10:32:07Z

@nvazquez Tests LGTM, additional review requested following which this can be merged.

nvazquez · 2017-12-19T11:19:01Z

Thanks @rhtyd
@DaanHoogland @rafaelweingartner @marcaurele can you please review?

rafaelweingartner

@nvazquez I only have one or two remarks here.
Everything else seems to be ok

rafaelweingartner · 2017-12-19T11:22:28Z

- nicSearch.and().op("ip4Address", nicSearch.entity().getIPv4Address(), SearchCriteria.Op.NNULL);
- nicSearch.or("ip6Address", nicSearch.entity().getIPv6Address(), SearchCriteria.Op.NNULL);
- nicSearch.cp();
+ if (!network.getGuestType().equals(Network.GuestType.L2)) {


Can the method getGuestType return Null?
If not, the code is ok. Otherwise, it might be more interesting to do Network.GuestType.L2.equals(network.getGuestType())
Or even using ==, if it is an enum type, it is ok to use ==

rafaelweingartner · 2017-12-19T11:24:24Z

 @Override
 public Set<Long> getAvailableIps(Network network, String requestedIp) {
+ if (network.getCidr() == null) {
+ return null;


Instead of null, what about an empty set here?

nvazquez · 2017-12-19T13:41:27Z

Thanks @rafaelweingartner, I pushed a commit with suggested improvements

nvazquez · 2017-12-19T17:01:45Z

@blueorangutan package

blueorangutan · 2017-12-19T17:02:32Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-12-19T17:27:42Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1428

nvazquez · 2017-12-19T17:29:29Z

@blueorangutan test

blueorangutan · 2017-12-19T17:30:33Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-12-20T01:25:44Z

Trillian test result (tid-1832)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28508 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1832-kvm-centos7.zip
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	`Failure`	57.00	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	208.74	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	153.34	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	294.56	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	`Error`	5.29	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.22	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.23	test_templates.py
test_06_download_detached_volume	`Failure`	147.53	test_volumes.py
test_01_vpc_remote_access_vpn	`Error`	50.81	test_vpc_vpn.py

yadvr · 2017-12-20T11:37:04Z

Tests LGTM, others are known failures. This is ready for merging.

nvazquez added type:enhancement component:networking labels Oct 3, 2017

nvazquez force-pushed the roadmap-newl2networktype branch from 3a9fb97 to df47971Compare October 9, 2017 12:22

yadvr reviewed Oct 12, 2017
View reviewed changes

nvazquez force-pushed the roadmap-newl2networktype branch from df47971 to 78f1ecaCompare October 19, 2017 12:56

nvazquez force-pushed the roadmap-newl2networktype branch from 78f1eca to 9bad6fcCompare October 26, 2017 20:08

nvazquez force-pushed the roadmap-newl2networktype branch from 9bad6fc to 3e4a3eaCompare November 8, 2017 17:32

nvazquezand others added 4 commits December 11, 2017 19:21

CLOUDSTACK-10102: New network type (L2)
1627aaa

adding marvin tests for CRUD operations and vm-deployment in l2 netwoks
e39ea2c

CLOUDSTACK-10102: Fixes on L2 network deletion
1c0ccd8

Addressing comments per Nicolas' review
405ca44

nvazquez force-pushed the roadmap-newl2networktype branch from fa8778f to 405ca44Compare December 11, 2017 22:22

rafaelweingartner approved these changes Dec 19, 2017
View reviewed changes

CLOUDSTACK-10102: Improvements
40fda18

nvazquez force-pushed the roadmap-newl2networktype branch from 6748208 to 40fda18Compare December 19, 2017 13:44

yadvr merged commit 13c325a into apache:masterDec 20, 2017

nvazquez deleted the roadmap-newl2networktype branch April 6, 2020 14:53



		} else { //$(this).val() == "Isolated"
		} else if ($(this).val() == "Isolated") {

Uh oh!

Conversation

nvazquez commented Oct 3, 2017

Introduction

Description

UI changes

Uh oh!

yadvr commented Oct 6, 2017

Uh oh!

blueorangutan commented Oct 6, 2017

Uh oh!

blueorangutan commented Oct 6, 2017

Uh oh!

borisstoyanov commented Oct 10, 2017

Uh oh!

blueorangutan commented Oct 10, 2017

Uh oh!

blueorangutan commented Oct 10, 2017

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Oct 18, 2017

Uh oh!

blueorangutan commented Oct 18, 2017

Uh oh!

blueorangutan commented Oct 18, 2017

Uh oh!

borisstoyanov commented Oct 18, 2017

Uh oh!

blueorangutan commented Oct 18, 2017

Uh oh!

blueorangutan commented Oct 18, 2017

Uh oh!

borisstoyanov commented Oct 19, 2017

Uh oh!

borisstoyanov commented Oct 19, 2017

Uh oh!

nvazquez commented Oct 19, 2017

Uh oh!

borisstoyanov commented Oct 19, 2017

Uh oh!

blueorangutan commented Oct 19, 2017

Uh oh!

blueorangutan commented Oct 19, 2017

Uh oh!

borisstoyanov commented Oct 19, 2017

Uh oh!

blueorangutan commented Oct 19, 2017

Uh oh!

blueorangutan commented Oct 19, 2017

Uh oh!

borisstoyanov commented Oct 20, 2017

Uh oh!

nvazquez commented Oct 20, 2017

Uh oh!

nvazquez commented Dec 12, 2017

Uh oh!

yadvr commented Dec 12, 2017

Uh oh!

blueorangutan commented Dec 12, 2017

Uh oh!

blueorangutan commented Dec 12, 2017

Uh oh!

yadvr commented Dec 17, 2017

Uh oh!