CLOUDSTACK-10012: Jetty 9.4 by marcaurele · Pull Request #2329 · apache/cloudstack

marcaurele · 2017-11-16T08:18:30Z

Upgrading to jetty 9.4 along with:

new gzip handler
redirect / to the context path
add session timeout configuration
change for cloudian tests

marcaurele · 2017-11-16T08:22:32Z

superseed #2328 (Jetty 9.4 is Java8 compatible)
cc @rhtyd @wido

yadvr · 2017-11-16T09:13:51Z

 http.port=8080

+# Max inactivity time in minutes for the session
+session.timeout=10


@marcaurele Can we bump the default to 30 minutes? I suppose 10 minutes might be too low, or maybe we can hit the sweet spot at 20mins?

I agree that 10 minutes is very short. I would prefer 30

yadvr · 2017-11-16T10:56:38Z

@blueorangutan package

blueorangutan · 2017-11-16T10:57:20Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-16T11:14:21Z

Packaging result: ✖centos6 ✔centos7 ✖debian. JID-1263

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2017-11-16T11:49:39Z

@marcaurele I've fixed the cloudian unit test failures and the session timeout to 30 (mins).

yadvr · 2017-11-16T11:49:48Z

@blueorangutan package

blueorangutan · 2017-11-16T11:50:21Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2017-11-16T11:59:52Z

@marcaurele how do you start the jetty server with mvn, when I run mvn -pl :cloud-client-ui jetty:run -Dnoredist -Dsimulator -Djava.net.preferIPv4Stack=true it does not run the server for me.

blueorangutan · 2017-11-16T12:14:18Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1264

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2017-11-16T13:22:20Z

@marcaurele I found a workaround to use the old 9.2.x jetty-maven-plugin as the newer one did not work for me (and Travis). Please review the changes.
LGTM from my side.

yadvr · 2017-11-16T13:22:28Z

@blueorangutan package

blueorangutan · 2017-11-16T13:23:20Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-16T13:52:12Z

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1265

yadvr · 2017-11-16T17:37:34Z

@blueorangutan package

blueorangutan · 2017-11-16T17:38:21Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-16T18:13:25Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1268

yadvr · 2017-11-16T18:15:22Z

@blueorangutan test

blueorangutan · 2017-11-16T18:16:22Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-11-17T05:59:55Z

Trillian test result (tid-1658)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42208 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2329-t1658-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_nic.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 27 look OK, 36 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	`Failure`	45.84	test_vpc_vpn.py
test_02_VPC_default_routes	`Failure`	66.69	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	`Failure`	66.68	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	`Failure`	181.61	test_vpc_redundant.py
test_04_rvpc_privategw_static_routes	`Failure`	298.67	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	127.57	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	82.16	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	87.39	test_privategw_acl.py
test_01_create_iso	`Failure`	1516.14	test_iso.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	66.38	test_vm_snapshots.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestTemplates>:setup	`Error`	72.27	test_templates.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	71.63	test_service_offerings.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	96.15	test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	106.11	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	1642.05	test_routers_network_ops.py
test_02_routervm_iptables_policies	`Error`	55.60	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	66.11	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	91.46	test_routers_iptables_default_policy.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_04_rvpc_privategw_static_routes	`Error`	308.90	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	137.83	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Error`	92.37	test_privategw_acl.py
test_01_primary_storage_nfs	`Error`	0.21	test_primary_storage.py
test_01_add_primary_storage_disabled_host	`Error`	133.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.33	test_primary_storage.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	112.33	test_portforwardingrules.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_nic	`Error`	76.84	test_nic.py
test_network_acl	`Error`	106.47	test_network_acl.py
test_releaseIP	`Error`	56.44	test_network.py
test_reboot_router	`Error`	51.31	test_network.py
test_delete_account	`Error`	51.40	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	112.83	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	178.26	test_network.py
test_nic_secondaryip_add_remove	`Error`	51.30	test_multipleips_per_nic.py
test_list_vms_metrics	`Error`	5.41	test_metrics_api.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_04_create_iso_with_no_checksum	`Error`	65.71	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	65.65	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	70.74	test_iso.py
test_03_1_create_iso_with_checksum_md5_negative	`Error`	70.86	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	65.61	test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative	`Error`	70.75	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	65.58	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	70.71	test_iso.py
test_01_1_create_iso_with_checksum_sha1_negative	`Error`	70.88	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3036.96	test_iso.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_05_add_annotation_for_invalid_entityType	`Error`	0.10	test_host_annotations.py
test_deployvm_userdispersing	`Error`	30.40	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	35.51	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit	`Error`	100.99	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post	`Error`	20.55	test_deploy_vm_with_userdata.py
test_deployvm_userdata	`Error`	116.25	test_deploy_vm_with_userdata.py
test_00_deploy_vm_root_resize	`Error`	166.35	test_deploy_vm_root_resize.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	131.24	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	60.76	test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
ContextSuite context=TestCreateTemplate>:setup	Skipped	0.00	test_templates.py
ContextSuite context=TestCopyDeleteTemplate>:setup	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.12	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_03_nic_multiple_vmware	Skipped	1.13	test_nic.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_list_ha_for_host_valid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.04	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.03	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.07	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.07	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.08	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.07	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.07	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.07	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.02	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.03	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.07	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.08	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.07	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.07	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.07	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_hostha_kvm_host_recovering	Skipped	31.18	test_hostha_kvm.py
test_hostha_kvm_host_fencing	Skipped	36.24	test_hostha_kvm.py
test_hostha_kvm_host_degraded	Skipped	61.39	test_hostha_kvm.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

yadvr · 2017-11-17T08:39:09Z

@blueorangutan package

blueorangutan · 2017-11-17T08:39:21Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-17T09:03:23Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1270

yadvr · 2017-11-17T09:10:08Z

@blueorangutan test

blueorangutan · 2017-11-17T09:10:21Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>

marcaurele · 2017-11-17T11:11:39Z

I moved the plugin version to root pom properties.

marcaurele · 2017-11-17T11:20:39Z

LGTM

rafaelweingartner · 2017-11-17T11:27:09Z

 setKeystorePassword(properties.getProperty(KEYSTORE_PASSWORD));
 setWebAppLocation(properties.getProperty(WEBAPP_DIR));
 setAccessLogFile(properties.getProperty(ACCESS_LOG, "access.log"));
+ setSessionTimeout(Integer.valueOf(properties.getProperty(SESSION_TIMEOUT, "10")));


@marcaurele you have a default value in the property file, which is 30, and here it is 10 (at line 85). Moreover, what about using the value of variable sessionTimeout as the default values? The variable already starts with the default value anyways.

Thanks, I've synced default values to 30 now.

rafaelweingartner

LGTM from me here.

I only have a remark regarding the number of commits for such a small change. I understand that you have more than a person working here, but I believe the number of commits could be reduced.

yadvr · 2017-11-17T11:50:15Z

@rafaelweingartner I'll squash merge them (I dislike splitting PRs in 10s+ of commits too)

rafaelweingartner · 2017-11-17T11:51:47Z

@rhtyd thanks!

blueorangutan · 2017-11-17T17:52:00Z

Trillian test result (tid-1659)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31296 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2329-t1659-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 59 look OK, 4 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	`Failure`	65.95	test_vpc_vpn.py
test_04_rvpc_privategw_static_routes	`Failure`	258.56	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	183.02	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	178.07	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	61.67	test_privategw_acl.py
test_04_extract_Iso	`Failure`	5.09	test_iso.py
test_05_add_annotation_for_invalid_entityType	`Error`	0.09	test_host_annotations.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.03	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.09	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_03_nic_multiple_vmware	Skipped	1.07	test_nic.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.03	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.03	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.02	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.03	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.02	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.02	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.02	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.02	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

yadvr · 2017-11-17T17:57:08Z

Tests LGTM, merged. Thanks everyone.

andrijapanicsb · 2019-10-30T13:33:50Z

Resurrecting an old PR - did anyone actually tested the session duration being set correctly (to something else than 30min)?

It's not working in 4.11+ (whatever other value you set, the session is always set to 30min)
Tested by setting session.timeout=2 in the server.properties, restarting mgmt server.

@marcaurele @wido @rafaelweingartner /CC @rhtyd

marcaurele · 2019-10-31T05:57:30Z

@andrijapanicsb I'll have a look and come back here with the fix

marcaurele changed the title ~~Jetty 9.4~~CLOUDSTACK-10012: Jetty 9.4Nov 16, 2017

marcaurele added 4 commits November 16, 2017 09:28

Bump Jetty to 9.4
54a86e6

Use new jetty gzip handler
0f25cc0

Redirect / to context
8fb564c

Update wiremock but still not working
f60a843

marcaurele force-pushed the gzip branch from e3a87d3 to f60a843Compare November 16, 2017 08:28

Add session timeout configuration
51f9609

yadvr mentioned this pull request Nov 16, 2017
CLOUDSTACK-10012: Upgrade Jetty to 9.3.x #2328
Closed

yadvr reviewed Nov 16, 2017
View reviewed changes

server.properties.in: Change default timeout to 30 (mins)
d438049

cloudian: fix unit test failures
4c0f5ee
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

client: use older 9.2.x jetty-maven-plugin that works
d410024
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Moving jetty mvn plugin version in properties
0d4a391
Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>

rafaelweingartner reviewed Nov 17, 2017
View reviewed changes

Set default session timeout to 30mins
3d9d53a

rafaelweingartner approved these changes Nov 17, 2017
View reviewed changes

yadvr merged commit cd6288e into apache:masterNov 17, 2017

marcaurele mentioned this pull request Oct 31, 2019
client: fix for jetty session timeout #3658
Merged
5 tasks

Uh oh!

Conversation

marcaurele commented Nov 16, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcaurele commented Nov 16, 2017

Uh oh!

yadvrNov 16, 2017

Choose a reason for hiding this comment

Uh oh!

widoNov 16, 2017

Choose a reason for hiding this comment

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

yadvr commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 16, 2017

Uh oh!

blueorangutan commented Nov 17, 2017

Uh oh!

yadvr commented Nov 17, 2017

Uh oh!

blueorangutan commented Nov 17, 2017

Uh oh!

blueorangutan commented Nov 17, 2017

Uh oh!

yadvr commented Nov 17, 2017

Uh oh!

blueorangutan commented Nov 17, 2017

Uh oh!

marcaurele commented Nov 17, 2017

Uh oh!

marcaurele commented Nov 17, 2017

Uh oh!

rafaelweingartnerNov 17, 2017

Choose a reason for hiding this comment

Uh oh!

yadvrNov 17, 2017

Choose a reason for hiding this comment

Uh oh!

rafaelweingartner left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Nov 17, 2017

Uh oh!

rafaelweingartner commented Nov 17, 2017

Uh oh!

blueorangutan commented Nov 17, 2017

Uh oh!

yadvr commented Nov 17, 2017

Uh oh!

marcaurele commented Nov 16, 2017•
edited
Loading