CLOUDSTACK-10190:Duplicate public VLAN for two different admin accounts.

[niteshsarda]

ISSUE :
Duplicate public VLAN for two different admin accounts.

STEPS TO REPRODUCE :

1. Start multiple threads for executing createVlanIpRange API.
2. Make sure multiple threads run in parallel.
3. Verify vlan table in DB, duplicate entry for same VLAN and IP address range will be encountered, just id and uuid will be different, rest all fields will have similar value.
4. Following entry will be observed in vlan table :
   `mysql> select * from vlan where vlan_id like 'vlan://77' and removed is null;
   +----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
   | id | uuid | vlan_id | vlan_gateway | vlan_netmask | description | vlan_type | data_center_id | network_id | physical_network_id | ip6_gateway | ip6_cidr | ip6_range | removed | created |
   +----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
   | 15 | 6a205b78-d162-43e3-8da9-86a3ff60f40e | vlan://77 | 10.112.63.65 | 255.255.255.192 | 10.112.63.66-10.112.63.70 | VirtualNetwork | 1 | 200 | 200 | NULL | NULL | NULL | NULL | 2017-12-13 12:55:51 |

| 17 | ff8b5175-b247-45a5-b8d3-feb6a1ca64d0 | vlan://77 | 10.112.63.65 | 255.255.255.192 | 10.112.63.66-10.112.63.70 | VirtualNetwork | 1 | 200 | 200 | NULL | NULL | NULL | NULL | 2017-12-13 12:55:51 |
+----+--------------------------------------+-----------+--------------+-----------------+---------------------------+----------------+----------------+------------+---------------------+-------------+----------+-----------+---------+---------------------+
`

[niteshsarda]

Below is an existing code, changes can be seen due to addition of spaces for doing proper alignment.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1390

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1807)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31546 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2361-t1807-kvm-centos7.zip
Test completed. Failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	Failure	61.79	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Failure	173.22	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	178.09	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	278.84	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	Error	5.23	test_templates.py
test_03_create_template_with_checksum_sha256	Error	5.22	test_templates.py
test_04_create_template_with_checksum_md5	Error	5.22	test_templates.py
test_01_vpc_remote_access_vpn	Failure	71.03	test_vpc_vpn.py
test_hostha_kvm_host_degraded	Error	25.86	test_hostha_kvm.py
test_hostha_kvm_host_fencing	Error	1262.39	test_hostha_kvm.py

[niteshsarda]

Test Cases which are failing are not related to these changes.

[yadvr]

Test LGTM, ignoring known failures. Additional review requested.

[mrunalinikankariya]

Code LGTM

[niteshsarda]

@rhtyd : Can you please merge this PR as code LGTM is given by @mrunalinikankariya ?

[yadvr]

Merging based on code review and test results.