CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name

[bwsw]

Bug is fixed. Fixed typo 'adress' to 'address' everywhere which leads to correct generation for agent communication json dhcp command.

@rhtyd
@dagsonstebo

Take a look please. Fixes the bug reported by Dag Sonstebo for Basic zone but unable to test carefully for Advanced zone VR.

Tested in our pre-prod 4.10.

Create / abc (x.y.z.11), cde (x.y.z.13)
Remove / abc, cde
Create / cde -> /etc/hosts (x.y.z.11 -> cde, x.y.z.13 removed)

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1430

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

<> is deprecated and removed in Python 3.x, please use != instead.

[bwsw]

@rhtyd code is fixed ( <> changed to != )

[yadvr]

Code approved, subject to test results.

[yadvr]

Tested locally, on redeploying an old VM with the same name, older entries are removing from /etc/hosts file.

[bwsw]

@rhtyd
@wido
Also, I haven't found if IPv6 dns resolution is implemented in VR dnsmasq currently, at least ipv6 records are not written into /etc/hosts. Can you clarify?

[blueorangutan]

Trillian test result (tid-1836)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31616 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2366-t1836-kvm-centos7.zip
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	Failure	57.68	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Failure	243.89	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	153.24	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	309.27	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	Error	5.24	test_templates.py
test_03_create_template_with_checksum_sha256	Error	5.24	test_templates.py
test_04_create_template_with_checksum_md5	Error	5.22	test_templates.py
test_01_vpc_remote_access_vpn	Error	55.83	test_vpc_vpn.py
test_hostha_kvm_host_recovering	Error	25.73	test_hostha_kvm.py

[yadvr]

Tests LGTM, merging based on two lgtms and results (ignoring known failures).