Skip to content

[CLOUDSTACK-10214] Unable to remove local primary storage - #2390

Merged
rafaelweingartner merged 1 commit into
apache:masterfrom
rafaelweingartner:CLOUDSTACK-10214
Apr 12, 2018
Merged

[CLOUDSTACK-10214] Unable to remove local primary storage#2390
rafaelweingartner merged 1 commit into
apache:masterfrom
rafaelweingartner:CLOUDSTACK-10214

Conversation

@rafaelweingartner

@rafaelweingartnerrafaelweingartner commented Jan 5, 2018

Copy link
Copy Markdown
Member

When enabling the use of local storage ACS will automatically load all local storage configured in the Host and start using them as primary storage to deploy user VMs (if the service offering allows to do so). However, if the operator wants to remove the local storage ACS will throw an exception saying that the removal of local storage is not allowed.Therefore, if one wants to remove a local storage, he/she needs to do a manual intervention in the database and hosts.

This limitation was removed as it was only a logical restriction.

@rafaelweingartner
rafaelweingartnerforce-pushed the CLOUDSTACK-10214 branch 2 times, most recently from f3b3487 to b1097cfCompareJanuary 15, 2018 10:07
@rafaelweingartnerrafaelweingartner self-assigned this Jan 29, 2018
@rafaelweingartnerrafaelweingartner added this to the 4.12 milestone Jan 30, 2018
@rafaelweingartner

rafaelweingartner commented Mar 19, 2018

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Mar 19, 2018

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 19, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1793

@rafaelweingartner

rafaelweingartner commented Mar 19, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@borisstoyanov is it possible to get some details on why the Debian package is failing here?

@borisstoyanov

borisstoyanov commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

I've just re-run it and it succeed. @rafaelweingartner

@rafaelweingartner

rafaelweingartner commented Mar 20, 2018

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Mar 20, 2018

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 20, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1799

@rafaelweingartner
rafaelweingartnerforce-pushed the CLOUDSTACK-10214 branch 2 times, most recently from c8b2cb7 to a8d6d28CompareApril 10, 2018 14:10
@rafaelweingartner

rafaelweingartner commented Apr 10, 2018

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 10, 2018

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 10, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1898

@borisstoyanov

borisstoyanov commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 11, 2018

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 12, 2018

Copy link
Copy Markdown

Trillian test result (tid-2489)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 87341 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2390-t2489-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_04_restart_network_wo_cleanupFailure4.03test_routers.py
test_05_rvpc_multi_tiersFailure319.70test_vpc_redundant.py
test_05_rvpc_multi_tiersError342.76test_vpc_redundant.py

borisstoyanov
borisstoyanov approved these changes Apr 12, 2018
View reviewed changes

@borisstoyanovborisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DaanHoogland
DaanHoogland approved these changes Apr 12, 2018
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1;

@rafaelweingartner
rafaelweingartner merged commit eba2e1d into apache:masterApr 12, 2018
@yadvryadvr modified the milestones: 4.12.0.0, 4.11.1.0May 3, 2018
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 3, 2018
@rafaelweingartner@yadvr
CLOUDSTACK-10214: Unable to remove local primary storage (apache#2390)
885e523
Allow admins to remove primary storage pool.
Cherry-picked from eba2e1d
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit that referenced this pull request May 9, 2018
@yadvr
backports for 4.11.1 from master (#2621)
4534cef
* CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's. Added code to skip disabled clusters when selecting a host (#2442)
(cherry picked from commit c3488a5)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* CLOUDSTACK-10318: Bug on sorting ACL rules list in chrome (#2478)
(cherry picked from commit 4412563)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* CLOUDSTACK-10221: Allow IPv6 when creating a Basic Network (#2397)
Since CloudStack 4.10 Basic Networking supports IPv6 and thus
should be allowed to be specified when creating a network.
Signed-off-by: Wido den Hollander <wido@widodh.nl>
(cherry picked from commit 9733a10)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* CLOUDSTACK-10214: Unable to remove local primary storage (#2390)
Allow admins to remove primary storage pool.
Cherry-picked from eba2e1d
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* dateutil: constistency of tzdate input and output (#2392)
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Signed-off-by: Daan Hoogland <daan.hoogland@shapeblue.com>
(cherry picked from commit 2ad5202)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* CLOUDSTACK-10054:Volume download times out in 3600 seconds (#2244)
(cherry picked from commit bb607d0)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user (#2606)
* create account with domain admin showing 'root admin' role
Domain admins should not be able to assign the role of root admin to new users. Therefore, the role ‘root admin’ (or any other of the same type) should not be visible to domain admins.
* License and formatting
* Break long sentence into multiple lines
* Fix wording of method 'getCurrentAccount'
* fix typo in variable name
* [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts
* [CLOUDSTACK-9338] ACS not accounting resources of VMs with custom service offering
ACS is accounting the resources properly when deploying VMs with custom service offerings. However, there are other methods (such as updateResourceCount) that do not execute the resource accounting properly, and these methods update the resource count for an account in the database. Therefore, if a user deploys VMs with custom service offerings, and later this user calls the “updateResourceCount” method, it (the method) will only account for VMs with normal service offerings, and update this as the number of resources used by the account. This will result in a smaller number of resources to be accounted for the given account than the real used value. The problem becomes worse because if the user starts to delete these VMs, it is possible to reach negative values of resources allocated (breaking all of the resource limiting for accounts). This is a very serious attack vector for public cloud providers!
* [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type” (#2404)
* [CLOUDSTACK-10230] User is able to change to “Guest OS type” that has been removed
Users are able to change the OS type of VMs to “Guest OS type” that has been removed. This becomes a security issue when we try to force users to use HVM VMs (Meltdown/Spectre thing). A removed “guest os type” should not be usable by any users in the cloud.
* Remove trailing lines that are breaking build due to checkstyle compliance
* Remove unused imports
* fix classes that were in the wrong folder structure
* Updates to capacity management
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@borisstoyanovborisstoyanovborisstoyanov approved these changes

Assignees

@rafaelweingartnerrafaelweingartner

Labels

component:management-servercomponent:primary-storagetype:bug

Projects

None yet

Milestone

4.12.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rafaelweingartner@blueorangutan@borisstoyanov@DaanHoogland@yadvr