CLOUDSTACK-10109: Fix regression from PR #2295 by yadvr · Pull Request #2394 · apache/cloudstack

yadvr · 2018-01-08T13:50:33Z

It seems a regression has come in, this PR/commit is to test what
fails/takes time on travis.

This is a stabilization PR to fix tests, included in 4.11.

DaanHoogland · 2018-01-08T14:32:20Z

@rhtyd isn't the smoke test PR already for this? can we close that one now?

yadvr · 2018-01-08T14:34:10Z

@DaanHoogland this is to debug and fix the failures in Travis. I created this dummy PR to detect why job 3 has been failing since last few commits, all due to timeout issues. Based on failures, the issues are with:

DaanHoogland · 2018-01-08T14:36:53Z

Is see that @rhtyd . But i wonder why the smoke health test PR #2376 wasn't useable for that

yadvr · 2018-01-08T18:35:29Z

@DaanHoogland using Travis/simulator I found regression introduced in pr #2295. Fixing the title and kick a test round.
@blueorangutan package

blueorangutan · 2018-01-08T18:36:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-01-08T19:03:33Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1626

yadvr · 2018-01-08T19:03:56Z

@blueorangutan test

blueorangutan · 2018-01-08T19:04:31Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2018-01-08T20:15:50Z

Travis has passed finally! /cc @DaanHoogland @mike-tutowski

DaanHoogland

jenkins seems broken now:

Build timed out (after 43 minutes). Marking the build as aborted.
Build was aborted

DaanHoogland · 2018-01-08T22:00:31Z

- _ipAddressDao.update(publicIp.getId(), publicIp);
-
- return ip;
+ return fetchNewPublicIp(dcId, null, null, owner, VlanType.VirtualNetwork, guestNtwkId, isSourceNat, true, null, false, vpcId, displayIp, false);


this is a revert of the code in #2295. Is that functionality now broken?

Yes, that PR incorrectly addressed merge conflict. One of the booleans changed from true to false, this fixes that.

blueorangutan · 2018-01-09T06:01:22Z

Trillian test result (tid-2083)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39405 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2394-t2083-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardown	`Error`	38.63	test_deploy_virtio_scsi_vm.py
test_deploy_vm_from_iso	`Error`	1514.47	test_deploy_vm_iso.py
test_01_1_create_iso_with_checksum_sha1_negative	`Error`	70.60	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	65.49	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	70.59	test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative	`Error`	70.58	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	65.47	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	70.55	test_iso.py
test_03_1_create_iso_with_checksum_md5_negative	`Error`	70.59	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	65.47	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	70.55	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	65.47	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	70.56	test_iso.py
test_01_create_iso	`Failure`	1514.64	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3034.58	test_iso.py
test_03_ssvm_internals	`Failure`	3.32	test_ssvm.py

yadvr · 2018-01-09T06:48:57Z

@blueorangutan package

blueorangutan · 2018-01-09T06:49:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

This fixes regression introduced in PR apache#2295: - Pass assign=true to fetch new public IP - Use wait_until instead of sleep+wait in tests - Loop through list of public IP ranges to match the systemvm gateway - Fix potential NPE seen when adding simulator host(s) - Removes aria2 installation from setup_agent.sh using yum, it's already dependency for cloudstack-agent package Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2018-01-09T07:16:18Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1627

yadvr · 2018-01-09T07:45:57Z

@blueorangutan test

blueorangutan · 2018-01-09T07:46:33Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2018-01-09T08:34:48Z

- yum install aria2 -y
- if [ $? -gt 0 ]
- then
- printf "failed to install aria2"


fyi - this is removed as installing cloudstack-agent will install aria2 and this script assumes a yum-enabled system that will fail on debian/ubuntu etc.

DaanHoogland · 2018-01-09T08:53:41Z

good work @rhtyd thanks for clearing my faulty uderstanding

yadvr · 2018-01-09T09:26:45Z

Thanks @DaanHoogland are you lgtm on it? (pending test results of course)

DaanHoogland · 2018-01-09T11:43:01Z

lgtm

blueorangutan · 2018-01-09T18:45:49Z

Trillian test result (tid-2087)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36843 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2394-t2087-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2018-01-09T19:13:16Z

Merging this based on test results and code reviews, and also that Travis passed.

yadvr added this to the 4.11 milestone Jan 8, 2018

yadvr force-pushed the travis-debug-fix branch from 4e761ab to 07eb32fCompare January 8, 2018 18:33

yadvr changed the title ~~travis: debug which test is failing on travis~~CLOUDSTACK-10109: Fix regression from PR #2295Jan 8, 2018

yadvr added Severity:BLOCKER type:bug labels Jan 8, 2018

yadvr force-pushed the travis-debug-fix branch from 07eb32f to a175ddeCompare January 8, 2018 18:41

yadvr mentioned this pull request Jan 8, 2018
CLOUDSTACK-9620: Enhancements for managed storage #2298
Merged

DaanHoogland reviewed Jan 8, 2018
View reviewed changes

yadvr force-pushed the travis-debug-fix branch from a175dde to 477eb43Compare January 9, 2018 07:01

yadvr commented Jan 9, 2018
View reviewed changes

yadvr merged commit b0d7844 into apache:masterJan 9, 2018

snyk-bot mentioned this pull request Jul 13, 2021
[Snyk] Upgrade node-sass from 4.11.0 to 4.14.1 SNiTEBoBy/cloudstack#37
Open

Uh oh!

Conversation

yadvr commented Jan 8, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Jan 8, 2018

Uh oh!

yadvr commented Jan 8, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Jan 8, 2018

Uh oh!

yadvr commented Jan 8, 2018

Uh oh!

blueorangutan commented Jan 8, 2018

Uh oh!

blueorangutan commented Jan 8, 2018

Uh oh!

yadvr commented Jan 8, 2018

Uh oh!

blueorangutan commented Jan 8, 2018

Uh oh!

yadvr commented Jan 8, 2018

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHooglandJan 8, 2018

Choose a reason for hiding this comment

Uh oh!

yadvrJan 9, 2018

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 9, 2018

Uh oh!

yadvr commented Jan 9, 2018

Uh oh!

blueorangutan commented Jan 9, 2018

Uh oh!

blueorangutan commented Jan 9, 2018

Uh oh!

yadvr commented Jan 9, 2018

Uh oh!

blueorangutan commented Jan 9, 2018

Uh oh!

yadvrJan 9, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 9, 2018

Uh oh!

yadvr commented Jan 9, 2018

Uh oh!

DaanHoogland commented Jan 9, 2018

Uh oh!

blueorangutan commented Jan 9, 2018

Uh oh!

yadvr commented Jan 9, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yadvr commented Jan 8, 2018•
edited
Loading

yadvr commented Jan 8, 2018•
edited
Loading

yadvr commented Jan 9, 2018•
edited
Loading