CLOUDSTACK-10227: Stabilization fixes for 4.11.0.0 by yadvr · Pull Request #2403 · apache/cloudstack

yadvr · 2018-01-11T11:30:38Z

Test and regression fixes
Packaging/systemvmtemplate fixes
DB upgrade path related fixes
Upgrade and post-upgrade failure fixes

Signed-off-by: Rohit Yadav rohit.yadav@shapeblue.com

DaanHoogland

the changes here so far are fine. Let's hope we don't need to add to much here

DaanHoogland · 2018-01-11T14:04:06Z

 Requires: libvirt-python
 Requires: qemu-img
 Requires: qemu-kvm
-Requires: epel-release


note that only this is the blocker not the rest of the changes but they do make sense in coherence, so 👍

Thanks Daan, rest of the changes are around fixing smoketests regressions and upgrade related fixes.

- Test and regression fixes - Packaging/systemvmtemplate fixes - DB upgrade path related fixes - Upgrade and post-upgrade failure fixes Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

…e, show option only to admins Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

…any disk that matches the requested size Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2018-01-12T19:35:53Z

@blueorangutan package

yadvr · 2018-01-12T19:59:30Z

@rafaelweingartner @wido @marcaurele and others - review requested. I'll kick smoketests as soon as packaging is back. Also, I'll update checksums of the new 4.11 systemvmtemplate over the weekend in the db upgrade path.

rafaelweingartner

Everything seems to be ok here

blueorangutan · 2018-01-12T20:54:26Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1650

yadvr · 2018-01-12T20:54:47Z

@blueorangutan test matrix

blueorangutan · 2018-01-12T20:55:26Z

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-01-13T06:55:34Z

Trillian test result (tid-2131)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34394 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2403-t2131-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.48	test_host_maintenance.py

blueorangutan · 2018-01-13T07:01:19Z

Trillian test result (tid-2134)
Environment: kvm-ubuntu (x2), Advanced Networking with Mgmt server u
Total time taken: 34419 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2403-t2134-kvm-ubuntu.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_hostha_enable_ha_when_host_in_maintenance	`Error`	2.99	test_hostha_kvm.py

blueorangutan · 2018-01-13T08:48:46Z

Trillian test result (tid-2133)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
Total time taken: 41175 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2403-t2133-xenserver-71.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 62 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Error`	17.73	test_scale_vm.py
test_01_list_sec_storage_vm	`Failure`	0.21	test_ssvm.py
test_05_stop_ssvm	`Failure`	125.41	test_ssvm.py
test_04_extract_template	`Failure`	128.42	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	147.04	test_volumes.py

yadvr · 2018-01-13T11:42:56Z

@blueorangutan test centos7 xenserver-65sp1

blueorangutan · 2018-01-13T11:43:36Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

blueorangutan · 2018-01-13T11:57:09Z

Trillian test result (tid-2132)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52483 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2403-t2132-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

wido · 2018-01-13T17:10:55Z

I find it hard to review this PR as I never have touched VMWare nor the new HA code.

Looking at the code itself I don't see anything weird

DaanHoogland · 2018-01-13T20:14:22Z

rekick

DaanHoogland · 2018-01-13T20:14:36Z

jenkins do your thing

DaanHoogland · 2018-01-13T20:18:45Z

@rhtyd it always seems to be test_ha_configure_enabledisable_across_clusterzones that fails on travis lately. Any idea what changed with this test? it seems not related to any of the 4.11 features. any platform used by the travis jobs maybe?

yadvr · 2018-01-13T20:20:26Z

@dahn this PR fixes a NPE case in hostha bg thread, that fixes that failing hostha-simulator test case on Travis. As you can find that with the npe fix, Travis job passes now.

blueorangutan · 2018-01-14T06:58:49Z

Trillian test result (tid-2145)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31420 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2403-t2145-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	`Failure`	128.27	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	139.85	test_volumes.py

yadvr · 2018-01-14T14:58:26Z

XenServer tests LGTM. I checked the failures were caused due to test_public_ip_range.py failing to remove a fake public IP range dedicated to systemvms, the SSVM got a public IP that was not reachable and failed iso/template/volume related download cases. Rest of the tests pass when there is no vlan-public ip range left by following tests.

==== Marvin Init Successful ====
=== TestName: test_dedicatePublicIpRange | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms_cpvm | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms_ssvm | Status : SUCCESS ===

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2018-01-14T16:57:21Z

FYI - I've updated the checksums, built and uploaded 4.11 systemvmtemplates at:
https://download.cloudstack.org/systemvm/4.11/
mirrored also at: http://dl.rohityadav.cloud/testing/

…ould throw exception Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2018-01-14T18:37:02Z

Merging this based on test results and two lgtms.

yadvr added type:bug Severity:BLOCKER labels Jan 11, 2018

yadvr added this to the 4.11 milestone Jan 11, 2018

yadvr added the status:work-in-progress label Jan 11, 2018

DaanHoogland approved these changes Jan 11, 2018
View reviewed changes

yadvr added 2 commits January 12, 2018 15:25

CLOUDSTACK-10227: Stabilization fixes for 4.11.0.0
41db25a
- Test and regression fixes - Packaging/systemvmtemplate fixes - DB upgrade path related fixes - Upgrade and post-upgrade failure fixes Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

direct download: don't force users to download aria2 from epel-releas…
275a628
…e, show option only to admins Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the 411-blockers branch from 077f3cf to 275a628Compare January 12, 2018 09:56

NPE: Fix intermittent host-ha enable/disable cluster failure
c7eed85
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr mentioned this pull request Jan 12, 2018
[CLOUDSTACK-10128] Simplify the search for host to execute command #2402
Merged

on vmware disk may sometimes appear as sda or hdb/hda, so search for …
8ebe280
…any disk that matches the requested size Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added the component:travis label Jan 12, 2018

fix edit template failure on xenserver
ff77752
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr mentioned this pull request Jan 12, 2018
CLOUDSTACK-9620: Enhancements for managed storage #2298
Merged

yadvr removed the status:work-in-progress label Jan 12, 2018

rafaelweingartner approved these changes Jan 12, 2018
View reviewed changes

DaanHoogland closed this Jan 13, 2018

DaanHoogland reopened this Jan 13, 2018

yadvr added 2 commits January 14, 2018 20:53

fix ssvm test to loop through public ip range to check ssvm/cpvm gateway
c4326db
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

update systemvm links and checksums
2df3bd5
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

revert exception catching, resizing non-cusotmisable disk offering sh…
49ebd72
…ould throw exception Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr merged commit fa7c1e2 into apache:masterJan 14, 2018

Uh oh!

Conversation

yadvr commented Jan 11, 2018

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHooglandJan 11, 2018

Choose a reason for hiding this comment

Uh oh!

yadvrJan 11, 2018

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jan 12, 2018

Uh oh!

yadvr commented Jan 12, 2018

Uh oh!

rafaelweingartner left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 12, 2018

Uh oh!

yadvr commented Jan 12, 2018

Uh oh!

blueorangutan commented Jan 12, 2018• edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jan 13, 2018

Uh oh!

blueorangutan commented Jan 13, 2018

Uh oh!

blueorangutan commented Jan 13, 2018

Uh oh!

yadvr commented Jan 13, 2018

Uh oh!

blueorangutan commented Jan 13, 2018

Uh oh!

blueorangutan commented Jan 13, 2018

Uh oh!

wido commented Jan 13, 2018

Uh oh!

DaanHoogland commented Jan 13, 2018

Uh oh!

DaanHoogland commented Jan 13, 2018

Uh oh!

DaanHoogland commented Jan 13, 2018

Uh oh!

yadvr commented Jan 13, 2018

Uh oh!

blueorangutan commented Jan 14, 2018

Uh oh!

yadvr commented Jan 14, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Jan 14, 2018

Uh oh!

yadvr commented Jan 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

blueorangutan commented Jan 12, 2018•
edited by yadvr
Loading

yadvr commented Jan 14, 2018•
edited
Loading