packaging: use libuuid x86_64 package for cloudstack-common by yadvr · Pull Request #2706 · apache/cloudstack

yadvr · 2018-06-11T06:59:24Z

This forces the rpm cloudstack-common package to install libuuid x86_64 pkg instead of the i686 package.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

How Has This Been Tested?

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2018-06-11T06:59:41Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-11T07:25:43Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2115

yadvr · 2018-06-11T07:45:56Z

Closing this, the built package still tries to install the following: /cc @DaanHoogland
libuuid i686 2.23.2-52.el7 base 81 k
I'm not sure how to fix that.

rafaelweingartner · 2018-06-11T07:51:44Z

@rhtyd you should force ``glibc` to use the 64 bits package, then I guess it should fix this problem.

yadvr · 2018-06-11T07:53:28Z

@rafaelweingartner I'm not sure how to force that, if needed I'll relook at this tomorrow in case @DaanHoogland @PaulAngus requires my assistance. This certainly is not a huge issue, we can do in 4.11.2.0.

rafaelweingartner · 2018-06-11T07:57:53Z

Something like Requires: glibc.x86_64 should do the tricky.

DaanHoogland · 2018-06-11T13:05:20Z

Rohit, i just did a test with the packages from this PR. the host has libuuid.x86_64 2.23.2-43.el7_4.2 installed, so that is fine
the MS has both installed but does start, so I wonder if this is a problem.
I'll try the 6x version

blueorangutan · 2018-06-11T13:05:41Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2018-06-11T13:07:16Z

just double checked: the host also has both versions installed (without conflict)

blueorangutan · 2018-06-11T13:36:03Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2116

DaanHoogland · 2018-06-12T18:40:38Z

@blueorangutan package

blueorangutan · 2018-06-12T18:41:41Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-12T19:05:24Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2118

DaanHoogland · 2018-06-13T11:00:37Z

@blueorangutan package

blueorangutan · 2018-06-13T11:01:41Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-13T11:33:36Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2120

This reverts commit b3fb895.

DaanHoogland · 2018-06-13T12:20:18Z

@blueorangutan package

blueorangutan · 2018-06-13T12:20:41Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-13T12:51:46Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2121

wido · 2018-06-13T12:54:18Z

I'm not so much of a RPM expert and I don't know what the exclude here does.

Why are we playing with .so files in a spec file while a RPM should handle this for us?

DaanHoogland · 2018-06-13T13:27:08Z

@wido you are not. I forgot about that, sorry.
The other part is that I remove the explicit installation of a 32bit links in the systemvm template. you might have an opinion on that ;)

DaanHoogland · 2018-06-13T13:27:20Z

@blueorangutan test

blueorangutan · 2018-06-13T13:27:41Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-06-13T20:19:54Z

Trillian test result (tid-2756)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23153 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2706-t2756-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	138.43	test_privategw_acl.py

wido · 2018-06-14T09:08:21Z

Looks good to me removing those old 32-bit things from the SSVM template :)

yadvr · 2018-06-14T10:02:18Z

- apt-get update
- ${apt_get} install links:i386 libuuid1:i386 libc6:i386
- fi
+ ${apt_get} install links


The vhd-util we bundle with systemvm.iso/cloudstack is used by ssvm, and needs the i386 libs:
ldd ./scripts/vm/hypervisor/xenserver/vhd-util
linux-gate.so.1 => (0xf7f23000)
libuuid.so.1 => /lib/i386-linux-gnu/libuuid.so.1 (0xf7edb000)
libc.so.6 => /lib/i386-linux-gnu/libc.so.6 (0xf7d05000)
/lib/ld-linux.so.2 (0xf7f25000)

Does it need the 32 bits library? Or, is it a matter of creating a symbolic link to the files of the 64 bits library?

Yes, see the ldd output. Either we'll need libuuid:i386 or rebuild/ship a 64-bit vhd-util binary.

I mean, can't we simply do the following?
mkdir /lib/x86_64-linux-gnu/ ln -s /lib/x86_64-linux-gnu/libuuid.so.1 /lib/i386-linux-gnu/libuuid.so.1 ln -s /lib/x86_64-linux-gnu/libc.so.6 /lib/i386-linux-gnu/libc.so.6
The libraries are already in the 64bits system when we install the "links" for 64bits. The problem is that they are in a different path.
If we create the symbolic links, we would have the following then:
root@debian:~# ls -lah /lib/i386-linux-gnu/ lrwxrwxrwx 1 root root 31 Jun 14 08:25 libc.so.6 -> /lib/x86_64-linux-gnu/libc.so.6 lrwxrwxrwx 1 root root 34 Jun 14 08:24 libuuid.so.1 -> /lib/x86_64-linux-gnu/libuuid.so.1
Would this work?

@rhtyd if we have the proper version to rebuild that would be best. In any way teh cloudstack-common package doesn't need it, only the systemvm template.
we can either
ammend the commit that removes the 32 dependencies to allow for glibc and libuuid, or
rebuild vhdutil
What ever is easiest will do for this release, i think

@DaanHoogland I can try to build vhd-util x86_64 binary for linux, but we can do that for the future 4.11.2.0 release. The easiest would be to continue to install the 32bit dependencies in systemvm like we've done in the current 4.11.1 systemvmtemplate.

@DaanHoogland Based on the last comment, can you remove the changes to the systemvm template build script? Once we have the 64-bit vhd-util we can remove the changes from this file.

will do, and then of course test if this fixes the centos7 dependencies at least.

DaanHoogland · 2018-06-18T07:41:54Z

@blueorangutan package

blueorangutan · 2018-06-18T07:42:42Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2018-06-18T07:47:14Z

 apt-get autoclean

- #32 bit architecture support:: not required for 32 bit template
+ ${apt_get} install links


For 64-bit binaries, this may be moved to lines up like line 60-73. I'm not sure where links is used at all (perhaps for debugging purposes).

change if you will

blueorangutan · 2018-06-18T08:13:59Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2126

DaanHoogland · 2018-06-18T12:09:13Z

@blueorangutan test

blueorangutan · 2018-06-18T12:09:43Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-06-18T21:19:50Z

Trillian test result (tid-2761)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31212 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2706-t2761-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	183.09	test_privategw_acl.py
test_02_not_secured_vm_migration	`Error`	174.65	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	212.37	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	256.83	test_vpc_redundant.py
test_02_VPC_default_routes	`Failure`	117.98	test_vpc_router_nics.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.24	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.43	test_hostha_kvm.py

yadvr

Lgtm

yadvr · 2018-06-19T11:26:28Z

@PaulAngus @DaanHoogland this is ready for merge once the cloudstack-common rpm is verified to not install the libuuid i386 dependency.

blueorangutan · 2018-06-19T11:35:42Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-19T12:34:52Z

Packaging result: ✖centos6 ✔centos7 ✖debian. JID-2135

packaging: use libuuid x86_64 package for cloudstack-common
b3fb895
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr requested a review from DaanHoogland June 11, 2018 06:59

yadvr added this to the 4.11.1.0 milestone Jun 11, 2018

yadvr requested a review from rafaelweingartner June 11, 2018 07:43

yadvr closed this Jun 11, 2018

yadvr removed this from the 4.11.1.0 milestone Jun 11, 2018

DaanHoogland reopened this Jun 11, 2018

64 bit links is packaged
cc5c83c

post scan filter to exclude libuuid.so.1
a4f83e8

DaanHoogland added 2 commits June 13, 2018 14:12

Revert "packaging: use libuuid x86_64 package for cloudstack-common"
78f4f28
This reverts commit b3fb895.

post scan filter to exclude libuuid.so.1 (centos63)
2fb56e2

DaanHoogland requested review from swill and wido and removed request for DaanHoogland June 13, 2018 12:15

DaanHoogland added this to the 4.11.1.0 milestone Jun 14, 2018

yadvr commented Jun 14, 2018
View reviewed changes

revert removal of 32 bit support for vhd-util libs
8a33b74

yadvr commented Jun 18, 2018
View reviewed changes

yadvr commented Jun 19, 2018
View reviewed changes

PaulAngus added type:bug component:kvm status:ready-for-merge labels Jun 19, 2018

DaanHoogland merged commit c87ca1b into apache:4.11Jun 19, 2018

DaanHoogland removed the status:ready-for-merge label Dec 4, 2024

Uh oh!

Conversation

yadvr commented Jun 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

GitHub Issue/PRs

How Has This Been Tested?

Checklist:

Uh oh!

blueorangutan commented Jun 11, 2018

Uh oh!

blueorangutan commented Jun 11, 2018

Uh oh!

yadvr commented Jun 11, 2018

Uh oh!

rafaelweingartner commented Jun 11, 2018

Uh oh!

yadvr commented Jun 11, 2018

Uh oh!

rafaelweingartner commented Jun 11, 2018

Uh oh!

DaanHoogland commented Jun 11, 2018

Uh oh!

blueorangutan commented Jun 11, 2018

Uh oh!

DaanHoogland commented Jun 11, 2018

Uh oh!

blueorangutan commented Jun 11, 2018

Uh oh!

DaanHoogland commented Jun 12, 2018

Uh oh!

blueorangutan commented Jun 12, 2018

Uh oh!

blueorangutan commented Jun 12, 2018

Uh oh!

DaanHoogland commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

DaanHoogland commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

wido commented Jun 13, 2018

Uh oh!

DaanHoogland commented Jun 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

blueorangutan commented Jun 13, 2018

Uh oh!

wido commented Jun 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelweingartnerJun 14, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 18, 2018

Uh oh!

yadvr commented Jun 11, 2018•
edited
Loading

DaanHoogland commented Jun 13, 2018•
edited
Loading

rafaelweingartnerJun 14, 2018•
edited
Loading