Update Apache DBCP version by nvazquez · Pull Request #2718 · apache/cloudstack

nvazquez · 2018-06-21T01:38:55Z

Description

Upgrade Apache DBCP version from 1.x to 2.x version.
Benefits: http://commons.apache.org/proper/commons-dbcp/

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Built local environment from scratch, deployed simple environment correctly.
Local environment working, packages updated, continues working
Simulator working locally
Usage module working

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

nvazquez · 2018-06-21T01:43:54Z

@blueorangutan package

blueorangutan · 2018-06-21T01:44:42Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-21T02:17:08Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2143

nvazquez · 2018-06-21T02:17:46Z

@blueorangutan test

blueorangutan · 2018-06-21T02:18:42Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr

LGTM, subject to testing (I've not tested, but Travis is green so PR looks promising!). Can we also consider moving to HikariCP?

nvazquez · 2018-06-21T11:42:56Z

Thanks @rhtyd, we have made an attempt to HikariCP on this PR #2603 but unfortunately faced lot of increasing issues and estimate a big effort for fixing all of them

nvazquez · 2018-06-21T13:40:06Z

@blueorangutan test

blueorangutan · 2018-06-21T13:40:42Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2018-06-22T16:26:10Z

@blueorangutan package

blueorangutan · 2018-06-22T16:26:43Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-22T16:58:44Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2149

nvazquez · 2018-06-23T15:11:16Z

@blueorangutan package

blueorangutan · 2018-06-23T15:11:43Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-06-23T15:44:15Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2150

nvazquez · 2018-06-23T15:45:33Z

@blueorangutan test

blueorangutan · 2018-06-23T15:45:43Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-06-24T01:54:58Z

Trillian test result (tid-2815)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34788 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2718-t2815-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1132.54	test_privategw_acl.py
test_04_extract_template	`Failure`	128.36	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_secure_vm_migration	`Error`	4.20	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	1.11	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	1.12	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	1.12	test_vm_life_cycle.py
test_06_download_detached_volume	`Failure`	137.65	test_volumes.py
test_11_migrate_volume_and_change_offering	`Error`	127.96	test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	3.75	test_hostha_kvm.py

nvazquez · 2018-06-24T02:07:12Z

@blueorangutan test matrix

blueorangutan · 2018-06-24T02:07:44Z

@nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

nvazquez · 2018-06-25T18:05:23Z

@blueorangutan test matrix

blueorangutan · 2018-06-25T18:05:44Z

@nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-06-26T01:09:46Z

Trillian test result (tid-2822)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23516 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2718-t2822-xenserver-71.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_provision_certificate	`Error`	7.25	test_certauthority_root.py
test_01_scale_vm	`Error`	19.55	test_scale_vm.py
test_11_migrate_volume_and_change_offering	`Error`	5.39	test_volumes.py

blueorangutan · 2018-06-26T01:45:24Z

Trillian test result (tid-2823)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2718-t2823-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1110.45	test_privategw_acl.py
test_01_secure_vm_migration	`Error`	3.18	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	1.10	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	3.15	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	1.10	test_vm_life_cycle.py
test_11_migrate_volume_and_change_offering	`Error`	129.20	test_volumes.py

blueorangutan · 2018-06-26T07:29:34Z

Trillian test result (tid-2824)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46427 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2718-t2824-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov

LGTM, based on test results and code review

nvazquez · 2018-07-09T21:53:47Z

Thanks @borisstoyanov! @rhtyd @DaanHoogland do you approve as well?

yadvr · 2018-07-10T06:23:41Z

LGTM, merging this based on tests and and reviews.

* Update Apache DBCP version * Fix DB connection * Prevent hang on the db creation

Backport #2718 to 4.11 branch for 4.11.2.0

Update Apache DBCP version
a3603ce

nvazquez requested review from DaanHoogland and yadvr June 21, 2018 02:02

nvazquez added component:database component:upgrade labels Jun 21, 2018

nvazquez added this to the 4.12.0.0 milestone Jun 21, 2018

yadvr approved these changes Jun 21, 2018
View reviewed changes

nvazquez changed the title ~~Update Apache DBCP version~~WIP: Update Apache DBCP versionJun 22, 2018

Fix DB connection
14ab00e

Prevent hang on the db creation
999834c

nvazquez changed the title ~~WIP: Update Apache DBCP version~~Update Apache DBCP versionJun 23, 2018

borisstoyanov approved these changes Jul 9, 2018
View reviewed changes

yadvr merged commit 9fb36e7 into apache:masterJul 10, 2018

borisstoyanov pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 23, 2018
db: Update Apache DBCP version (apache#2718)
bb420c7
* Update Apache DBCP version * Fix DB connection * Prevent hang on the db creation

nvazquez mentioned this pull request Aug 16, 2018
Backport Update DBCP version to 4.11 #2809
Merged
12 tasks

yadvr pushed a commit that referenced this pull request Aug 17, 2018
backport: Update DBCP version to 4.11 (#2809)
c687134
Backport #2718 to 4.11 branch for 4.11.2.0

nvazquez deleted the updatedbcp branch April 6, 2020 14:47

Uh oh!

Conversation

nvazquez commented Jun 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

nvazquez commented Jun 21, 2018

Uh oh!

blueorangutan commented Jun 21, 2018

Uh oh!

blueorangutan commented Jun 21, 2018

Uh oh!

nvazquez commented Jun 21, 2018

Uh oh!

blueorangutan commented Jun 21, 2018

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jun 21, 2018

Uh oh!

nvazquez commented Jun 21, 2018

Uh oh!

blueorangutan commented Jun 21, 2018

Uh oh!

nvazquez commented Jun 22, 2018

Uh oh!

blueorangutan commented Jun 22, 2018

Uh oh!

blueorangutan commented Jun 22, 2018

Uh oh!

nvazquez commented Jun 23, 2018

Uh oh!

blueorangutan commented Jun 23, 2018

Uh oh!

blueorangutan commented Jun 23, 2018

Uh oh!

nvazquez commented Jun 23, 2018

Uh oh!

blueorangutan commented Jun 23, 2018

Uh oh!

blueorangutan commented Jun 24, 2018

Uh oh!

nvazquez commented Jun 24, 2018

Uh oh!

blueorangutan commented Jun 24, 2018

Uh oh!

nvazquez commented Jun 25, 2018

Uh oh!

blueorangutan commented Jun 25, 2018

Uh oh!

blueorangutan commented Jun 26, 2018

Uh oh!

blueorangutan commented Jun 26, 2018

Uh oh!

blueorangutan commented Jun 26, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jul 9, 2018

Uh oh!

yadvr commented Jul 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nvazquez commented Jun 21, 2018•
edited
Loading