Changing to the right api call for securing hosts by borisstoyanov · Pull Request #2754 · apache/cloudstack

borisstoyanov · 2018-07-19T08:30:41Z

Description

This fixes the tests for secure live migration, looks like they were pointing to the wrong api call. However during testing of this I've hit a new issue #2753 which is blocking the tests.

Types of changes

Bug fix (non-breaking change which fixes an issue)

GitHub Issue/PRs

The tests will pass when #2753 is fixed, since they are using a parameter in the provisionCertificate api call which makes a NPE

Screenshots (if appropriate):

NA

How Has This Been Tested?

Locally with a debugger, api call seem right but it hits the mentioned issue

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

DaanHoogland

makes sense

borisstoyanov · 2018-07-20T07:20:55Z

@blueorangutan package

blueorangutan · 2018-07-20T07:21:50Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-20T07:58:11Z

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2195

borisstoyanov · 2018-07-20T08:03:20Z

@blueorangutan test

DaanHoogland · 2018-07-20T08:03:39Z

ERROR: Error cloning remote repo 'origin' !!!???
@blueorangutan package

blueorangutan · 2018-07-20T08:03:50Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

borisstoyanov · 2018-07-20T08:27:48Z

@blueorangutan test

blueorangutan · 2018-07-20T08:28:51Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-07-20T08:37:09Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2196

dhlaluku

LGTM

blueorangutan · 2018-07-20T19:09:52Z

Trillian test result (tid-2874)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2874-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host	`Error`	0.93	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.11	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.20	test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1222.46	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	438.10	test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store	`Error`	0.19	test_snapshots.py
test_01_secure_vm_migration	`Error`	139.05	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	137.05	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	137.02	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	139.05	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	19.96	test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	0.13	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.35	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	5.61	test_hostha_kvm.py

borisstoyanov · 2018-07-23T07:21:48Z

@blueorangutan package

blueorangutan · 2018-07-23T07:22:51Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-23T08:13:21Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2199

borisstoyanov · 2018-07-23T08:13:25Z

@blueorangutan package

blueorangutan · 2018-07-23T08:13:51Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-23T09:05:17Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2201

borisstoyanov · 2018-07-23T09:07:31Z

@blueorangutan test

blueorangutan · 2018-07-23T09:07:51Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-07-23T17:07:41Z

Trillian test result (tid-2879)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2879-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host	`Error`	0.65	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.12	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.22	test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1107.33	test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.16	test_snapshots.py
test_01_secure_vm_migration	`Error`	132.94	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	131.91	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	132.94	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	131.91	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	15.84	test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	1.13	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1.29	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	4.58	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Failure`	639.25	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Failure`	618.70	test_hostha_kvm.py

borisstoyanov · 2018-07-24T06:02:01Z

@blueorangutan test

blueorangutan · 2018-07-24T06:02:52Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov · 2018-07-24T07:29:06Z

vm_lifecycle tests are caused by the following issue #2763

blueorangutan · 2018-07-24T15:27:22Z

Trillian test result (tid-2881)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32196 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2881-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host	`Error`	0.76	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.09	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.17	test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1282.12	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	369.15	test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.15	test_snapshots.py
test_01_secure_vm_migration	`Error`	137.89	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	136.84	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	136.89	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	136.83	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	19.78	test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	0.10	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1.26	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.43	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	8.52	test_hostha_kvm.py

borisstoyanov · 2018-07-25T06:41:11Z

Closing this in favor of #2764

DaanHoogland requested a review from yadvr July 20, 2018 07:08

DaanHoogland approved these changes Jul 20, 2018
View reviewed changes

dhlaluku approved these changes Jul 20, 2018
View reviewed changes

Changing to the right api call for securing hosts
a687337

borisstoyanov force-pushed the fix-securehost-migration-test branch from eef6040 to a687337Compare July 23, 2018 08:13

yadvr approved these changes Jul 23, 2018
View reviewed changes

borisstoyanov mentioned this pull request Jul 24, 2018
kvm: Fixes #2763 move post-renewal libvirt restart class suitably #2764
Merged
12 tasks

borisstoyanov closed this Jul 25, 2018

dhlaluku mentioned this pull request Aug 16, 2018
kvm: Properly report available memory to Management Server #2795
Merged
12 tasks

snyk-bot mentioned this pull request Jul 13, 2021
[Snyk] Upgrade node-sass from 4.11.0 to 4.14.1 SNiTEBoBy/cloudstack#37
Open

Uh oh!

Conversation

borisstoyanov commented Jul 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Jul 20, 2018

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

borisstoyanov commented Jul 20, 2018

Uh oh!

DaanHoogland commented Jul 20, 2018

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

borisstoyanov commented Jul 20, 2018

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

dhlaluku left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 20, 2018

Uh oh!

borisstoyanov commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

borisstoyanov commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

borisstoyanov commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

blueorangutan commented Jul 23, 2018

Uh oh!

borisstoyanov commented Jul 24, 2018

Uh oh!

blueorangutan commented Jul 24, 2018

Uh oh!

borisstoyanov commented Jul 24, 2018

Uh oh!

blueorangutan commented Jul 24, 2018

Uh oh!

borisstoyanov commented Jul 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

borisstoyanov commented Jul 19, 2018•
edited
Loading