CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…

[Kui-Liu]

… "isXXX".

These boolean-return methods are named as "getXXX".
Other boolean-return methods are named as "isXXX".
Considering there methods will return boolean values, it should be more clear and consistent to rename them as "isXXX".
(rebase #2602)

[DaanHoogland]

@rafaelweingartner@fmaximus we had a discussion about readability vs consistency in #2602. I am allright with this, in spite of my minor remarks there. How bout you guys?
@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2262

[rafaelweingartner]

@DaanHoogland I recall that @fmaximus mentioned some possible problem with the home made JPA implementation we use. If this PR is not breaking anything, let's push it forward. Otherwise, there is not much we can do.

[DaanHoogland]

right, let's see, ...
@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2959)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57118 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2816-t2959-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 6 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	Error	1646.35	test_accounts.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	Error	0.00	test_deploy_virtio_scsi_vm.py
test_02_vpc_privategw_static_routes	Failure	205.44	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1307.31	test_privategw_acl.py
test_02_unsecure_vm_migration	Error	77.64	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	3655.86	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	58.79	test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics	Failure	527.87	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Failure	403.23	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	428.75	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	Error	1.83	test_hostha_kvm.py

[blueorangutan]

Trillian test result (tid-2955)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2816-t2955-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 58 look OK, 11 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	Error	1585.73	test_accounts.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	Error	0.00	test_deploy_virtio_scsi_vm.py
test_deploy_vm_from_iso	Error	1563.80	test_deploy_vm_iso.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	235.19	test_privategw_acl.py
test_04_extract_template	Failure	128.38	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_02_unsecure_vm_migration	Error	87.04	test_vm_life_cycle.py
test_06_download_detached_volume	Failure	137.61	test_volumes.py
test_04_rvpc_network_garbage_collector_nics	Failure	521.05	test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	3.38	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	Error	2.67	test_hostha_kvm.py

[borisstoyanov]

LGTM

[DaanHoogland]

@brucekuiliu sorry to bother again, but can you rebase?

[Kui-Liu]

@DaanHoogland I am sorry, my remote branch was removed. I rebased it in the new request #2847.

[DaanHoogland]

i see @brucekuiliu , better keep it till it's merged ;) We are kind of slow here a lot, so no guarantee we won't ask you again.