Run diagnostics API UI integration for system VMs and VR

[dhlaluku]

Description

This is a UI integration of the runDiagnostics API command that helps Admins troubleshoot network issues on CloudStack hosted networks by executing network-utility commands (ping, traceroute, arping) remotely on system VMs. #2721

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Remote+Diagnostics+API

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

Output

How Has This Been Tested?

As admin, log on to the CloudStack UI;

• Navigate to Infrastructure > System VMs or Virtual Router

• Click on the Run Diagnostics button and fill in the form that pops up.

See screenshots

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

[dhlaluku]

@blueorangutan package

[blueorangutan]

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[dhlaluku]

@houthuis@ernjvr@nvazquez please review

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2281

[dhlaluku]

@blueorangutan test

[blueorangutan]

@dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2981)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30876 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2833-t2981-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1141.42	test_privategw_acl.py
test_04_extract_template	Failure	128.28	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_06_download_detached_volume	Failure	137.57	test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance	Error	3.44	test_hostha_kvm.py

[ernjvr]

it would be better to use a switch case instead of multiple if else, especially for comparing multiple enums

[dhlaluku]

Refactored to switch-case statements

[ernjvr]

Spelling out the entire word looks more professional. Maybe just call it 'Arguments'?

[dhlaluku]

Changed Extra Args -> Extra Arguments

[yadvr]

See minor comments

[yadvr]

@dhlaluku eventType is empty?

[dhlaluku]

Added a new event type "EVENT_SYSTEM_VM_DIAGNOSTICS = SYSTEM.VM.DIAGNOSTICS" and used that.
Notices that most system vm actions (reboot, destroy and so on) also have empty event types.

[ernjvr]

LGTM

[borisstoyanov]

LGMT