Make networkofferingid required in migrateNetwork

[krissterckx]

Fix issue #2851

Description

Made networkofferingid required in migrateNetwork

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: ##2851

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

[rafaelweingartner]

@krissterckx can you explain further how making the networkofferingid required in migrateNetwork affects/solves the issue #2657 "KVM hosts are being reset by a script"?

[krissterckx]

Sorry that has to be #2851 , my bad

[krissterckx]

Changed to #2851

[yadvr]

Moved to 4.11.2.0, in case this bug fix can get in time for RC2.
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2307

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[krissterckx]

Thanks @rhtyd !

[blueorangutan]

Trillian test result (tid-3029)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2852-t3029-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	198.87	test_privategw_acl.py
test_10_attachAndDetach_iso	Error	12.98	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance	Error	1.72	test_hostha_kvm.py

[yadvr]

Merging based on code reviews and tests. This API was added by Nuage in 4.11.0 and changes to required settings can be accepted as I assume this API is not used by others yet (breaking their scripts/integration). (ref CLOUDSTACK-10024: Network migration support)