agent: Fixes #2858 agent LB not working

[yadvr]

This fixes the issue that on reconnection, agent LB feature will fail
and only the first ms-host will be tried reconnection again and again.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

Fixes #2858 /cc @borisstoyanov

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[borisstoyanov]

Thanks for this fix @rhtyd, just tested it manually and it works fine. Let's wait for the smoketests

[DaanHoogland]

oops ;)

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2315

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3039)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36370 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2859-t3039-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 6 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1133.96	test_privategw_acl.py
test_04_extract_template	Failure	128.37	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_01_secure_vm_migration	Error	133.67	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	132.63	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	133.65	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	132.67	test_vm_life_cycle.py
test_08_migrate_vm	Error	15.61	test_vm_life_cycle.py
test_06_download_detached_volume	Failure	137.53	test_volumes.py
test_02_redundant_VPC_default_routes	Failure	170.20	test_vpc_redundant.py

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3041)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 21491 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2859-t3041-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1096.69	test_privategw_acl.py

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2321