Uh oh!
There was an error while loading. Please reload this page.
make sure no time skew can interfere with comparison - #3003
Merged
Conversation
DaanHoogland
commented
Nov 5, 2018
ContributorAuthor
12 tasks
bwsw
commented
Nov 5, 2018
Contributor
@DaanHoogland LGTM, but I'm not a skilled java developer. Don't rely on my review. |
rafaelweingartner
approved these changes
Nov 5, 2018
rafaelweingartner
left a comment
Member
There was a problem hiding this comment.
You just did what I was going to propose
DaanHoogland
commented
Nov 5, 2018
ContributorAuthor
I'll take that as 👍 😉 |
rafaelweingartner
commented
Nov 5, 2018
Member
@DaanHoogland just one remark. What about removing that |
ContributorAuthor
makes sense, if the contents is covoured. I didn't give that any attention, @rafaelweingartner. |
nvazquez
approved these changes
Nov 5, 2018
GabrielBrascher
approved these changes
Nov 6, 2018
DaanHoogland
commented
Nov 6, 2018
ContributorAuthor
Do we need full regression tests? |
blueorangutan
commented
Nov 6, 2018
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
blueorangutan
commented
Nov 6, 2018
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2409 |
rafaelweingartner
commented
Nov 6, 2018
Member
@DaanHoogland I do not think so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
see titel
Types of changes
Test fix
Screenshots (if appropriate):
How Has This Been Tested?