Skip to content

Add api arg validator for create project api (#3097) - #3107

Merged
yadvr merged 1 commit into
apache:masterfrom
anuragaw:3097
Dec 31, 2018
Merged

Add api arg validator for create project api (#3097)#3107
yadvr merged 1 commit into
apache:masterfrom
anuragaw:3097

Conversation

@anuragaw

@anuragawanuragaw commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

Description

Create project command should have an Apiarg validator.

Fixes: #3097

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

When create project is called with empty name or displaytext or both the call fails as it should.

@anuragaw

anuragaw commented Dec 20, 2018

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2499

@yadvryadvr added this to the 4.12.0.0 milestone Dec 20, 2018
@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@anuragaw

anuragaw commented Dec 20, 2018

Copy link
Copy Markdown
ContributorAuthor

@rhtyd - does this also need to go into 4.11? The current PR is against master.

@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member

You call @anuragaw, I did not stress as it is not a major bug. Generally it's good to send bugfix PRs towards the on-going LTS branch.

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

Trillian test result (tid-3267)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 15090 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3107-t3267-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 49 look OK, 21 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_nic_secondaryip_add_removeError30.65test_multipleips_per_nic.py
ContextSuite context=TestResetVmOnReboot>:setupError0.00test_reset_vm_on_reboot.py
test_01_so_removal_resource_updateError1.35test_resource_accounting.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
ContextSuite context=TestLBRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestNatRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestPublicIPUsage>:setupError0.00test_usage.py
ContextSuite context=TestSnapshotUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmUsage>:setupError0.00test_usage.py
ContextSuite context=TestVolumeUsage>:setupError0.00test_usage.py
ContextSuite context=TestVpnUsage>:setupError0.00test_usage.py
ContextSuite context=TestRouterDHCPHosts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setupError0.00test_router_dns.py
ContextSuite context=TestRouterDnsService>:setupError0.00test_router_dnsservice.py
test_02_routervm_iptables_policiesError1.27test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policiesError5.30test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_trueError1.34test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_falseError1.33test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueError4.79test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseError5.99test_routers_network_ops.py
test_03_RVR_Network_check_router_stateError6.00test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setupError0.00test_routers.py
test_01_sys_vm_startFailure0.09test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setupError0.00test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setupError2.12test_service_offerings.py
ContextSuite context=TestCreateVolume>:setupError0.00test_volumes.py
ContextSuite context=TestVolumes>:setupError0.00test_volumes.py
ContextSuite context=TestSnapshotRootDisk>:setupError0.00test_snapshots.py
test_01_list_sec_storage_vmFailure0.03test_ssvm.py
test_02_list_cpvm_vmFailure0.03test_ssvm.py
test_03_ssvm_internalsFailure0.03test_ssvm.py
test_04_cpvm_internalsFailure0.03test_ssvm.py
test_05_stop_ssvmFailure0.03test_ssvm.py
test_06_stop_cpvmFailure0.03test_ssvm.py
test_07_reboot_ssvmFailure0.03test_ssvm.py
test_08_reboot_cpvmFailure0.03test_ssvm.py
test_09_destroy_ssvmFailure0.03test_ssvm.py
test_10_destroy_cpvmFailure0.03test_ssvm.py
test_02_create_template_with_checksum_sha1Error65.39test_templates.py
test_03_create_template_with_checksum_sha256Error65.42test_templates.py
test_04_create_template_with_checksum_md5Error65.40test_templates.py
test_05_create_template_with_no_checksumError65.40test_templates.py
test_02_deploy_vm_from_direct_download_templateError1.28test_templates.py
test_03_deploy_vm_wrong_checksumError1.31test_templates.py
ContextSuite context=TestTemplates>:setupError18.46test_templates.py
ContextSuite context=Test01DeployVM>:setupError0.00test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setupError0.00test_vm_life_cycle.py
test_14_secure_to_secure_vm_migrationError11.41test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migrationError74.41test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migrationError1.27test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setupError2.02test_vm_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLError7.02test_vpc_redundant.py
test_02_redundant_VPC_default_routesError6.00test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersError8.02test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError8.01test_vpc_redundant.py
test_05_rvpc_multi_tiersError8.01test_vpc_redundant.py
test_01_VPC_nics_after_destroyError5.96test_vpc_router_nics.py
test_02_VPC_default_routesError5.94test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpnFailure6.38test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_optionsFailure4.91test_vpc_vpn.py
test_01_vpc_remote_access_vpnFailure3.19test_vpc_vpn.py
test_01_vpc_site2site_vpnFailure4.37test_vpc_vpn.py

@borisstoyanov

borisstoyanov commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 21, 2018

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@anuragaw

anuragaw commented Dec 21, 2018

Copy link
Copy Markdown
ContributorAuthor

Sounds good. I think it's not as critical and reasonable to push only to master

@blueorangutan

blueorangutan commented Dec 21, 2018

Copy link
Copy Markdown

Trillian test result (tid-3271)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 13340 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3107-t3271-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 49 look OK, 21 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_nic_secondaryip_add_removeError27.10test_multipleips_per_nic.py
ContextSuite context=TestResetVmOnReboot>:setupError0.00test_reset_vm_on_reboot.py
test_01_so_removal_resource_updateError1.22test_resource_accounting.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
ContextSuite context=TestLBRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestNatRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestPublicIPUsage>:setupError0.00test_usage.py
ContextSuite context=TestSnapshotUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmUsage>:setupError0.00test_usage.py
ContextSuite context=TestVolumeUsage>:setupError0.00test_usage.py
ContextSuite context=TestVpnUsage>:setupError0.00test_usage.py
ContextSuite context=TestRouterDHCPHosts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setupError0.00test_router_dns.py
ContextSuite context=TestRouterDnsService>:setupError0.00test_router_dnsservice.py
test_02_routervm_iptables_policiesError1.18test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policiesError4.22test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_trueError1.23test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_falseError1.24test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueError4.88test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseError6.00test_routers_network_ops.py
test_03_RVR_Network_check_router_stateError6.00test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setupError0.00test_routers.py
test_01_sys_vm_startFailure0.07test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setupError0.00test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setupError1.74test_service_offerings.py
ContextSuite context=TestCreateVolume>:setupError0.00test_volumes.py
ContextSuite context=TestVolumes>:setupError0.00test_volumes.py
ContextSuite context=TestSnapshotRootDisk>:setupError0.00test_snapshots.py
test_01_list_sec_storage_vmFailure0.02test_ssvm.py
test_02_list_cpvm_vmFailure0.02test_ssvm.py
test_03_ssvm_internalsFailure0.02test_ssvm.py
test_04_cpvm_internalsFailure0.02test_ssvm.py
test_05_stop_ssvmFailure0.02test_ssvm.py
test_06_stop_cpvmFailure0.02test_ssvm.py
test_07_reboot_ssvmFailure0.02test_ssvm.py
test_08_reboot_cpvmFailure0.02test_ssvm.py
test_09_destroy_ssvmFailure0.02test_ssvm.py
test_10_destroy_cpvmFailure0.02test_ssvm.py
test_02_create_template_with_checksum_sha1Error65.31test_templates.py
test_03_create_template_with_checksum_sha256Error65.31test_templates.py
test_04_create_template_with_checksum_md5Error65.31test_templates.py
test_05_create_template_with_no_checksumError65.31test_templates.py
test_02_deploy_vm_from_direct_download_templateError1.19test_templates.py
test_03_deploy_vm_wrong_checksumError1.23test_templates.py
ContextSuite context=TestTemplates>:setupError16.67test_templates.py
ContextSuite context=Test01DeployVM>:setupError0.00test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setupError0.00test_vm_life_cycle.py
test_14_secure_to_secure_vm_migrationError11.27test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migrationError74.08test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migrationError1.24test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setupError1.68test_vm_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLError7.71test_vpc_redundant.py
test_02_redundant_VPC_default_routesError7.69test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersError7.71test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError7.71test_vpc_redundant.py
test_05_rvpc_multi_tiersError6.69test_vpc_redundant.py
test_01_VPC_nics_after_destroyError5.66test_vpc_router_nics.py
test_02_VPC_default_routesError4.63test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpnFailure7.31test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_optionsFailure5.27test_vpc_vpn.py
test_01_vpc_remote_access_vpnFailure4.16test_vpc_vpn.py
test_01_vpc_site2site_vpnFailure4.25test_vpc_vpn.py

GabrielBrascher
GabrielBrascher approved these changes Dec 21, 2018
View reviewed changes

@GabrielBrascherGabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@yadvr

yadvr commented Dec 24, 2018

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 24, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Dec 28, 2018

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 28, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 28, 2018

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2508

@yadvr

yadvr commented Dec 31, 2018

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 31, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 31, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2510

@yadvr

yadvr commented Dec 31, 2018

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 31, 2018

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Dec 31, 2018

Copy link
Copy Markdown

Trillian test result (tid-3277)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26663 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3107-t3277-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 68 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_nic_secondaryip_add_removeError40.35test_multipleips_per_nic.py
test_04_rvpc_network_garbage_collector_nicsFailure500.70test_vpc_redundant.py

@yadvr
yadvr merged commit 1ae2b6f into apache:masterDec 31, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvryadvryadvr approved these changes
@GabrielBrascherGabrielBrascherGabrielBrascher approved these changes

Assignees

@anuragawanuragaw

Labels

type:bug

Projects

None yet

Milestone

4.12.0.0

Development

Successfully merging this pull request may close these issues.

CloudStack allows creation of project with empty name

5 participants

@anuragaw@blueorangutan@yadvr@borisstoyanov@GabrielBrascher